* [dpdk-dev] [PATCH] test/eal: add ut for eal options proc-type and uio
@ 2019-06-21 13:50 Lavanya Govindarajan
2019-06-26 9:32 ` Burakov, Anatoly
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: Lavanya Govindarajan @ 2019-06-21 13:50 UTC (permalink / raw)
To: dev
Cc: reshma.pattan, anatoly.burakov, jananeex.m.parthasarathy,
Lavanya Govindarajan
Added unit test cases for EAL flags --proc-type=auto and
--create-uio-dev in order to cover the below functions
eal_proc_type_detect()
rte_eal_create_uio_dev()
Signed-off-by: Lavanya Govindarajan <lavanyax.govindarajan@intel.com>
---
app/test/test_eal_flags.c | 27 +++++++++++++++++++++++++++
1 file changed, 27 insertions(+)
diff --git a/app/test/test_eal_flags.c b/app/test/test_eal_flags.c
index 9112c96d0..82d24e1a8 100644
--- a/app/test/test_eal_flags.c
+++ b/app/test/test_eal_flags.c
@@ -880,6 +880,18 @@ test_misc_flags(void)
const char *argv15[] = {prgname, "--file-prefix=intr",
"-c", "1", "-n", "2", "--vfio-intr=invalid"};
+ /* With process type as auto-detect */
+ const char * const argv16[] = {prgname, "--file-prefix=auto",
+ "-c", "1", "-n", "2", "--proc-type=auto"};
+
+ /* With process type as auto-detect with no-shconf */
+ const char * const argv17[] = {prgname, "-c", "1", "-n", "2",
+ "--proc-type=auto", no_shconf, nosh_prefix, no_huge};
+
+ /* With process type as --create-uio-dev flag */
+ const char * const argv18[] = {prgname, "--file-prefix=uiodev",
+ "-c", "1", "-n", "2", "--create-uio-dev"};
+
/* run all tests also applicable to FreeBSD first */
if (launch_proc(argv0) == 0) {
@@ -956,6 +968,21 @@ test_misc_flags(void)
"--vfio-intr invalid parameter\n");
return -1;
}
+ if (launch_proc(argv16) != 0) {
+ printf("Error - process did not run ok with "
+ "--proc-type as auto parameter\n");
+ return -1;
+ }
+ if (launch_proc(argv17) != 0) {
+ printf("Error - process did not run ok with "
+ "--proc type as auto - no-shconf parameter\n");
+ return -1;
+ }
+ if (launch_proc(argv18) != 0) {
+ printf("Error - process did not run ok with "
+ "--create-uio-dev parameter\n");
+ return -1;
+ }
return 0;
}
--
2.14.1
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [dpdk-dev] [PATCH] test/eal: add ut for eal options proc-type and uio
2019-06-21 13:50 [dpdk-dev] [PATCH] test/eal: add ut for eal options proc-type and uio Lavanya Govindarajan
@ 2019-06-26 9:32 ` Burakov, Anatoly
2019-06-26 9:36 ` David Marchand
2019-06-27 12:12 ` [dpdk-dev] [PATCH v2] " Lavanya Govindarajan
2 siblings, 0 replies; 7+ messages in thread
From: Burakov, Anatoly @ 2019-06-26 9:32 UTC (permalink / raw)
To: Lavanya Govindarajan, dev; +Cc: reshma.pattan, jananeex.m.parthasarathy
On 21-Jun-19 2:50 PM, Lavanya Govindarajan wrote:
> Added unit test cases for EAL flags --proc-type=auto and
> --create-uio-dev in order to cover the below functions
> eal_proc_type_detect()
> rte_eal_create_uio_dev()
>
> Signed-off-by: Lavanya Govindarajan <lavanyax.govindarajan@intel.com>
> ---
Acked-by: Anatoly Burakov <anatoly.burakov@intel.com>
--
Thanks,
Anatoly
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [dpdk-dev] [PATCH] test/eal: add ut for eal options proc-type and uio
2019-06-21 13:50 [dpdk-dev] [PATCH] test/eal: add ut for eal options proc-type and uio Lavanya Govindarajan
2019-06-26 9:32 ` Burakov, Anatoly
@ 2019-06-26 9:36 ` David Marchand
2019-06-27 12:12 ` [dpdk-dev] [PATCH v2] " Lavanya Govindarajan
2 siblings, 0 replies; 7+ messages in thread
From: David Marchand @ 2019-06-26 9:36 UTC (permalink / raw)
To: Lavanya Govindarajan
Cc: dev, Pattan, Reshma, Burakov, Anatoly, jananeex.m.parthasarathy
On Fri, Jun 21, 2019 at 3:52 PM Lavanya Govindarajan <
lavanyax.govindarajan@intel.com> wrote:
> Added unit test cases for EAL flags --proc-type=auto and
> --create-uio-dev in order to cover the below functions
> eal_proc_type_detect()
> rte_eal_create_uio_dev()
>
> Signed-off-by: Lavanya Govindarajan <lavanyax.govindarajan@intel.com>
> ---
> app/test/test_eal_flags.c | 27 +++++++++++++++++++++++++++
> 1 file changed, 27 insertions(+)
>
> diff --git a/app/test/test_eal_flags.c b/app/test/test_eal_flags.c
> index 9112c96d0..82d24e1a8 100644
> --- a/app/test/test_eal_flags.c
> +++ b/app/test/test_eal_flags.c
> @@ -880,6 +880,18 @@ test_misc_flags(void)
> const char *argv15[] = {prgname, "--file-prefix=intr",
> "-c", "1", "-n", "2", "--vfio-intr=invalid"};
>
> + /* With process type as auto-detect */
> + const char * const argv16[] = {prgname, "--file-prefix=auto",
> + "-c", "1", "-n", "2", "--proc-type=auto"};
> +
> + /* With process type as auto-detect with no-shconf */
> + const char * const argv17[] = {prgname, "-c", "1", "-n", "2",
> + "--proc-type=auto", no_shconf, nosh_prefix,
> no_huge};
> +
> + /* With process type as --create-uio-dev flag */
> + const char * const argv18[] = {prgname, "--file-prefix=uiodev",
> + "-c", "1", "-n", "2", "--create-uio-dev"};
> +
>
-n is unneeded to run those tests.
-c 1 is not needed either.
Please drop those.
Thanks.
--
David Marchand
^ permalink raw reply [flat|nested] 7+ messages in thread* [dpdk-dev] [PATCH v2] test/eal: add ut for eal options proc-type and uio
2019-06-21 13:50 [dpdk-dev] [PATCH] test/eal: add ut for eal options proc-type and uio Lavanya Govindarajan
2019-06-26 9:32 ` Burakov, Anatoly
2019-06-26 9:36 ` David Marchand
@ 2019-06-27 12:12 ` Lavanya Govindarajan
2019-07-02 7:33 ` David Marchand
2019-07-03 13:06 ` [dpdk-dev] [PATCH v3] " Lavanya Govindarajan
2 siblings, 2 replies; 7+ messages in thread
From: Lavanya Govindarajan @ 2019-06-27 12:12 UTC (permalink / raw)
To: dev
Cc: reshma.pattan, anatoly.burakov, jananeex.m.parthasarathy,
Lavanya Govindarajan
Added unit test cases for EAL flags --proc-type=auto and
--create-uio-dev in order to cover the below functions
eal_proc_type_detect()
rte_eal_create_uio_dev()
Signed-off-by: Lavanya Govindarajan <lavanyax.govindarajan@intel.com>
Acked-by: Anatoly Burakov <anatoly.burakov@intel.com>
---
v2: Removed core and channels eal options as they are not significant
---
app/test/test_eal_flags.c | 27 +++++++++++++++++++++++++++
1 file changed, 27 insertions(+)
diff --git a/app/test/test_eal_flags.c b/app/test/test_eal_flags.c
index 9112c96d0..17c0e43d2 100644
--- a/app/test/test_eal_flags.c
+++ b/app/test/test_eal_flags.c
@@ -880,6 +880,18 @@ test_misc_flags(void)
const char *argv15[] = {prgname, "--file-prefix=intr",
"-c", "1", "-n", "2", "--vfio-intr=invalid"};
+ /* With process type as auto-detect */
+ const char * const argv16[] = {prgname, "--file-prefix=auto",
+ "--proc-type=auto"};
+
+ /* With process type as auto-detect with no-shconf */
+ const char * const argv17[] = {prgname, "--proc-type=auto",
+ no_shconf, nosh_prefix, no_huge};
+
+ /* With process type as --create-uio-dev flag */
+ const char * const argv18[] = {prgname, "--file-prefix=uiodev",
+ "--create-uio-dev"};
+
/* run all tests also applicable to FreeBSD first */
if (launch_proc(argv0) == 0) {
@@ -956,6 +968,21 @@ test_misc_flags(void)
"--vfio-intr invalid parameter\n");
return -1;
}
+ if (launch_proc(argv16) != 0) {
+ printf("Error - process did not run ok with "
+ "--proc-type as auto parameter\n");
+ return -1;
+ }
+ if (launch_proc(argv17) != 0) {
+ printf("Error - process did not run ok with "
+ "--proc type as auto - no-shconf parameter\n");
+ return -1;
+ }
+ if (launch_proc(argv18) != 0) {
+ printf("Error - process did not run ok with "
+ "--create-uio-dev parameter\n");
+ return -1;
+ }
return 0;
}
--
2.14.1
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [dpdk-dev] [PATCH v2] test/eal: add ut for eal options proc-type and uio
2019-06-27 12:12 ` [dpdk-dev] [PATCH v2] " Lavanya Govindarajan
@ 2019-07-02 7:33 ` David Marchand
2019-07-03 13:06 ` [dpdk-dev] [PATCH v3] " Lavanya Govindarajan
1 sibling, 0 replies; 7+ messages in thread
From: David Marchand @ 2019-07-02 7:33 UTC (permalink / raw)
To: Lavanya Govindarajan
Cc: dev, Pattan, Reshma, Burakov, Anatoly, Parthasarathy, JananeeX M
On Thu, Jun 27, 2019 at 2:18 PM Lavanya Govindarajan <
lavanyax.govindarajan@intel.com> wrote:
> Added unit test cases for EAL flags --proc-type=auto and
> --create-uio-dev in order to cover the below functions
> eal_proc_type_detect()
> rte_eal_create_uio_dev()
>
> Signed-off-by: Lavanya Govindarajan <lavanyax.govindarajan@intel.com>
> Acked-by: Anatoly Burakov <anatoly.burakov@intel.com>
> ---
> v2: Removed core and channels eal options as they are not significant
> ---
>
> app/test/test_eal_flags.c | 27 +++++++++++++++++++++++++++
> 1 file changed, 27 insertions(+)
>
> diff --git a/app/test/test_eal_flags.c b/app/test/test_eal_flags.c
> index 9112c96d0..17c0e43d2 100644
> --- a/app/test/test_eal_flags.c
> +++ b/app/test/test_eal_flags.c
> @@ -880,6 +880,18 @@ test_misc_flags(void)
> const char *argv15[] = {prgname, "--file-prefix=intr",
> "-c", "1", "-n", "2", "--vfio-intr=invalid"};
>
> + /* With process type as auto-detect */
> + const char * const argv16[] = {prgname, "--file-prefix=auto",
> + "--proc-type=auto"};
> +
> + /* With process type as auto-detect with no-shconf */
> + const char * const argv17[] = {prgname, "--proc-type=auto",
> + no_shconf, nosh_prefix, no_huge};
> +
> + /* With process type as --create-uio-dev flag */
> + const char * const argv18[] = {prgname, "--file-prefix=uiodev",
> + "--create-uio-dev"};
> +
> /* run all tests also applicable to FreeBSD first */
>
> if (launch_proc(argv0) == 0) {
> @@ -956,6 +968,21 @@ test_misc_flags(void)
> "--vfio-intr invalid parameter\n");
> return -1;
> }
> + if (launch_proc(argv16) != 0) {
> + printf("Error - process did not run ok with "
> + "--proc-type as auto parameter\n");
> + return -1;
> + }
> + if (launch_proc(argv17) != 0) {
> + printf("Error - process did not run ok with "
> + "--proc type as auto - no-shconf
> parameter\n");
>
Nit: those messages are not that useful, but at least let's make them
consistent by using the full option names: --proc-type and --no-shconf.
+ return -1;
> + }
> + if (launch_proc(argv18) != 0) {
> + printf("Error - process did not run ok with "
> + "--create-uio-dev parameter\n");
> + return -1;
> + }
> return 0;
> }
>
> --
> 2.14.1
>
>
Reviewed-by: David Marchand <david.marchand@redhat.com>
--
David Marchand
^ permalink raw reply [flat|nested] 7+ messages in thread* [dpdk-dev] [PATCH v3] test/eal: add ut for eal options proc-type and uio
2019-06-27 12:12 ` [dpdk-dev] [PATCH v2] " Lavanya Govindarajan
2019-07-02 7:33 ` David Marchand
@ 2019-07-03 13:06 ` Lavanya Govindarajan
2019-07-04 21:52 ` Thomas Monjalon
1 sibling, 1 reply; 7+ messages in thread
From: Lavanya Govindarajan @ 2019-07-03 13:06 UTC (permalink / raw)
To: dev
Cc: reshma.pattan, anatoly.burakov, david.marchand,
jananeex.m.parthasarathy, Lavanya Govindarajan
Added unit test cases for EAL flags --proc-type=auto and
--create-uio-dev in order to cover the below functions
eal_proc_type_detect()
rte_eal_create_uio_dev()
Signed-off-by: Lavanya Govindarajan <lavanyax.govindarajan@intel.com>
Reviewed-by: David Marchand <david.marchand@redhat.com>
Acked-by: Anatoly Burakov <anatoly.burakov@intel.com>
---
v3: Corrected error log message to be consistent
v2: Removed core and channels eal options as they are not significant
---
app/test/test_eal_flags.c | 28 ++++++++++++++++++++++++++++
1 file changed, 28 insertions(+)
diff --git a/app/test/test_eal_flags.c b/app/test/test_eal_flags.c
index 9985ee979..3766c4cfc 100644
--- a/app/test/test_eal_flags.c
+++ b/app/test/test_eal_flags.c
@@ -903,6 +903,18 @@ test_misc_flags(void)
const char *argv15[] = {prgname, "--file-prefix=intr",
"--vfio-intr=invalid"};
+ /* With process type as auto-detect */
+ const char * const argv16[] = {prgname, "--file-prefix=auto",
+ "--proc-type=auto"};
+
+ /* With process type as auto-detect with no-shconf */
+ const char * const argv17[] = {prgname, "--proc-type=auto",
+ no_shconf, nosh_prefix, no_huge};
+
+ /* With process type as --create-uio-dev flag */
+ const char * const argv18[] = {prgname, "--file-prefix=uiodev",
+ "--create-uio-dev"};
+
/* run all tests also applicable to FreeBSD first */
if (launch_proc(argv0) == 0) {
@@ -979,6 +991,22 @@ test_misc_flags(void)
"--vfio-intr invalid parameter\n");
return -1;
}
+ if (launch_proc(argv16) != 0) {
+ printf("Error - process did not run ok with "
+ "--proc-type as auto parameter\n");
+ return -1;
+ }
+ if (launch_proc(argv17) != 0) {
+ printf("Error - process did not run ok with "
+ "--proc-type and --no-shconf parameter\n");
+ return -1;
+ }
+ if (launch_proc(argv18) != 0) {
+ printf("Error - process did not run ok with "
+ "--create-uio-dev parameter\n");
+ return -1;
+ }
+
return 0;
}
--
2.14.1
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [dpdk-dev] [PATCH v3] test/eal: add ut for eal options proc-type and uio
2019-07-03 13:06 ` [dpdk-dev] [PATCH v3] " Lavanya Govindarajan
@ 2019-07-04 21:52 ` Thomas Monjalon
0 siblings, 0 replies; 7+ messages in thread
From: Thomas Monjalon @ 2019-07-04 21:52 UTC (permalink / raw)
To: Lavanya Govindarajan
Cc: dev, reshma.pattan, anatoly.burakov, david.marchand,
jananeex.m.parthasarathy
03/07/2019 15:06, Lavanya Govindarajan:
> Added unit test cases for EAL flags --proc-type=auto and
> --create-uio-dev in order to cover the below functions
> eal_proc_type_detect()
> rte_eal_create_uio_dev()
>
> Signed-off-by: Lavanya Govindarajan <lavanyax.govindarajan@intel.com>
> Reviewed-by: David Marchand <david.marchand@redhat.com>
> Acked-by: Anatoly Burakov <anatoly.burakov@intel.com>
Applied, thanks
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2019-07-04 21:52 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-21 13:50 [dpdk-dev] [PATCH] test/eal: add ut for eal options proc-type and uio Lavanya Govindarajan
2019-06-26 9:32 ` Burakov, Anatoly
2019-06-26 9:36 ` David Marchand
2019-06-27 12:12 ` [dpdk-dev] [PATCH v2] " Lavanya Govindarajan
2019-07-02 7:33 ` David Marchand
2019-07-03 13:06 ` [dpdk-dev] [PATCH v3] " Lavanya Govindarajan
2019-07-04 21:52 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).