* [PATCH v1] config/arm: add armv7 native config
@ 2021-11-18 10:45 Juraj Linkeš
2021-12-31 7:11 ` Ruifeng Wang
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Juraj Linkeš @ 2021-11-18 10:45 UTC (permalink / raw)
To: thomas, david.marchand, bruce.richardson, Honnappa.Nagarahalli,
Ruifeng.Wang, ferruh.yigit, christian.ehrhardt
Cc: dev, Juraj Linkeš
Arvm7 native build fails with this error:
../config/meson.build:364:1: ERROR: Problem encountered:
Number of CPU cores not specified.
This is because RTE_MAX_LCORE is not set. We also need to set
RTE_MAX_NUMA_NODES in armv7 native builds.
Fixes: 8ef09fdc506b ("build: add optional NUMA and CPU counts detection")
Signed-off-by: Juraj Linkeš <juraj.linkes@pantheon.tech>
---
config/arm/meson.build | 2 ++
1 file changed, 2 insertions(+)
diff --git a/config/arm/meson.build b/config/arm/meson.build
index 213324d262..57980661b2 100644
--- a/config/arm/meson.build
+++ b/config/arm/meson.build
@@ -432,6 +432,8 @@ if dpdk_conf.get('RTE_ARCH_32')
else
# armv7 build
dpdk_conf.set('RTE_ARCH_ARMv7', true)
+ dpdk_conf.set('RTE_MAX_LCORE', 128)
+ dpdk_conf.set('RTE_MAX_NUMA_NODES', 8)
# the minimum architecture supported, armv7-a, needs the following,
machine_args += '-mfpu=neon'
endif
--
2.20.1
^ permalink raw reply [flat|nested] 5+ messages in thread* RE: [PATCH v1] config/arm: add armv7 native config
2021-11-18 10:45 [PATCH v1] config/arm: add armv7 native config Juraj Linkeš
@ 2021-12-31 7:11 ` Ruifeng Wang
2021-12-31 17:23 ` Stephen Hemminger
2022-01-25 10:08 ` [PATCH v2] " Juraj Linkeš
2 siblings, 0 replies; 5+ messages in thread
From: Ruifeng Wang @ 2021-12-31 7:11 UTC (permalink / raw)
To: Juraj Linkeš,
thomas, david.marchand, bruce.richardson, Honnappa Nagarahalli,
ferruh.yigit, christian.ehrhardt
Cc: dev, nd
> -----Original Message-----
> From: Juraj Linkeš <juraj.linkes@pantheon.tech>
> Sent: Thursday, November 18, 2021 6:46 PM
> To: thomas@monjalon.net; david.marchand@redhat.com;
> bruce.richardson@intel.com; Honnappa Nagarahalli
> <Honnappa.Nagarahalli@arm.com>; Ruifeng Wang
> <Ruifeng.Wang@arm.com>; ferruh.yigit@intel.com;
> christian.ehrhardt@canonical.com
> Cc: dev@dpdk.org; Juraj Linkeš <juraj.linkes@pantheon.tech>
> Subject: [PATCH v1] config/arm: add armv7 native config
>
> Arvm7 native build fails with this error:
Typo, 'Armv7'
> ../config/meson.build:364:1: ERROR: Problem encountered:
> Number of CPU cores not specified.
>
> This is because RTE_MAX_LCORE is not set. We also need to set
> RTE_MAX_NUMA_NODES in armv7 native builds.
>
> Fixes: 8ef09fdc506b ("build: add optional NUMA and CPU counts detection")
>
> Signed-off-by: Juraj Linkeš <juraj.linkes@pantheon.tech>
> ---
> config/arm/meson.build | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/config/arm/meson.build b/config/arm/meson.build index
> 213324d262..57980661b2 100644
> --- a/config/arm/meson.build
> +++ b/config/arm/meson.build
> @@ -432,6 +432,8 @@ if dpdk_conf.get('RTE_ARCH_32')
> else
> # armv7 build
> dpdk_conf.set('RTE_ARCH_ARMv7', true)
> + dpdk_conf.set('RTE_MAX_LCORE', 128)
> + dpdk_conf.set('RTE_MAX_NUMA_NODES', 8)
> # the minimum architecture supported, armv7-a, needs the following,
> machine_args += '-mfpu=neon'
> endif
> --
> 2.20.1
Acked-by: Ruifeng Wang <ruifeng.wang@arm.com>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH v1] config/arm: add armv7 native config
2021-11-18 10:45 [PATCH v1] config/arm: add armv7 native config Juraj Linkeš
2021-12-31 7:11 ` Ruifeng Wang
@ 2021-12-31 17:23 ` Stephen Hemminger
2022-01-25 10:08 ` [PATCH v2] " Juraj Linkeš
2 siblings, 0 replies; 5+ messages in thread
From: Stephen Hemminger @ 2021-12-31 17:23 UTC (permalink / raw)
To: Juraj Linkeš
Cc: thomas, david.marchand, bruce.richardson, Honnappa.Nagarahalli,
Ruifeng.Wang, ferruh.yigit, christian.ehrhardt, dev
On Thu, 18 Nov 2021 11:45:51 +0100
Juraj Linkeš <juraj.linkes@pantheon.tech> wrote:
> Arvm7 native build fails with this error:
> ../config/meson.build:364:1: ERROR: Problem encountered:
> Number of CPU cores not specified.
>
> This is because RTE_MAX_LCORE is not set. We also need to set
> RTE_MAX_NUMA_NODES in armv7 native builds.
>
> Fixes: 8ef09fdc506b ("build: add optional NUMA and CPU counts detection")
>
> Signed-off-by: Juraj Linkeš <juraj.linkes@pantheon.tech>
> ---
> config/arm/meson.build | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/config/arm/meson.build b/config/arm/meson.build
> index 213324d262..57980661b2 100644
> --- a/config/arm/meson.build
> +++ b/config/arm/meson.build
> @@ -432,6 +432,8 @@ if dpdk_conf.get('RTE_ARCH_32')
> else
> # armv7 build
> dpdk_conf.set('RTE_ARCH_ARMv7', true)
> + dpdk_conf.set('RTE_MAX_LCORE', 128)
> + dpdk_conf.set('RTE_MAX_NUMA_NODES', 8)
In DPDK 19.11 the ARMv7 config says armv7 does not support NUMA.
Pleas set NUMA_NODES to 1
^ permalink raw reply [flat|nested] 5+ messages in thread* [PATCH v2] config/arm: add armv7 native config
2021-11-18 10:45 [PATCH v1] config/arm: add armv7 native config Juraj Linkeš
2021-12-31 7:11 ` Ruifeng Wang
2021-12-31 17:23 ` Stephen Hemminger
@ 2022-01-25 10:08 ` Juraj Linkeš
2022-02-10 16:34 ` Thomas Monjalon
2 siblings, 1 reply; 5+ messages in thread
From: Juraj Linkeš @ 2022-01-25 10:08 UTC (permalink / raw)
To: thomas, david.marchand, bruce.richardson, Honnappa.Nagarahalli,
Ruifeng.Wang, ferruh.yigit, christian.ehrhardt, stephen
Cc: dev, Juraj Linkeš
Armv7 native build fails with this error:
../config/meson.build:364:1: ERROR: Problem encountered:
Number of CPU cores not specified.
This is because RTE_MAX_LCORE is not set. We also need to set
RTE_MAX_NUMA_NODES in armv7 native builds.
Fixes: 8ef09fdc506b ("build: add optional NUMA and CPU counts detection")
Signed-off-by: Juraj Linkeš <juraj.linkes@pantheon.tech>
Acked-by: Ruifeng Wang <ruifeng.wang@arm.com>
---
config/arm/meson.build | 2 ++
1 file changed, 2 insertions(+)
diff --git a/config/arm/meson.build b/config/arm/meson.build
index c3a3f2faaf..a0e91c0f6b 100644
--- a/config/arm/meson.build
+++ b/config/arm/meson.build
@@ -434,6 +434,8 @@ if dpdk_conf.get('RTE_ARCH_32')
# armv7 build
dpdk_conf.set('RTE_ARCH_ARMv7', true)
dpdk_conf.set('RTE_ARCH', 'armv7')
+ dpdk_conf.set('RTE_MAX_LCORE', 128)
+ dpdk_conf.set('RTE_MAX_NUMA_NODES', 1)
# the minimum architecture supported, armv7-a, needs the following,
machine_args += '-mfpu=neon'
endif
--
2.20.1
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH v2] config/arm: add armv7 native config
2022-01-25 10:08 ` [PATCH v2] " Juraj Linkeš
@ 2022-02-10 16:34 ` Thomas Monjalon
0 siblings, 0 replies; 5+ messages in thread
From: Thomas Monjalon @ 2022-02-10 16:34 UTC (permalink / raw)
To: Honnappa.Nagarahalli, Juraj Linkeš
Cc: david.marchand, bruce.richardson, Ruifeng.Wang, ferruh.yigit,
christian.ehrhardt, stephen, dev
25/01/2022 11:08, Juraj Linkeš:
> Armv7 native build fails with this error:
> ../config/meson.build:364:1: ERROR: Problem encountered:
> Number of CPU cores not specified.
>
> This is because RTE_MAX_LCORE is not set. We also need to set
> RTE_MAX_NUMA_NODES in armv7 native builds.
>
> Fixes: 8ef09fdc506b ("build: add optional NUMA and CPU counts detection")
>
> Signed-off-by: Juraj Linkeš <juraj.linkes@pantheon.tech>
> Acked-by: Ruifeng Wang <ruifeng.wang@arm.com>
Applied with backport tag, thanks.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-02-10 16:35 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-18 10:45 [PATCH v1] config/arm: add armv7 native config Juraj Linkeš
2021-12-31 7:11 ` Ruifeng Wang
2021-12-31 17:23 ` Stephen Hemminger
2022-01-25 10:08 ` [PATCH v2] " Juraj Linkeš
2022-02-10 16:34 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).