From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f54.google.com (mail-wm0-f54.google.com [74.125.82.54]) by dpdk.org (Postfix) with ESMTP id 0E0375958 for ; Tue, 24 Nov 2015 16:30:31 +0100 (CET) Received: by wmvv187 with SMTP id v187so215099270wmv.1 for ; Tue, 24 Nov 2015 07:30:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding :content-type; bh=AGGGLXLr3k/F1a2hU3Y9Pa8w7XTZYH3rd43QCxGB77c=; b=vm2anPae8WXOLDH76uyEo+qcXpTmZv7AK8iYcEDin6mwkj6n5QseJL3XD3cODvd/H2 s/c3wUzesCZ+u565sspTiNCxHe5Gs87jQEI/3VhSRqyiA7XkUD+MJsqxSayzDgW97q/N XOfzRW8kGMpddstAOHTjgRmw5v6uW78Yom++/4A4Z1WU9x5xmwkW1t0QLdhTuHVFvJXn lYSLxwF01sExF5bbpW/bo+j5oed8I77hZAMv29sPlX4k+lyhHCv7sWcHChZv0aRSCFX9 WKKWMC/szVZoPLkpivzcjvNMoQ2Q6uJNIjOdJoXZcLhwbjPA2xS/nuhhDKxBp4Sva3ld YUWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=AGGGLXLr3k/F1a2hU3Y9Pa8w7XTZYH3rd43QCxGB77c=; b=kX/Ly17TfbsQkNfHZXCdAGkgEvy1MnlSYU0ky+gsVa5LCucgGZPQn2sYMpW6Wp4au5 N+tcKM2Qqmnh/HnueRpGg+QeqzbG6EIiWZBZ91QLtEupxDeYSqvwGe8/ZCMT+JFE7tpJ 09bAohNq5D28A5YGeI4WXcBbuXul0lagl0OkA1Y9dpOidGRqz6fdfRAwyqFFIerQD5+V rL3UoEE8HCB2Czu8DQNjGedSHs+kkhSJjs4se0bWG+bHDvyo7LvtxXYZ3MjIbuoCE+m8 UyMY5L0gtpeZhHPFTkffTXs1dpfARRXiOiE9Io6u+Ug70tCc8IV9OENSZTiMUucoQM2P tBnQ== X-Gm-Message-State: ALoCoQnl597TjbzUTmNTIwjHa9hDNRbWeDYBKngPJgus+ZS0dTL7a/mO3rcFg1TGqTDYrrhRYAty X-Received: by 10.28.14.209 with SMTP id 200mr24347749wmo.103.1448379030871; Tue, 24 Nov 2015 07:30:30 -0800 (PST) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by smtp.gmail.com with ESMTPSA id u4sm18705535wjz.4.2015.11.24.07.30.29 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 24 Nov 2015 07:30:30 -0800 (PST) From: Thomas Monjalon To: Bruce Richardson , Stephen Hemminger Date: Tue, 24 Nov 2015 16:29:12 +0100 Message-ID: <2448231.qRa78uBjDE@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <20151124145630.GA19796@bricha3-MOBL3> References: <1446552059-5446-1-git-send-email-bruce.richardson@intel.com> <20151117075309.7f05dc3a@samsung9> <20151124145630.GA19796@bricha3-MOBL3> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v4 2/2] ethdev: add sanity checks to functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Nov 2015 15:30:31 -0000 2015-11-24 14:56, Bruce Richardson: > On Tue, Nov 17, 2015 at 07:53:09AM -0800, Stephen Hemminger wrote: > > On Tue, 17 Nov 2015 12:21:07 +0000 > > Bruce Richardson wrote: > > > -static inline uint32_t > > > +static inline int Are we talking about this change only? Or the move in the first patch from .c to .h? [...] > > This breaks ABI since older application built with debug will try > > and find the shared library entry for the routine. > > Ok, so assuming we care about the ABI for debug builds, The return type is not only for debug build? > is it enough to just push a patch with a deprecation notice for this for 2.2, The ABI is already broken for ethdev in 2.2. So the symbol move should not hurt more. And the API change (return type) should not be a big deal, but at least an API change notification is required in the release notes. Other opinion? > or do I need to see about doing a new patchset with the NEXT_ABI macros > included in it? My preference is obviously for the former. No NEXT_ABI is required when ABI is already broken IMHO.