* [dpdk-dev] [PATCH v3] usertools: replace unsafe input function [not found] <11554730848-97709-1-git-send-email-andrius.sirvys@intel.com> @ 2019-04-08 13:54 ` Andrius Sirvys 2019-04-08 13:54 ` Andrius Sirvys 2019-07-30 22:10 ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon 0 siblings, 2 replies; 3+ messages in thread From: Andrius Sirvys @ 2019-04-08 13:54 UTC (permalink / raw) To: dev; +Cc: kevin.laatz, stable, Andrius Sirvys, ciara.power LGTM static code analysis tool reports that the function 'input' is unsafe. Changed to use raw_input which then converts it using ast.literal_eval() which is safe. Fixes: d1b94da4a4e0 ("usertools: add client script for telemetry") Cc: ciara.power@intel.com Signed-off-by: Andrius Sirvys <andrius.sirvys@intel.com> Acked-by: Kevin Laatz <kevin.laatz@intel.com> --- v3: Included omitted code --- usertools/dpdk-telemetry-client.py | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/usertools/dpdk-telemetry-client.py b/usertools/dpdk-telemetry-client.py index ce0c7a9..17b4daa 100755 --- a/usertools/dpdk-telemetry-client.py +++ b/usertools/dpdk-telemetry-client.py @@ -14,6 +14,11 @@ API_UNREG = "{\"action\":2,\"command\":\"clients\",\"data\":{\"client_path\":\"" DEFAULT_FP = "/var/run/dpdk/default_client" +try: + raw_input # Python 2 +except NameError: + raw_input = input # Python 3 + class Socket: def __init__(self): @@ -72,7 +77,7 @@ def requestMetrics(self): # Requests metrics for given client def repeatedlyRequestMetrics(self, sleep_time): # Recursively requests metrics for given client print("\nPlease enter the number of times you'd like to continuously request Metrics:") - n_requests = int(input("\n:")) + n_requests = int(ast.literal_eval(raw_input("\n:"))) print("\033[F") #Removes the user input from screen, cleans it up print("\033[K") for i in range(n_requests): @@ -87,7 +92,7 @@ def interactiveMenu(self, sleep_time): # Creates Interactive menu within the scr print("[3] Unregister client") try: - self.choice = int(input("\n:")) + self.choice = int(ast.literal_eval(raw_input("\n:"))) print("\033[F") #Removes the user input for screen, cleans it up print("\033[K") if self.choice == 1: -- 2.7.4 ^ permalink raw reply [flat|nested] 3+ messages in thread
* [dpdk-dev] [PATCH v3] usertools: replace unsafe input function 2019-04-08 13:54 ` [dpdk-dev] [PATCH v3] usertools: replace unsafe input function Andrius Sirvys @ 2019-04-08 13:54 ` Andrius Sirvys 2019-07-30 22:10 ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon 1 sibling, 0 replies; 3+ messages in thread From: Andrius Sirvys @ 2019-04-08 13:54 UTC (permalink / raw) To: dev; +Cc: kevin.laatz, stable, Andrius Sirvys, ciara.power LGTM static code analysis tool reports that the function 'input' is unsafe. Changed to use raw_input which then converts it using ast.literal_eval() which is safe. Fixes: d1b94da4a4e0 ("usertools: add client script for telemetry") Cc: ciara.power@intel.com Signed-off-by: Andrius Sirvys <andrius.sirvys@intel.com> Acked-by: Kevin Laatz <kevin.laatz@intel.com> --- v3: Included omitted code --- usertools/dpdk-telemetry-client.py | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/usertools/dpdk-telemetry-client.py b/usertools/dpdk-telemetry-client.py index ce0c7a9..17b4daa 100755 --- a/usertools/dpdk-telemetry-client.py +++ b/usertools/dpdk-telemetry-client.py @@ -14,6 +14,11 @@ API_UNREG = "{\"action\":2,\"command\":\"clients\",\"data\":{\"client_path\":\"" DEFAULT_FP = "/var/run/dpdk/default_client" +try: + raw_input # Python 2 +except NameError: + raw_input = input # Python 3 + class Socket: def __init__(self): @@ -72,7 +77,7 @@ def requestMetrics(self): # Requests metrics for given client def repeatedlyRequestMetrics(self, sleep_time): # Recursively requests metrics for given client print("\nPlease enter the number of times you'd like to continuously request Metrics:") - n_requests = int(input("\n:")) + n_requests = int(ast.literal_eval(raw_input("\n:"))) print("\033[F") #Removes the user input from screen, cleans it up print("\033[K") for i in range(n_requests): @@ -87,7 +92,7 @@ def interactiveMenu(self, sleep_time): # Creates Interactive menu within the scr print("[3] Unregister client") try: - self.choice = int(input("\n:")) + self.choice = int(ast.literal_eval(raw_input("\n:"))) print("\033[F") #Removes the user input for screen, cleans it up print("\033[K") if self.choice == 1: -- 2.7.4 ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [dpdk-stable] [PATCH v3] usertools: replace unsafe input function 2019-04-08 13:54 ` [dpdk-dev] [PATCH v3] usertools: replace unsafe input function Andrius Sirvys 2019-04-08 13:54 ` Andrius Sirvys @ 2019-07-30 22:10 ` Thomas Monjalon 1 sibling, 0 replies; 3+ messages in thread From: Thomas Monjalon @ 2019-07-30 22:10 UTC (permalink / raw) To: Andrius Sirvys; +Cc: stable, dev, kevin.laatz, ciara.power 08/04/2019 15:54, Andrius Sirvys: > LGTM static code analysis tool reports that the function 'input' is > unsafe. Changed to use raw_input which then converts it using > ast.literal_eval() which is safe. > > Fixes: d1b94da4a4e0 ("usertools: add client script for telemetry") > Cc: ciara.power@intel.com > > Signed-off-by: Andrius Sirvys <andrius.sirvys@intel.com> > Acked-by: Kevin Laatz <kevin.laatz@intel.com> This patch was forgotten. Applied, thanks ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-07-30 22:10 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <11554730848-97709-1-git-send-email-andrius.sirvys@intel.com>
2019-04-08 13:54 ` [dpdk-dev] [PATCH v3] usertools: replace unsafe input function Andrius Sirvys
2019-04-08 13:54 ` Andrius Sirvys
2019-07-30 22:10 ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).