DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ferruh Yigit <ferruh.yigit@intel.com>
To: "Zhang, RobinX" <robinx.zhang@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "Xing, Beilei" <beilei.xing@intel.com>,
	"Wu, Jingjing" <jingjing.wu@intel.com>,
	"Yang, Qiming" <qiming.yang@intel.com>,
	"Yang, SteveX" <stevex.yang@intel.com>
Subject: Re: [dpdk-dev] [PATCH 8/8] net/iavf: support check DD bit of a RX descriptor
Date: Mon, 12 Oct 2020 09:32:45 +0100
Message-ID: <2454df16-d14c-be2d-7a71-ddafdb5acd1f@intel.com> (raw)
In-Reply-To: <fe7a8f1f1a1f45908c4094ccfc6b547d@intel.com>

On 10/10/2020 2:49 AM, Zhang, RobinX wrote:
> Hi Ferruh
> 
>> -----Original Message-----
>> From: Ferruh Yigit <ferruh.yigit@intel.com>
>> Sent: Thursday, October 8, 2020 11:06 PM
>> To: Zhang, RobinX <robinx.zhang@intel.com>; dev@dpdk.org
>> Cc: Xing, Beilei <beilei.xing@intel.com>; Wu, Jingjing
>> <jingjing.wu@intel.com>; Yang, Qiming <qiming.yang@intel.com>; Yang,
>> SteveX <stevex.yang@intel.com>
>> Subject: Re: [dpdk-dev] [PATCH 8/8] net/iavf: support check DD bit of a RX
>> descriptor
>>
>> On 9/27/2020 8:26 AM, Robin Zhang wrote:
>>> Add implementation of inline API rx_descriptor_done in iavf PMD.
>>>
>>> Signed-off-by: Robin Zhang <robinx.zhang@intel.com>
>>> ---
>>>    drivers/net/iavf/iavf_ethdev.c |  1 +
>>>    drivers/net/iavf/iavf_rxtx.c   | 26 ++++++++++++++++++++++++++
>>>    drivers/net/iavf/iavf_rxtx.h   |  1 +
>>>    3 files changed, 28 insertions(+)
>>>
>>> diff --git a/drivers/net/iavf/iavf_ethdev.c
>>> b/drivers/net/iavf/iavf_ethdev.c index 836c09f58..b7a819a0e 100644
>>> --- a/drivers/net/iavf/iavf_ethdev.c
>>> +++ b/drivers/net/iavf/iavf_ethdev.c
>>> @@ -1417,6 +1417,7 @@ iavf_dev_init(struct rte_eth_dev *eth_dev)
>>>    	/* assign ops func pointer */
>>>    	eth_dev->dev_ops = &iavf_eth_dev_ops;
>>>    	eth_dev->rx_queue_count = iavf_dev_rxq_count;
>>> +	eth_dev->rx_descriptor_done = iavf_dev_rx_desc_done;
>>>    	eth_dev->rx_descriptor_status = iavf_dev_rx_desc_status;
>>>    	eth_dev->tx_descriptor_status = iavf_dev_tx_desc_status;
>>
>> Hi Robin,
>>
>> 'rx_descriptor_done' dev_ops is deprecated, 'rx_descriptor_status' should
>> provide same information?
>>
>> Is there a specific reason/need to implement 'rx_descriptor_done'? If not I
>> will drop this patch.
> 
> The purpose of this patch is keep same behavior between i40evf and iavf.
> 
> Refer to i40evf commit cbfc6111b5 in dpdk-next-net-intel, 'rx_descriptor_done' is moved to 'struct rte_eth_dev'.
> 

I see, but for i40evf, the 'rx_descriptor_done' was already there and it will be 
removed in 21.11.

I think no need to add a deprecated feature. 'rte_eth_rx_descriptor_status' 
replaces it and it is already implemented in iavf.

  parent reply	other threads:[~2020-10-12  8:32 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-27  7:26 [dpdk-dev] [PATCH 0/8] feature porting from i40evf to iavf Robin Zhang
2020-09-27  7:26 ` [dpdk-dev] [PATCH 1/8] net/iavf: use link status helper functions Robin Zhang
2020-09-27  7:26 ` [dpdk-dev] [PATCH 2/8] net/iavf: set min and max MTU for VF Robin Zhang
2020-09-27  7:26 ` [dpdk-dev] [PATCH 3/8] net/iavf: re-program promiscuous mode on VF interface Robin Zhang
2020-09-27  7:26 ` [dpdk-dev] [PATCH 4/8] net/iavf: optimize promiscuous ops Robin Zhang
2020-09-27  7:26 ` [dpdk-dev] [PATCH 5/8] net/iavf: add workaround promiscuous disable Robin Zhang
2020-09-27  7:26 ` [dpdk-dev] [PATCH 6/8] net/iavf: cleanup Tx buffers Robin Zhang
2020-09-27  7:26 ` [dpdk-dev] [PATCH 7/8] net/iavf: add extended stats Robin Zhang
2020-09-27  7:26 ` [dpdk-dev] [PATCH 8/8] net/iavf: support check DD bit of a RX descriptor Robin Zhang
2020-10-08 15:05   ` Ferruh Yigit
     [not found]     ` <fe7a8f1f1a1f45908c4094ccfc6b547d@intel.com>
2020-10-12  8:32       ` Ferruh Yigit [this message]
2020-10-13  5:58         ` Zhang, Qi Z
2020-10-08 12:23 ` [dpdk-dev] [PATCH 0/8] feature porting from i40evf to iavf Zhang, Qi Z

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2454df16-d14c-be2d-7a71-ddafdb5acd1f@intel.com \
    --to=ferruh.yigit@intel.com \
    --cc=beilei.xing@intel.com \
    --cc=dev@dpdk.org \
    --cc=jingjing.wu@intel.com \
    --cc=qiming.yang@intel.com \
    --cc=robinx.zhang@intel.com \
    --cc=stevex.yang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git