From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9FB9EA04B6; Mon, 12 Oct 2020 10:32:55 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 80E291D67B; Mon, 12 Oct 2020 10:32:54 +0200 (CEST) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 9B9C51D66D for ; Mon, 12 Oct 2020 10:32:52 +0200 (CEST) IronPort-SDR: QSvlJQweXxVxnEbLVAlDZoHbXehAF2WsXwuiXi10ZeFGrCjmDOja7V5jnAh3ELobRyFrkVlHve FpLV9O/Y3wzA== X-IronPort-AV: E=McAfee;i="6000,8403,9771"; a="227353393" X-IronPort-AV: E=Sophos;i="5.77,366,1596524400"; d="scan'208";a="227353393" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Oct 2020 01:32:50 -0700 IronPort-SDR: 3t5uHtUPd5nqoXHZG4SFGKRRE8sMNNk9wBkd7gNrVhS0DJCijlegOTjRoD9jgPhMNIyiyKFk1W TMOYeCBudQ5A== X-IronPort-AV: E=Sophos;i="5.77,366,1596524400"; d="scan'208";a="520615042" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.244.119]) ([10.213.244.119]) by fmsmga005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Oct 2020 01:32:49 -0700 To: "Zhang, RobinX" , "dev@dpdk.org" Cc: "Xing, Beilei" , "Wu, Jingjing" , "Yang, Qiming" , "Yang, SteveX" References: <20200927072626.28374-1-robinx.zhang@intel.com> <20200927072626.28374-9-robinx.zhang@intel.com> <189b10b8-b58c-9fed-b5c4-f8b6acfa3a85@intel.com> From: Ferruh Yigit Message-ID: <2454df16-d14c-be2d-7a71-ddafdb5acd1f@intel.com> Date: Mon, 12 Oct 2020 09:32:45 +0100 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH 8/8] net/iavf: support check DD bit of a RX descriptor X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/10/2020 2:49 AM, Zhang, RobinX wrote: > Hi Ferruh > >> -----Original Message----- >> From: Ferruh Yigit >> Sent: Thursday, October 8, 2020 11:06 PM >> To: Zhang, RobinX ; dev@dpdk.org >> Cc: Xing, Beilei ; Wu, Jingjing >> ; Yang, Qiming ; Yang, >> SteveX >> Subject: Re: [dpdk-dev] [PATCH 8/8] net/iavf: support check DD bit of a RX >> descriptor >> >> On 9/27/2020 8:26 AM, Robin Zhang wrote: >>> Add implementation of inline API rx_descriptor_done in iavf PMD. >>> >>> Signed-off-by: Robin Zhang >>> --- >>> drivers/net/iavf/iavf_ethdev.c | 1 + >>> drivers/net/iavf/iavf_rxtx.c | 26 ++++++++++++++++++++++++++ >>> drivers/net/iavf/iavf_rxtx.h | 1 + >>> 3 files changed, 28 insertions(+) >>> >>> diff --git a/drivers/net/iavf/iavf_ethdev.c >>> b/drivers/net/iavf/iavf_ethdev.c index 836c09f58..b7a819a0e 100644 >>> --- a/drivers/net/iavf/iavf_ethdev.c >>> +++ b/drivers/net/iavf/iavf_ethdev.c >>> @@ -1417,6 +1417,7 @@ iavf_dev_init(struct rte_eth_dev *eth_dev) >>> /* assign ops func pointer */ >>> eth_dev->dev_ops = &iavf_eth_dev_ops; >>> eth_dev->rx_queue_count = iavf_dev_rxq_count; >>> + eth_dev->rx_descriptor_done = iavf_dev_rx_desc_done; >>> eth_dev->rx_descriptor_status = iavf_dev_rx_desc_status; >>> eth_dev->tx_descriptor_status = iavf_dev_tx_desc_status; >> >> Hi Robin, >> >> 'rx_descriptor_done' dev_ops is deprecated, 'rx_descriptor_status' should >> provide same information? >> >> Is there a specific reason/need to implement 'rx_descriptor_done'? If not I >> will drop this patch. > > The purpose of this patch is keep same behavior between i40evf and iavf. > > Refer to i40evf commit cbfc6111b5 in dpdk-next-net-intel, 'rx_descriptor_done' is moved to 'struct rte_eth_dev'. > I see, but for i40evf, the 'rx_descriptor_done' was already there and it will be removed in 21.11. I think no need to add a deprecated feature. 'rte_eth_rx_descriptor_status' replaces it and it is already implemented in iavf.