From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 65AE21B799 for ; Thu, 10 May 2018 00:50:40 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 04AEE213C4; Wed, 9 May 2018 18:50:40 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Wed, 09 May 2018 18:50:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=UrFKK2TOGxpOXORPXqbeyNDQEA Sq+3ODOtcL3iZ3daQ=; b=glMoyIVPpo7KM0sDnMGqfLg6i51AaWRpDamW1sLShx /9wujbFICU43F6PuDl7eJm7AKgeKaCqMUMKIpBs1Mxj4SLJZFY4vWwqQLbJwJlJo O4qiudlQacmbtXbPQeb8xuFEaOZSvvN/X8rzXsv7TcJvDx8acqz5w2TTooEBXJJx A= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=UrFKK2 TOGxpOXORPXqbeyNDQEASq+3ODOtcL3iZ3daQ=; b=kKhvmWRYGBiONev3GfrPVU nK3oAOIMStGuQu4TnA8FZ3vTlfCAbUtwVPzhHEOQwNkKYYgG97mh6eYM2dwUuscj hmmWDAkXQMLXxGXSCrv66zM1cLJrgS+7/advhpcHQ+/FV8N3A2edhijxCDiLY8Lr 1cc94excYjc4Ofx+MbBZZQLI72HA8JDAoYMvmppP0RqwbVxl9+nPmDnh/uk5XQc5 O9jYemc2ikAeag9/9pPihBpPr67JO1zfiJ8kL0/Q7Y+X9YLLEr5LCDXlbCk0AHND NKSy6IXNPqLM8JGIXLVpWLHuY1cE72i7BO6MxfO5v/iNtcwRK5i6ph3J5AqxN/TA == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 4997FE43E8; Wed, 9 May 2018 18:50:39 -0400 (EDT) From: Thomas Monjalon To: Ferruh Yigit Cc: dev@dpdk.org, remy.horton@intel.com Date: Thu, 10 May 2018 00:50:37 +0200 Message-ID: <2455076.tMWrylkWj2@xps> In-Reply-To: <20180509221649.129690-1-ferruh.yigit@intel.com> References: <20180509221649.129690-1-ferruh.yigit@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] ethdev: fix corrupted device info in configure X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 May 2018 22:50:40 -0000 10/05/2018 00:16, Ferruh Yigit: > Calling dev_infos_get() devops directly in rte_eth_dev_configure cause > random values in uninitialized fields because devops doesn't reset the > dev_info structure. > > Call rte_eth_dev_info_get() API instead which memset the struct. > > Also remove duplicated dev_infos_get existence check. > > Fixes: 3be82f5cc5e3 ("ethdev: support PMD-tuned Tx/Rx parameters") > Cc: remy.horton@intel.com > > Signed-off-by: Ferruh Yigit Acked-by: Thomas Monjalon