From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A39BCA0C52; Sun, 7 Nov 2021 17:19:08 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5F7BA40151; Sun, 7 Nov 2021 17:19:08 +0100 (CET) Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by mails.dpdk.org (Postfix) with ESMTP id 35CD140040 for ; Sun, 7 Nov 2021 17:19:07 +0100 (CET) Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 9CC1E5C0124; Sun, 7 Nov 2021 11:19:06 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Sun, 07 Nov 2021 11:19:06 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= 8HC7x188yCcE6psTsTCqhScaov6+bzYSASbL8ZF6oP8=; b=sM9mP2jipy/XF92S S5PBFs2SnGXxSCipoXwnGXZsnFQuZWnli/c7yoNibfxG5Vxf4nvCIW52AByA0fy3 Ju8jmptd5m2OW+k9unOAouCPLDPnlV1VgfLs0x9UgiBb/px/3v3HgnjNclubCrff 1HqKSMJsKb/GbkUQqpbSptMKIls66lA0MqFs7X1xwrLXuCelZgy2nJeQkWWoPkuZ 1hKbh7iq1FgFn42akMdaF4kCHm8Li6myYx9Wx3vaJve3ZSFl36J9enFIJA9ZQ+eK nLGIFwrjDhG6nC82rEKSG8U1Rhjr2NoL4hB67I9tU8BnJzT+Hfa4WE/XvvwZOeOF h9OoJg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=8HC7x188yCcE6psTsTCqhScaov6+bzYSASbL8ZF6o P8=; b=gboJqZRvlygp5XksY91c4NBPgvvMltK72DRq6laiohujHVK5v0TvxfvzJ CJ/YgQ+U7Bee4QONYkQbLry1iUGZO3p4Zdu68myl49m2ti50fXirkCUuPMshO3eK 97KKH5nmnYhIpNA+kDgX0oGhvZsGg3tEJ8BSv1tvxh8nIGHkajrKtnwRCfbI0dhQ V9Q+RTMwvW3RkvxjOkYCAgWaZ4t3rgt8VVmEudOGd9vaag4sHjI1+O5mt66VhewU kiRTyN9TTa74ShRAfS2Jl9ehUS+l4NzJD1EpFbcP8sFHdgbnLN8B5Gpw6Q0E5VJn QzXK6E1u1uK7tu8YKQ2UcV9q4Wv5Q== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvuddruddtgdekhecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdejueei iedvffegheenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhroh hmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 7 Nov 2021 11:19:05 -0500 (EST) From: Thomas Monjalon To: David Marchand Cc: "dev@dpdk.org" , "bruce.richardson@intel.com" , "ferruh.yigit@intel.com" , Slava Ovsiienko , Gregory Etelson Date: Sun, 07 Nov 2021 17:19:03 +0100 Message-ID: <2455307.6Ec1XSgEAO@thomas> In-Reply-To: References: <20211105132951.13408-1-david.marchand@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] app: fix testpmd dependency on jansson X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Strictly speaking, the jansson dependency is already described, so the fix is more about fixing the linking in general. That's why I chose this title: "app: fix external dependency linking" > > ext_deps is not used in app/meson.build. > > testpmd currently can be linked because metrics > > library is pulling > > the dependency on libjansson. > > > > Fixes: 59f3a8acbcdb ("app/testpmd: add flex > > item commands") > > > > Signed-off-by: David Marchand [...] > > --- a/app/meson.build > > +++ b/app/meson.build > > - dependencies: dep_objs, > > + dependencies: ext_deps + dep_objs, > > Reviewed-by: Gregory Etelson Applied, thanks.