From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 17BBCA04DD; Tue, 20 Oct 2020 21:28:13 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id AD187AC83; Tue, 20 Oct 2020 21:28:11 +0200 (CEST) Received: from new2-smtp.messagingengine.com (new2-smtp.messagingengine.com [66.111.4.224]) by dpdk.org (Postfix) with ESMTP id 9BABAAC77 for ; Tue, 20 Oct 2020 21:28:09 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailnew.nyi.internal (Postfix) with ESMTP id 52BE0580218; Tue, 20 Oct 2020 15:28:07 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Tue, 20 Oct 2020 15:28:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= H4xsaJLDu0F1ArjQZRz3UApfK1YSmv1h2bQ62ukAQkU=; b=aFBEYZEOiMv5sMFs P7eTxy3K/4CWQP9PAfENKSiKb/hHHb8SEiOHuNqciLEnDOvi47/Chg01tAjojDjB jZ8M7IzL1ZCSDlFkjrV02BPyxt2Z/TqBjyknG8EmDQb0MFCYKzNfvUKw9LzrGVw7 +XHMjCoadfJJK6/EkTDu38+1q7UJiOQpr5S6vcrXLhst9w0oVcARjy5oi2WMy668 TdXLuFvN5oawb8+d0u+FY/rxHajVuoQ9M0JIcCC4KPbkrTDLwgBnUG+PGUlu+uim rcqPIF+ql0bvH35LOE3tzKS6Blc1rVo0IK/NpI7MxzDEGTni8lmMq5K9wZI27tr4 tMdCuA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=H4xsaJLDu0F1ArjQZRz3UApfK1YSmv1h2bQ62ukAQ kU=; b=TfPhHfPy3Oef4X8plvmzbCjxxv0ypmz4h2QIiGPPDDE+rTIIkON1n8iVL O8M5y4SBlMxhH+hED5c7KwSvJS7f0Ov8Ic3AQ3IUlq4wjg1HMUTU1J8IaWpa8W0C YDCAlk61IMuKIN1fajfr6xVbkAb3qXBqClYFW5Wk2KPvibol4Q9iHfosRKcUAFw6 2Tqe9UiPfGEkti9I3I4vYYuYXCBwlaMaxtL5n2x0PE0iTOau8o1CDvZ4GdiEs78V yweFmaa8oIxXPA+fMmmF3nziS6KnfaLR3EXyMGz5oNSqklI+oRZP1SZlfcSSC63h lyoazGUuIblL745XKnLY/D1TL2aEQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrjeefgddufeehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 90D6C3064688; Tue, 20 Oct 2020 15:28:03 -0400 (EDT) From: Thomas Monjalon To: "Hunt, David" , "Ananyev, Konstantin" Cc: Honnappa Nagarahalli , Ruifeng Wang , "dev@dpdk.org" , "Ma, Liang J" , Jan Viktorin , David Christensen , "Richardson, Bruce" , "jerinjacobk@gmail.com" , "McDaniel, Timothy" , "Eads, Gage" , "Macnamara, Chris" , "Burakov, Anatoly" , "david.marchand@redhat.com" , nd Date: Tue, 20 Oct 2020 21:28:01 +0200 Message-ID: <2456349.NhcWXA10Jn@thomas> In-Reply-To: References: <2249719.vHQDUtK1Li@thomas> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v7 02/10] eal: add power management intrinsics X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 20/10/2020 19:26, Ananyev, Konstantin: > > 20/10/2020 16:17, David Hunt: > > > On 20/10/2020 3:01 PM, David Hunt wrote: > > > > On 20/10/2020 8:35 AM, Thomas Monjalon wrote: > > > >> 20/10/2020 04:49, Ruifeng Wang: > > > >>> From: Thomas Monjalon > > > >>>> 15/10/2020 14:04, Anatoly Burakov: > > > >>>>> +/** > > > >>>>> + * This function is not supported on ARM. > > > >>>>> + */ > > > >>>>> +static inline void > > > >>>>> +rte_power_monitor(const volatile void *p, const uint64_t > > > >>>> expected_value, > > > >>>>> + const uint64_t value_mask, const uint64_t > > > >>>>> tsc_timestamp, > > > >>>>> + const uint8_t data_sz) { > > > >>>>> + RTE_SET_USED(p); > > > >>>>> + RTE_SET_USED(expected_value); > > > >>>>> + RTE_SET_USED(value_mask); > > > >>>>> + RTE_SET_USED(tsc_timestamp); > > > >>>>> + RTE_SET_USED(data_sz); > > > >>>>> +} > > > >>>> Are you sure it cannot be partially supported with WFE instruction? > > > >>>> > > > >>> Armv8 WFE instruction can support monitoring of specific address for > > > >>> changes, > > > >>> but not monitoring of TSC timestamp. > > > >> So it is a partial support. > > > >> > > > >> We must try hard to unify architectures support > > > >> to avoid #ifdef everywhere. > > > >> > > > >> I don't agree with how are managed new instructions recently. > > > >> Please look further. > > > >> > > > > > > > > Hi Thomas, > > > > > > > > We believe this is ready for -rc1, can we discuss this with the > > > > technical board before the RC1 tag is applied? > > > > > > > > > > Hi Thomas, > > > By way of further follow-up, here are the reasons why we believe > > > it's ready for merge. > > > > > > There are 18 Acks for the 10 patches, with the two critical patches > > > getting 4 acks each. > > > These acks are from ARM, Marvell, IBM and Intel. > > > There have been 7 revisions, with quite a lot of discussion, and all > > > comments have been addressed and Ack'd. > > > From what I can see, the community are in agreement that this patch > > > should be merged. > > > > The problem is that I don't agree, > > Thomas, could you explain about what exactly you don't agree with? > Is it about WFE? Something else? It's about -rc1. I will look at this patchset for -rc2. > > and I feel you tried to avoid comments from others at the beginning. > > > > Now I don't want to spend more time on it before tagging -rc1. > > > > Next time, you'll make sure to Cc and reply everybody.