From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f172.google.com (mail-wi0-f172.google.com [209.85.212.172]) by dpdk.org (Postfix) with ESMTP id CEF9A5A57 for ; Wed, 8 Jul 2015 23:53:24 +0200 (CEST) Received: by wibdq8 with SMTP id dq8so225199051wib.1 for ; Wed, 08 Jul 2015 14:53:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=EZzhXA9rCKotp/20okGg5QtfzKY1qhdwGjugJmA4OqY=; b=CRoKMTJ3CxYy0vfBf3vF6h+BTGB2+7IhiRnR3JXDBPPRfqZQr5k4qwqJrAusjXTJy1 wg0euLeOnKucEZETrDZ07hPt9b+QSh1AEo0Kt+ATTd3tIBeuDwDmtvXcRDLEijh1AY8z vcn330w32nAPD8O0a5bJ4g7EjsdWgUf2Gh/RrF3M3QzWIUwuYcq/xO/OzbG6tRWGaCyS T+rl3cBPCGdAcVsOgYTo1k1n4g01YPnTQVq80WUbA2wPbCu2kuURBweuJRAdwxr3nGYE DNFOoJTf/wqxDIEe+mORxUaj3oPMqdEhcBhZXZnzMMlTFT3h79uEwV3qD9GPQY1qGciZ 6ULg== X-Gm-Message-State: ALoCoQn5hmoOKSG7a4BlzD0MmSsBrr3cVobbOoPpEPQ35sn3afmfC5VfJXTPf+QAKqM2GfmVSauX X-Received: by 10.180.83.137 with SMTP id q9mr121589435wiy.68.1436392404659; Wed, 08 Jul 2015 14:53:24 -0700 (PDT) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by smtp.gmail.com with ESMTPSA id e2sm5475082wjw.12.2015.07.08.14.53.22 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 08 Jul 2015 14:53:23 -0700 (PDT) From: Thomas Monjalon To: dev@dpdk.org, Tetsuya Mukawa Date: Wed, 08 Jul 2015 23:52:18 +0200 Message-ID: <2456354.fItLHJVCy0@xps13> Organization: 6WIND User-Agent: KMail/4.14.8 (Linux/4.0.4-2-ARCH; KDE/4.14.8; x86_64; ; ) In-Reply-To: References: <1435652668-3380-12-git-send-email-mukawa@igel.co.jp> <1436351693-2349-1-git-send-email-mukawa@igel.co.jp> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v9 00/12] Clean up pci uio implementations X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Jul 2015 21:53:25 -0000 > > Currently Linux implementation and BSD implementation have almost same > > code about pci uio. This patch series cleans up it. > > > > PATCH v9 changes: > > - Add lost Acked-by and Tested-by signatures. > > - Remove NULL checkings before calling rte_free(). > > - Fix pci_uio_map_secondary() to remove needless close(). > > - Remove needless parameter checkings of pci_uio_alloc_resource() and > > pci_uio_map_resource_by_index(). > > - Remove needless error checking for return value of > > pci_uio_alloc_resource(). > > - Introduce pci_uio_free_resource(). > > - Remove some comments of pci_uio_map_resource(). > > (Thanks to David Marchand) > > > Acked-by: David Marchand Applied, thanks The copyright additions were removed because not appropriate in a cleanup.