From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 739D9A00B8; Mon, 28 Oct 2019 12:04:09 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id EE86B1BEF3; Mon, 28 Oct 2019 12:04:07 +0100 (CET) Received: from new1-smtp.messagingengine.com (new1-smtp.messagingengine.com [66.111.4.221]) by dpdk.org (Postfix) with ESMTP id 74E441BEEC for ; Mon, 28 Oct 2019 12:04:06 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailnew.nyi.internal (Postfix) with ESMTP id 3D0DB739B; Mon, 28 Oct 2019 07:04:05 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Mon, 28 Oct 2019 07:04:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=U0gBhYVH+e+QcSmGhxJy612OadmF2SRxA4vlUtgZzrg=; b=WlZwuycsuK8F koSP96TcG63GJcN/Y+vTGYV1iBLo5BxghLoHF1ff8JGZabQgZRkvJL/OqLo3rOrY +hoYc0MnH/73nyYxLb0Vc0izCusxlp175GczOapNmgsdBmkTOGes4ozA3+M7mr0h 3Vf9PFvRJ100Li+kuLmbycbgZnmCB+A= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=U0gBhYVH+e+QcSmGhxJy612OadmF2SRxA4vlUtgZz rg=; b=wE6G796NhY+qlLSSEig/XgVluXYdHCoutf1ZceLMzsbYE3zSSARNMLtx7 rukd3G5/orR2lprxiO0/vr3c0quB0k4V47fj0go4/Ng2+dBCvA/D452UTqAuhr0c ONMVBZQJLpm4ZFM5qp3m4uuRzfl3+SYDzn6r0CRUwNl+NBS0WQxZp+12QTf/8I+n ugV9rovIvCT9H2POee0BmWSlTHZu1g/5IgwIwqvhnG1K0uHcz+VIOfIsUI+WXoPW 9AKlroEPEBXe2Rqy+CwO0YzWsx+/wYtntVmedwdHWcoWA6zuEhNAebC09h3WCJhY /P7l4Hp08+0nPzX35XYVxna9ua3QA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedufedrleelgddvfecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph epjeejrddufeegrddvtdefrddukeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhho mhgrshesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 682B6D6005B; Mon, 28 Oct 2019 07:03:58 -0400 (EDT) From: Thomas Monjalon To: Andrzej Ostruszka Cc: dev@dpdk.org, Aaron Conole , Michael Santana , John McNamara , Marko Kovacevic , David Hunt , Bruce Richardson , Vladimir Medvedkin , Robert Sanford , Erik Gabriel Carrillo , mattias.ronnblom@ericsson.com, stephen@networkplumber.org Date: Mon, 28 Oct 2019 12:03:56 +0100 Message-ID: <2457474.78r5sKa67x@xps> In-Reply-To: <1bb37fbc-bf02-9485-fcb5-0c342ccee4f6@semihalf.com> References: <20190917075754.8310-1-amo@semihalf.com> <12578231.CQkhPFEoQU@xps> <1bb37fbc-bf02-9485-fcb5-0c342ccee4f6@semihalf.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v4 01/10] build: add an option to enable LTO build X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 28/10/2019 11:47, Andrzej Ostruszka: > On 10/27/19 12:47 PM, Thomas Monjalon wrote: > >> +turned on. This depends obviously on the capabilities of the compiler > > > > Not sure what you are talking about. > > If it is about fat objects, it is not obvious. > > > >> +to do "whole program" optimization at link time and is available only > > That was not a reference to some formally defined "capabilities" just an > "obvious" statement that in order to benefit from LTO one needs a > compiler "capable of" performing it. I will rephrase this paragraph as: > > -8<------------- > The DPDK supports compilation with link time optimization turned on. > This depends obviously on the ability of the compiler to do "whole > program" optimization at link time and is available only for compilers > that support that feature (gcc and icc). > To be more specific, compiler (in addition to performing LTO) have to > support creation of ELF objects containing both normal code and internal > representation (fat-lto-objects). This is required since during build > some code is generated by parsing produced ELF objects (pmdinfogen). > -8<------------- > > Will it suffice? If not, then please suggest wording to be used. There is a confusion here: "compilers that support that feature (gcc and icc)" In my understanding, clang supports LTO but is not mentioned because of the lack of fat object support. I think you should mention gcc and icc only after explaining the second constraint (fat objects). > >> +for compilers that support that feature (gcc and icc). To be more > > > > Please start a new sentence at the beginning of a line in the RsT file. > > It is easier to review and update. > > OK Please consider such comment to apply to the whole file :) [...] > OK. I'll send the next version today. > > Thank you again for the comments. Thank you