From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id D7073A04B1; Sun, 22 Nov 2020 15:15:32 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 378B86CC6; Sun, 22 Nov 2020 15:15:30 +0100 (CET) Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 542142AB for ; Sun, 22 Nov 2020 15:15:27 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id A210B5C0132; Sun, 22 Nov 2020 09:15:25 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Sun, 22 Nov 2020 09:15:25 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= NhL9W8SOCShZ52SzlRwRcbHd/6qD/Qi4hj0YbpmYq1Y=; b=YXIMudywYBuGDhQx YBsJZqWsKkpL18ataSXSVxOQlkmCQ2+SgYShCmPmtHPRrmD/gbnO+ycQtzu/OPbB K8213kRYi54w9qAOw9V9RXC22hM+CX+3hpX+/+M78pEoNgcDW23m0rFBiMyI4pT6 ZL/h2XgiDDeStHIaL+YxqPuZ4Ice4XphWKAGcQKuqv9m+vI98hOjbRerFOKn+lzr Rfbpssibo0mk6IS7FM4IUDE/w8up/Q6zUr/oBdkXvH92aDDXihHDFFpJtoRQrG4s YBhk7W1EJ9z3Rt1lGkKIo/JuJyaCKsQv0N9VIhZPUSGki/NZvglwsLw+FEHoS8CU 5orR0w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=NhL9W8SOCShZ52SzlRwRcbHd/6qD/Qi4hj0YbpmYq 1Y=; b=JsIuZSdpl6dUkPQiJpd9D/kzlFaipab5w6n7RBuS6oMxIS6fKW3ubqaoi /Wd48h3dZdvDe9+VQRw5LxC/65YaXS6RW2a0DUT5Jj0MuH2lVYY3oXEMbBkwyZnn 08Dy4WlCjM39/6uBADPoW/tN+MZxmnSvfsNKAyZkPBst9JCdZSt0IKjKuwvyTDlb YqdFiK7oBAgWa/JAh6qlfBH1C19BZD8JuamGcKS5H29CpvkDthraDArEVsOgh4GK V6OYXJFaKJD5Oh/AoEx+nCLrRCEZhS6DzgBuoHNobqw3RlU0b01/69yf2BSyXslA XlTau7NIOP6oXP1XEKUwSU2cpoAHQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrudeggedgieefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepffdvffejueetleefieeludduuefgteejleevfeekjeefieegheet ffdvkeefgedunecuffhomhgrihhnpeguphgukhdrohhrghenucfkphepjeejrddufeegrd dvtdefrddukeegnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhf rhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 00EDD3064AAA; Sun, 22 Nov 2020 09:15:23 -0500 (EST) From: Thomas Monjalon To: Ferruh Yigit , Xiaoyu Min , Jingjing Wu , Beilei Xing Cc: dev@dpdk.org, Andrew Rybchenko , Ori Kam , Dekel Peled Date: Sun, 22 Nov 2020 15:15:22 +0100 Message-ID: <2457523.IGjbyyMuxV@thomas> In-Reply-To: References: <8990f612-b3b1-bdbc-8da3-9a0e45d5c3bc@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH 4/5] net/iavf: fix protocol size for virtchnl copy X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 22/11/2020 14:28, Jack Min: > From: Ferruh Yigit > > On 11/16/2020 7:55 AM, Xiaoyu Min wrote: > > > From: Xiaoyu Min > > > > > > The rte_flow_item_vlan items are refined. > > > The structs do not exactly represent the packet bits captured on the > > > wire anymore so should only copy real header instead of the whole struct. > > > > > > Replace the rte_flow_item_* with the existing corresponding rte_*_hdr. > > > > > > Fixes: 09315fc83861 ("ethdev: add VLAN attributes to ethernet and VLAN > > items") > > > > > > Signed-off-by: Xiaoyu Min > > > --- > > > drivers/net/iavf/iavf_fdir.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/drivers/net/iavf/iavf_fdir.c b/drivers/net/iavf/iavf_fdir.c > > > index d683a468c1..7054bde0b9 100644 > > > --- a/drivers/net/iavf/iavf_fdir.c > > > +++ b/drivers/net/iavf/iavf_fdir.c > > > @@ -541,7 +541,7 @@ iavf_fdir_parse_pattern(__rte_unused struct > > iavf_adapter *ad, > > > VIRTCHNL_ADD_PROTO_HDR_FIELD_BIT(hdr, > > ETH, ETHERTYPE); > > > > > > rte_memcpy(hdr->buffer, > > > - eth_spec, sizeof(*eth_spec)); > > > + eth_spec, sizeof(struct rte_ether_hdr)); > > > > This requires 'struct rte_flow_item_eth' should have 'struct rte_ether_hdr' as > > first element, and I suspect this usage exists in a few more locations, but I > > wonder if this assumption is real and documented in somewhere? > > I am not just talking about 'struct rte_flow_item_eth', but for all > > 'rte_flow_item_*'... > > > I think this is not documented and this assumption is not real. > I've created one ticket on Bugzilla (https://bugs.dpdk.org/show_bug.cgi?id=581) to track. So it probably means this patch is not enough for iavf. It would require iavf maintainers (Cc'ed) to follow up. I will apply the rest of the series.