From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f177.google.com (mail-wi0-f177.google.com [209.85.212.177]) by dpdk.org (Postfix) with ESMTP id 58C187EB0 for ; Fri, 10 Apr 2015 09:56:38 +0200 (CEST) Received: by wiun10 with SMTP id n10so16710224wiu.1 for ; Fri, 10 Apr 2015 00:56:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=cB6ISqhuBUsZ+92y6Kp+LSgNXJfgOmxeFPgbzGcBzZE=; b=kXo5mTEA1v0igI4ZvKqSEX2zezJGSl5lNVKE/WUn5fDpuiuqr77lOGqe+T66jX5CeT woGUXKNiH7B8Jmo97Y86XREXVuwjGuB/1jDh5fSIT4Q+Iqz5YHrw5ABQzsdM6FUgH+E3 Xsm3l/TsmaxKd3MGM+aw5TCVYczWBXP7ddCwRDtCEHAeGeaWntzjqHs/uLJVC6ZbUR+X GgNvPbD/qqPmMkAqxqn1R+/5Do8Lcyuf2SA2Pe0KoiMaOAw1Dw5PY9azcXl1yMaiR3PR 1ZVD7UsI8sBTVUjeh/Fa7FtCi2aDZdy3caixHg4lunLk8buFfjpcI4YycxpIiYBJfp5I sLRw== X-Gm-Message-State: ALoCoQkS7jPlzybPpl97frx9csqPwJWERO/nCJlVVJaZGre10mnPaOL13QKEg02oGf1PiBZJEj4d X-Received: by 10.194.243.9 with SMTP id wu9mr599223wjc.107.1428652598272; Fri, 10 Apr 2015 00:56:38 -0700 (PDT) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id v3sm2221705wix.8.2015.04.10.00.56.37 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 10 Apr 2015 00:56:37 -0700 (PDT) From: Thomas Monjalon To: Eric Kinzie Date: Fri, 10 Apr 2015 09:55:56 +0200 Message-ID: <2459792.WhTEP7QfNa@xps13> Organization: 6WIND User-Agent: KMail/4.14.4 (Linux/3.18.4-1-ARCH; KDE/4.14.4; x86_64; ; ) In-Reply-To: <55278003.2090706@intel.com> References: <1428339685-27686-1-git-send-email-ehkinzie@gmail.com> <1428339685-27686-3-git-send-email-ehkinzie@gmail.com> <55278003.2090706@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH 2/5] bond mode 4: copy entire config structure X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Apr 2015 07:56:38 -0000 2015-04-10 09:47, Pawel Wodkowski: > On 2015-04-06 19:01, Eric Kinzie wrote: > > Copy all needed fields from the mode8023ad_private structure in > > bond_mode_8023ad_conf_get(). > > > > Signed-off-by: Eric Kinzie > > --- > > lib/librte_pmd_bond/rte_eth_bond_8023ad.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/lib/librte_pmd_bond/rte_eth_bond_8023ad.c b/lib/librte_pmd_bond/rte_eth_bond_8023ad.c > > index 97a828e..1009d5b 100644 > > --- a/lib/librte_pmd_bond/rte_eth_bond_8023ad.c > > +++ b/lib/librte_pmd_bond/rte_eth_bond_8023ad.c > > @@ -1013,6 +1013,7 @@ bond_mode_8023ad_conf_get(struct rte_eth_dev *dev, > > conf->aggregate_wait_timeout_ms = mode4->aggregate_wait_timeout / ms_ticks; > > conf->tx_period_ms = mode4->tx_period_timeout / ms_ticks; > > conf->update_timeout_ms = mode4->update_timeout_us / 1000; > > + conf->rx_marker_period_ms = mode4->rx_marker_timeout / ms_ticks; > > } > > > > void > > > > This is bugfix. When fixing a bug, it's better to explain what was wrong (i.e. behaviour impact) and to add a tag "Fixes: ". Thanks > Acked-by: Pawel Wodkowski