From: Thomas Monjalon <thomas@monjalon.net>
To: Jakub Palider <jpalider@marvell.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"david.marchand@redhat.com" <david.marchand@redhat.com>
Subject: Re: [EXT] Re: [PATCH] devtools: ensure proper tag sequence
Date: Mon, 13 Jun 2022 15:54:43 +0200 [thread overview]
Message-ID: <2460878.4XsnlVU6TS@thomas> (raw)
In-Reply-To: <PH0PR18MB4573F330E50E54649FD89337D5AB9@PH0PR18MB4573.namprd18.prod.outlook.com>
13/06/2022 12:35, Jakub Palider:
> > -----Original Message-----
> > From: Thomas Monjalon <thomas@monjalon.net>
> > Sent: Sunday, June 12, 2022 10:29 PM
> > To: Jakub Palider <jpalider@marvell.com>
> > Cc: dev@dpdk.org; david.marchand@redhat.com
> > Subject: [EXT] Re: [PATCH] devtools: ensure proper tag sequence
> >
> > External Email
> >
> > ----------------------------------------------------------------------
> > 12/06/2022 16:23, jpalider@marvell.com:
> > > From: Jakub Palider <jpalider@marvell.com>
> > >
> > > This change to log checking procedure ensures that all
> > > tags are in proper order.
> > > The order of tags is as follows:
> > > * Coverity issue
> > > * Bugzilla ID
> > > * Fixes
> > > * Cc
> > > * <BLANK LINE>
> > > * Suggested-by
> > > * Reported-by
> > > + Signed-off-by
> > > * Acked-by
> > > * Reviewed-by
> > > * Tested-by
> >
> > For the *-by sequence, the order is more chronological.
> > Ack/Review/Test can be in any order I think.
> >
> >
> Hi Thomas,
> Do I get it right that the lines after <BLANK LINE> are fine in
> current state and the patch could take care of the first section
> only?
I'm not sure myself.
We can check at least that Suggested/Reported is before Signed-off.
prev parent reply other threads:[~2022-06-13 13:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-12 14:23 jpalider
2022-06-12 20:28 ` Thomas Monjalon
2022-06-13 10:35 ` [EXT] " Jakub Palider
2022-06-13 13:54 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2460878.4XsnlVU6TS@thomas \
--to=thomas@monjalon.net \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=jpalider@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).