DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Rasesh Mody <rasesh.mody@qlogic.com>
Cc: dev@dpdk.org, sony.chacko@qlogic.com
Subject: Re: [dpdk-dev] [PATCH v3 06/11] bnx2x: FreeBSD enablement
Date: Tue, 24 Nov 2015 15:09:23 +0100	[thread overview]
Message-ID: <2464754.e2c3r8392f@xps13> (raw)
In-Reply-To: <1448351076-23161-7-git-send-email-rasesh.mody@qlogic.com>

2015-11-23 23:44, Rasesh Mody:
> --- a/drivers/net/bnx2x/bnx2x.h
> +++ b/drivers/net/bnx2x/bnx2x.h
> @@ -16,6 +16,12 @@
>  #ifndef __BNX2X_H__
>  #define __BNX2X_H__
>  
> +#ifdef __FreeBSD__
> +#define __LITTLE_ENDIAN _LITTLE_ENDIAN
> +#define __BIG_ENDIAN    _BIG_ENDIAN
> +#define __BYTE_ORDER    _BYTE_ORDER
> +#endif
> +
>  #include "bnx2x_ethdev.h"
>  
>  #if __BYTE_ORDER == __LITTLE_ENDIAN
[...]
> --- a/drivers/net/bnx2x/ecore_sp.h
> +++ b/drivers/net/bnx2x/ecore_sp.h
> @@ -16,6 +16,12 @@
>  #ifndef ECORE_SP_H
>  #define ECORE_SP_H
>  
> +#ifdef __FreeBSD__
> +#define __LITTLE_ENDIAN _LITTLE_ENDIAN
> +#define __BIG_ENDIAN    _BIG_ENDIAN
> +#define __BYTE_ORDER    _BYTE_ORDER
> +#endif
> +
>  #if __BYTE_ORDER == __LITTLE_ENDIAN
>  #ifndef LITTLE_ENDIAN
>  #define LITTLE_ENDIAN

Why not use RTE_BYTE_ORDER which manages already these tricks?
Maybe you have not noticed it:
	lib/librte_eal/common/include/generic/rte_byteorder.h

  reply	other threads:[~2015-11-24 14:10 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-24  7:44 [dpdk-dev] [PATCH v3 00/11] bnx2x: Enhancement, fixes, licensing and doumentation Rasesh Mody
2015-11-24  7:44 ` [dpdk-dev] [PATCH v3 01/11] bnx2x: Update VF to support newer PF drivers Rasesh Mody
2015-11-24  7:44 ` [dpdk-dev] [PATCH v3 02/11] bnx2x: Fix x86_64-native-linuxapp-clang build error Rasesh Mody
2015-11-24  7:44 ` [dpdk-dev] [PATCH v3 03/11] bnx2x: Add periodic debug option Rasesh Mody
2015-11-24  7:44 ` [dpdk-dev] [PATCH v3 04/11] doc: Add BNX2X PMD documentationdoc: Add BNX2X PMD documentation Rasesh Mody
2015-11-24 14:16   ` Thomas Monjalon
2015-11-24  7:44 ` [dpdk-dev] [PATCH v3 05/11] bnx2x: Add LICENSE.bnx2x_pmd and update source files Rasesh Mody
2015-11-24  7:44 ` [dpdk-dev] [PATCH v3 06/11] bnx2x: FreeBSD enablement Rasesh Mody
2015-11-24 14:09   ` Thomas Monjalon [this message]
2015-11-24  7:44 ` [dpdk-dev] [PATCH v3 07/11] bnx2x: Linux 32bit enablement Rasesh Mody
2015-11-24  7:44 ` [dpdk-dev] [PATCH v3 08/11] bnx2x: Handle zlib compatibility error Rasesh Mody
2015-11-24  7:44 ` [dpdk-dev] [PATCH v3 09/11] maintainers: Add maintainers for BNX2X PMD Rasesh Mody
2015-11-24 14:19   ` Thomas Monjalon
2015-11-24  7:44 ` [dpdk-dev] [PATCH v3 10/11] config: Enable BNX2X driver build by default Rasesh Mody
2015-11-24 14:25   ` Thomas Monjalon
2015-12-03  0:54     ` Rasesh Mody
2015-12-03  1:30       ` Thomas Monjalon
2015-12-03  2:54         ` Rasesh Mody
2015-12-08 21:45     ` Rasesh Mody
2015-11-24  7:44 ` [dpdk-dev] [PATCH v3 11/11] bnx2x: Add BNX2X PMD versioning Rasesh Mody

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2464754.e2c3r8392f@xps13 \
    --to=thomas.monjalon@6wind.com \
    --cc=dev@dpdk.org \
    --cc=rasesh.mody@qlogic.com \
    --cc=sony.chacko@qlogic.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).