[dpdk-dev] [PATCH] table: hash: fix entry size of configurable key size ext and lru

DPDK patches and discussions
 help / color / mirror / Atom feed

* [dpdk-dev] [PATCH] table: hash: fix entry size of configurable key size ext and lru
@ 2014-08-11  3:43 Takayuki Usui
  2014-11-26 21:18 ` Thomas Monjalon
  0 siblings, 1 reply; 4+ messages in thread
From: Takayuki Usui @ 2014-08-11  3:43 UTC (permalink / raw)
  To: dev

Signed-off-by: Takayuki Usui <takayuki@midokura.com>
---
 lib/librte_table/rte_table_hash_ext.c | 2 +-
 lib/librte_table/rte_table_hash_lru.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib/librte_table/rte_table_hash_ext.c b/lib/librte_table/rte_table_hash_ext.c
index 6e26d98..8b86fab 100644
--- a/lib/librte_table/rte_table_hash_ext.c
+++ b/lib/librte_table/rte_table_hash_ext.c
@@ -221,7 +221,7 @@ rte_table_hash_ext_create(void *params, int socket_id, uint32_t entry_size)
 	/* Internal */
 	t->bucket_mask = t->n_buckets - 1;
 	t->key_size_shl = __builtin_ctzl(p->key_size);
-	t->data_size_shl = __builtin_ctzl(p->key_size);
+	t->data_size_shl = __builtin_ctzl(entry_size);
 
 	/* Tables */
 	table_meta_offset = 0;
diff --git a/lib/librte_table/rte_table_hash_lru.c b/lib/librte_table/rte_table_hash_lru.c
index d1a4984..bf92e81 100644
--- a/lib/librte_table/rte_table_hash_lru.c
+++ b/lib/librte_table/rte_table_hash_lru.c
@@ -192,7 +192,7 @@ rte_table_hash_lru_create(void *params, int socket_id, uint32_t entry_size)
 	/* Internal */
 	t->bucket_mask = t->n_buckets - 1;
 	t->key_size_shl = __builtin_ctzl(p->key_size);
-	t->data_size_shl = __builtin_ctzl(p->key_size);
+	t->data_size_shl = __builtin_ctzl(entry_size);
 
 	/* Tables */
 	table_meta_offset = 0;
-- 
2.0.3

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dpdk-dev] [PATCH] table: hash: fix entry size of configurable key size ext and lru
  2014-08-11  3:43 [dpdk-dev] [PATCH] table: hash: fix entry size of configurable key size ext and lru Takayuki Usui
@ 2014-11-26 21:18 ` Thomas Monjalon
  2014-11-27 10:34   ` Dumitrescu, Cristian
  2014-11-27 10:38   ` Dumitrescu, Cristian
  0 siblings, 2 replies; 4+ messages in thread
From: Thomas Monjalon @ 2014-11-26 21:18 UTC (permalink / raw)
  To: Takayuki Usui, cristian.dumitrescu; +Cc: dev, balazs.nemeth

Hi,

2014-08-11 12:43, Takayuki Usui:
> Signed-off-by: Takayuki Usui <takayuki@midokura.com>
> ---
>  lib/librte_table/rte_table_hash_ext.c | 2 +-
>  lib/librte_table/rte_table_hash_lru.c | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/lib/librte_table/rte_table_hash_ext.c b/lib/librte_table/rte_table_hash_ext.c
> index 6e26d98..8b86fab 100644
> --- a/lib/librte_table/rte_table_hash_ext.c
> +++ b/lib/librte_table/rte_table_hash_ext.c
> @@ -221,7 +221,7 @@ rte_table_hash_ext_create(void *params, int socket_id, uint32_t entry_size)
>  	/* Internal */
>  	t->bucket_mask = t->n_buckets - 1;
>  	t->key_size_shl = __builtin_ctzl(p->key_size);
> -	t->data_size_shl = __builtin_ctzl(p->key_size);
> +	t->data_size_shl = __builtin_ctzl(entry_size);
>  
>  	/* Tables */
>  	table_meta_offset = 0;
> diff --git a/lib/librte_table/rte_table_hash_lru.c b/lib/librte_table/rte_table_hash_lru.c
> index d1a4984..bf92e81 100644
> --- a/lib/librte_table/rte_table_hash_lru.c
> +++ b/lib/librte_table/rte_table_hash_lru.c
> @@ -192,7 +192,7 @@ rte_table_hash_lru_create(void *params, int socket_id, uint32_t entry_size)
>  	/* Internal */
>  	t->bucket_mask = t->n_buckets - 1;
>  	t->key_size_shl = __builtin_ctzl(p->key_size);
> -	t->data_size_shl = __builtin_ctzl(p->key_size);
> +	t->data_size_shl = __builtin_ctzl(entry_size);
>  
>  	/* Tables */
>  	table_meta_offset = 0;

A similar patch has been recently applied:
	http://dpdk.org/browse/dpdk/commit/?id=8595428e50

Cristian, as the author of this library, it would be appreciated that you
review and ack such patch. It's important to accept contributions and give
credit to the first author of a patch.

Thanks
-- 
Thomas

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dpdk-dev] [PATCH] table: hash: fix entry size of configurable key size ext and lru
  2014-11-26 21:18 ` Thomas Monjalon
@ 2014-11-27 10:34   ` Dumitrescu, Cristian
  2014-11-27 10:38   ` Dumitrescu, Cristian
  1 sibling, 0 replies; 4+ messages in thread
From: Dumitrescu, Cristian @ 2014-11-27 10:34 UTC (permalink / raw)
  To: Thomas Monjalon, Takayuki Usui; +Cc: dev, Nemeth, Balazs

Hi Thomas,

Yes, we can confirm that this patch is identical to one of the fixes provided by Balazs with his set of patches which were already applied.

Sorry for not seeing this patch earlier.

Thank you, Takayuki San for doing this work and sending us the patch!

Regards,
Cristian


-----Original Message-----
From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] 
Sent: Wednesday, November 26, 2014 9:18 PM
To: Takayuki Usui; Dumitrescu, Cristian
Cc: dev@dpdk.org; Nemeth, Balazs
Subject: Re: [dpdk-dev] [PATCH] table: hash: fix entry size of configurable key size ext and lru

Hi,

2014-08-11 12:43, Takayuki Usui:
> Signed-off-by: Takayuki Usui <takayuki@midokura.com>
> ---
>  lib/librte_table/rte_table_hash_ext.c | 2 +-
>  lib/librte_table/rte_table_hash_lru.c | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/lib/librte_table/rte_table_hash_ext.c b/lib/librte_table/rte_table_hash_ext.c
> index 6e26d98..8b86fab 100644
> --- a/lib/librte_table/rte_table_hash_ext.c
> +++ b/lib/librte_table/rte_table_hash_ext.c
> @@ -221,7 +221,7 @@ rte_table_hash_ext_create(void *params, int socket_id, uint32_t entry_size)
>  	/* Internal */
>  	t->bucket_mask = t->n_buckets - 1;
>  	t->key_size_shl = __builtin_ctzl(p->key_size);
> -	t->data_size_shl = __builtin_ctzl(p->key_size);
> +	t->data_size_shl = __builtin_ctzl(entry_size);
>  
>  	/* Tables */
>  	table_meta_offset = 0;
> diff --git a/lib/librte_table/rte_table_hash_lru.c b/lib/librte_table/rte_table_hash_lru.c
> index d1a4984..bf92e81 100644
> --- a/lib/librte_table/rte_table_hash_lru.c
> +++ b/lib/librte_table/rte_table_hash_lru.c
> @@ -192,7 +192,7 @@ rte_table_hash_lru_create(void *params, int socket_id, uint32_t entry_size)
>  	/* Internal */
>  	t->bucket_mask = t->n_buckets - 1;
>  	t->key_size_shl = __builtin_ctzl(p->key_size);
> -	t->data_size_shl = __builtin_ctzl(p->key_size);
> +	t->data_size_shl = __builtin_ctzl(entry_size);
>  
>  	/* Tables */
>  	table_meta_offset = 0;

A similar patch has been recently applied:
	http://dpdk.org/browse/dpdk/commit/?id=8595428e50

Cristian, as the author of this library, it would be appreciated that you
review and ack such patch. It's important to accept contributions and give
credit to the first author of a patch.

Thanks
-- 
Thomas
--------------------------------------------------------------
Intel Shannon Limited
Registered in Ireland
Registered Office: Collinstown Industrial Park, Leixlip, County Kildare
Registered Number: 308263
Business address: Dromore House, East Park, Shannon, Co. Clare

This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dpdk-dev] [PATCH] table: hash: fix entry size of configurable key size ext and lru
  2014-11-26 21:18 ` Thomas Monjalon
  2014-11-27 10:34   ` Dumitrescu, Cristian
@ 2014-11-27 10:38   ` Dumitrescu, Cristian
  1 sibling, 0 replies; 4+ messages in thread
From: Dumitrescu, Cristian @ 2014-11-27 10:38 UTC (permalink / raw)
  To: Thomas Monjalon, Takayuki Usui; +Cc: dev, Nemeth, Balazs

Acked by: Cristian Dumitrescu <Cristian.Dumitrescu at intel.com>

-----Original Message-----
From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] 
Sent: Wednesday, November 26, 2014 9:18 PM
To: Takayuki Usui; Dumitrescu, Cristian
Cc: dev@dpdk.org; Nemeth, Balazs
Subject: Re: [dpdk-dev] [PATCH] table: hash: fix entry size of configurable key size ext and lru

Hi,

2014-08-11 12:43, Takayuki Usui:
> Signed-off-by: Takayuki Usui <takayuki@midokura.com>
> ---
>  lib/librte_table/rte_table_hash_ext.c | 2 +-
>  lib/librte_table/rte_table_hash_lru.c | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/lib/librte_table/rte_table_hash_ext.c b/lib/librte_table/rte_table_hash_ext.c
> index 6e26d98..8b86fab 100644
> --- a/lib/librte_table/rte_table_hash_ext.c
> +++ b/lib/librte_table/rte_table_hash_ext.c
> @@ -221,7 +221,7 @@ rte_table_hash_ext_create(void *params, int socket_id, uint32_t entry_size)
>  	/* Internal */
>  	t->bucket_mask = t->n_buckets - 1;
>  	t->key_size_shl = __builtin_ctzl(p->key_size);
> -	t->data_size_shl = __builtin_ctzl(p->key_size);
> +	t->data_size_shl = __builtin_ctzl(entry_size);
>  
>  	/* Tables */
>  	table_meta_offset = 0;
> diff --git a/lib/librte_table/rte_table_hash_lru.c b/lib/librte_table/rte_table_hash_lru.c
> index d1a4984..bf92e81 100644
> --- a/lib/librte_table/rte_table_hash_lru.c
> +++ b/lib/librte_table/rte_table_hash_lru.c
> @@ -192,7 +192,7 @@ rte_table_hash_lru_create(void *params, int socket_id, uint32_t entry_size)
>  	/* Internal */
>  	t->bucket_mask = t->n_buckets - 1;
>  	t->key_size_shl = __builtin_ctzl(p->key_size);
> -	t->data_size_shl = __builtin_ctzl(p->key_size);
> +	t->data_size_shl = __builtin_ctzl(entry_size);
>  
>  	/* Tables */
>  	table_meta_offset = 0;

A similar patch has been recently applied:
	http://dpdk.org/browse/dpdk/commit/?id=8595428e50

Cristian, as the author of this library, it would be appreciated that you
review and ack such patch. It's important to accept contributions and give
credit to the first author of a patch.

Thanks
-- 
Thomas
--------------------------------------------------------------
Intel Shannon Limited
Registered in Ireland
Registered Office: Collinstown Industrial Park, Leixlip, County Kildare
Registered Number: 308263
Business address: Dromore House, East Park, Shannon, Co. Clare

This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies.

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2014-11-27 10:38 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-08-11  3:43 [dpdk-dev] [PATCH] table: hash: fix entry size of configurable key size ext and lru Takayuki Usui
2014-11-26 21:18 ` Thomas Monjalon
2014-11-27 10:34   ` Dumitrescu, Cristian
2014-11-27 10:38   ` Dumitrescu, Cristian

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).