From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM01-BY2-obe.outbound.protection.outlook.com (mail-by2nam01on0072.outbound.protection.outlook.com [104.47.34.72]) by dpdk.org (Postfix) with ESMTP id C80EA1B6F1; Fri, 13 Oct 2017 16:24:32 +0200 (CEST) Received: from CY1PR03CA0027.namprd03.prod.outlook.com (10.174.128.37) by BN3PR03MB2355.namprd03.prod.outlook.com (10.166.74.150) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.77.7; Fri, 13 Oct 2017 14:24:31 +0000 Received: from BL2FFO11FD045.protection.gbl (2a01:111:f400:7c09::192) by CY1PR03CA0027.outlook.office365.com (2603:10b6:600::37) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.56.8 via Frontend Transport; Fri, 13 Oct 2017 14:24:30 +0000 Authentication-Results: spf=fail (sender IP is 192.88.168.50) smtp.mailfrom=nxp.com; nxp.com; dkim=none (message not signed) header.d=none;nxp.com; dmarc=fail action=none header.from=nxp.com; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.168.50 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.168.50; helo=tx30smr01.am.freescale.net; Received: from tx30smr01.am.freescale.net (192.88.168.50) by BL2FFO11FD045.mail.protection.outlook.com (10.173.161.207) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.20.77.10 via Frontend Transport; Fri, 13 Oct 2017 14:24:30 +0000 Received: from [10.232.134.49] (B35197-11.ap.freescale.net [10.232.134.49]) by tx30smr01.am.freescale.net (8.14.3/8.14.0) with ESMTP id v9DEORtt024734; Fri, 13 Oct 2017 07:24:28 -0700 To: , CC: , , References: <20171012130726.4332-1-alok.makhariya@nxp.com> <20171012130726.4332-4-alok.makhariya@nxp.com> From: Akhil Goyal Message-ID: <2470350a-6ec3-6ce6-7100-18c93e49586c@nxp.com> Date: Fri, 13 Oct 2017 19:54:27 +0530 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <20171012130726.4332-4-alok.makhariya@nxp.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-Matching-Connectors: 131523782708562922; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.168.50; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(7966004)(336005)(39860400002)(39380400002)(346002)(376002)(2980300002)(1109001)(1110001)(339900001)(189002)(199003)(377454003)(24454002)(58126008)(316002)(36756003)(31696002)(86362001)(54356999)(76176999)(5660300001)(97736004)(230700001)(110136005)(50986999)(6246003)(31686004)(68736007)(4326008)(229853002)(2906002)(64126003)(498600001)(77096006)(2950100002)(83506001)(8676002)(81156014)(106466001)(105606002)(53936002)(356003)(189998001)(47776003)(81166006)(8936002)(50466002)(8656003)(54906003)(53546010)(65956001)(65826007)(65806001)(305945005)(85426001)(104016004)(33646002)(23676002); DIR:OUT; SFP:1101; SCL:1; SRVR:BN3PR03MB2355; H:tx30smr01.am.freescale.net; FPR:; SPF:Fail; PTR:InfoDomainNonexistent; MX:1; A:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BL2FFO11FD045; 1:sHYoDBxgd+t4jOh4BlAqNUIxb7sIk8mNwBdMjVOrXHNUxvic/ayIvBzDTnxvA9xkgvE+0iAoNv37KqsJowAOXLmn/aPPrBKM2qd4y+8AZ3beAIMVAxH4WekBikljUXJS X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 240b7f3d-7135-461f-aa8d-08d512461e50 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(2017052603199)(201703131430075)(201703131517081); SRVR:BN3PR03MB2355; X-Microsoft-Exchange-Diagnostics: 1; BN3PR03MB2355; 3:1oWJuZOkVX/iPTw+bIh+AOD5/IO9X4Y/k3Cjv+qq59ypsOGmHr1wfugbt8cXc/ebPob2Hl/u0JFD8FD0UP6Ucj40BxHLXZu2N3zS69ZcmHYoFGaRxD0OpdNClyXb5ZkxwbiQ1OdvE24pRWRahESXNNUayGr+5bc8NE0N1i0nZutU3Jr+sjIgnyU2oUzzCz/Lg+lAg3XwpgrFwgxnd8pDdO3HqJMfPIlXJR1Vi/DlsYfoESxtNaTKF2wnGaC6WS6AsxG5a3+SOblx9IZbmdbol9FUMkNtzV14Dv0U53ALmG66bMPkGN9iwjTAhX/QVHT8KsSFdY33t/K9bZyntNK5WnyIwP+nFsyiL65dzpNwsyA=; 25:VZvD+e+qVjwtsl6Sb9S5tjzvEPwSvabcu8uWsMUth2jtaC9zdUxSxHJmSMo59XKki2SyB6AACg+GCLOVQMN38mvtfRYHCWtcaIFSKpSnwIeZyCuKAJk5G87hT1u5qONeSJX6NxQF08MjjerIsiGgYVQpwKKoiMBaIBox26xHxIeoMmeHndklrVrRLJ/L5Eu9ypN0+SL+RKFLfzBnkxc3jveuHWBTcTGgk0IxK1+GMXdRxYW5dAtcOYx3KMq+eYHvS/ZcpbOXHk7V7cw6wXYlgNVFtLpZLlTP6L59570mpiwH2UJ8/zI+AUuZwo8clWTqphxSWAOWdPMUiK/TRSfg6g== X-MS-TrafficTypeDiagnostic: BN3PR03MB2355: X-Microsoft-Exchange-Diagnostics: 1; BN3PR03MB2355; 31:K+ki8uVRHpmu9L43HgeHvN1QbVr573WxgDFt4yw415fzD5AnKoj/Oycm10jw05xQiPQKOlJJvE7yptzgg1DvAhSflK01+QVrnZvZLg8BwW5uTrh16GlvyNe6m8oAciLSHvjvzrirtrFihTj9ZYSjK42gr9qNJy1p6c9xKT2ho6I0KrriOxUh2bYP4TG40zDE9iJWG/n3aVkMXnn8Xu+2NKP6Wb+GbQyOS2gvvm8BSfM=; 4:4l0we8rTBjMJjATKjbpiXL8Cc9EZoZfH59lbhZ3omxc3Cl3o20yoGWeNnBpTmcbmZ02/bxk0pUZIkItajKvRLiDpFsuAAU/sclT3UFEgG9SyIaY9R5gQwk44mszZP6Ktej/b+a9xK3QTEPAz65MPBU9fXD0rva8us1M6j84wsTeDpUlpSbdRLk/jFSR0G3kJFSDiOEWtse+mS5GO8Zr1VlsA0NdiHpvCOQP/RfQV8JR+KSDJgmZXHUuzmH6D8nvkqxahVm5cqbGLcHKJetGDFfI5pFZaHx/foSbTI/4huPw= X-Exchange-Antispam-Report-Test: UriScan:(185117386973197); X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6095135)(2401047)(5005006)(8121501046)(3002001)(93006095)(93001095)(10201501046)(100000703101)(100105400095)(6055026)(6096035)(20161123561025)(20161123559100)(20161123563025)(201703131430075)(201703131433075)(201703131441075)(201703131448075)(201703161259150)(20161123565025)(20161123556025)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:BN3PR03MB2355; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(400006)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:BN3PR03MB2355; X-Forefront-PRVS: 04599F3534 X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtCTjNQUjAzTUIyMzU1OzIzOjZSZXdrRlAxdG1pWjVaRWFIdytDL2s5dEJF?= =?utf-8?B?aVNycnB3MXBNdHF2clE4alF5VW5nOU5PUHI4eExSZVhmbUVtTjA3S2FBQk92?= =?utf-8?B?VTZzcVBHc1dNbEdXRkp5RzdSMVlHVkRMajc1OFV0S3hoOVVlRXlNcWVmV2lx?= =?utf-8?B?Z1FSOERlc3FsdEorZDgrLzdpSmxnMmNOcmRkQ0tYZGFWQ0llN0ZmZkpGRWF3?= =?utf-8?B?QkY4d0h0bWZKVjNlSEp6S08wRmhIaWdnS20ySFVlWnVyODdiSnF5VkZUdXJJ?= =?utf-8?B?TG9KRjdHcTJzT1VCNWhzQ1I5MTJYRitQMU1oVXh3cnJXVnRobCtpY21MTEZY?= =?utf-8?B?alVHeXY4WUJEbnFwRTd4NThma3JWa0h6Vll4VjBQNjVMeDZvMzR5d1RqZVF0?= =?utf-8?B?QVJPUWJiYVlKd0N3ZFdQbnRGR2FqdGRad3BJakdzdk5OK0IyNkpYNE1KcDBZ?= =?utf-8?B?RUJOekdESmUrZGFrcEFhT2EyMVJPOUN1eEpKS0xuSElhTXZENEIrR3dCL29S?= =?utf-8?B?WE5xazcvNEY3dzVWb3JwQlg4NXJaYVBJNE1wWnlHUXVpOUp0OTJlU2VRTXRM?= =?utf-8?B?YzNsYU51UVdTYXc4aU1QWlVhN2JJQXlJU2NKRmtqK2dtRlRjRTBEMVRHR0Jo?= =?utf-8?B?Snh3aVkrT1YwNWdiQktWdkU3bUQ2NGx2bUM4bnlFL0kwQlc0Y2FjQWF1SDBM?= =?utf-8?B?U0tQQUh4SCtRRDVCQ2RmbE1FTkU3M2hMVDZOQU9HRUx2R3NTa25FMjh0Q3Q1?= =?utf-8?B?amh1USs1MVZEbVIvSmZ2NUlvbzBBMkI1WlpSOFp0MTdLc1RvbmhGbDZ6NFlR?= =?utf-8?B?c1krMWpmdVYzWVpqMDBQbCtLbXVzWHZyZzRSVDdOTTVEdDhoM2N1d25NZjVu?= =?utf-8?B?akI0b2RIWGJNSEhIT1lIM2twL1NjK0lXUklFMVVrdW9EMFN6US9IVVdkcjNQ?= =?utf-8?B?dk5rYTJSbWhwYUNSb3k1OU9ncDN1aEV1VDFYTHhrRWoxdkJyRmlRNHhRbXZB?= =?utf-8?B?YzZka0JjRGlSKzl4MXV5QXE1L3BHM01qc1UxcGE4TGo5d0hUMjRsYnNsNWF0?= =?utf-8?B?WDV2YVZPNTBwLzNHbSt2WnE3UnpVZ3UwYmk4TnhzNERvaDdQS1FpdnlSMG1Q?= =?utf-8?B?czlqZkRzVndJSmdxREVjQ3pOWUttc2ljQ2NpVjgwRDM4ODlrMk5OQThsSXB0?= =?utf-8?B?bjI1T3FpdFhBU2lNM3QyTTB1QnF1YWpkT1ptaVZsdXlOSXBndE0zTWtoT0gx?= =?utf-8?B?TkExdlM5bHBpN2JGNzU2ZllyZ1o4UmFXUnlLdU12OFZDa1F5K29BdkViMXly?= =?utf-8?B?Yy91QU9QckN2NWNQYnpmTWpGMmp6OWtXOUhsbWZXQjNWOUdmYmlRR0V0NGxt?= =?utf-8?B?U3oyTzJ3alpPWjZweGRweVp2R3ZReGF1NmF6WXA1bFcyQ1ZjYm1DajBoY1dK?= =?utf-8?B?VUxkc1pFeCtSZXlrV2wwZ2RDZytxampLR3dobFNTS2tOWWpQZ0wwUTJhY2Jt?= =?utf-8?B?d21RazZ5NEJNajBzc2xBUTBEbEZRRnl2SzM3YlJqb2o2cTFWam5adm9yUm84?= =?utf-8?B?eE5xRXVIWEp6a3ZJSVRvR29Xa3cwbHNpL1dEU094SkJGTWZobFU3SlpTWjhq?= =?utf-8?B?N1U3cTlPc3hmaDZzSjZ5a0ZETC9ET2ppT3d2RWpuNVg1ejY2N0MxM0ltL3Ir?= =?utf-8?B?Tkp4SzgweUJubGFmT3BYN2swci96RG4zVGh0S0JZZThzODdFNDVXTnl6dkc4?= =?utf-8?B?Rm1nTFFGeEJNTW5aRHdZUWt0dUtFQkRoQ0NwK1EvcnYwdEEyWHpmbXROdDI2?= =?utf-8?B?N2tna1A0UlU4bnl5UXMwWG5MSythWFhYUThlRWltMlRBQXVoK2RZajZkSjMy?= =?utf-8?Q?tkL1ImJF1r5kSgjQ6Dz9wyUmFSLHQiBl?= X-Microsoft-Exchange-Diagnostics: 1; BN3PR03MB2355; 6:2lqlwI1i5xPo/caUFvYKA7sNTLHFI6qJxLaZxD5LgGbGJLbWjwqyhu9OAeiR6YGj0xSNebyqnUGYR3Lt5VjJjUyMIwP38dP+QIscoCR8Be55h3ksUTB4GxwGKx7nR+pZvyRgbZGMEkrcCahmDUQMojKm04yQccDtKXONevbQ4gDL3d33BIAvtTvb3hcaXcwCaGxD6igCvZDUAM1xHW255cBhSoVdnb8mcauFqBGhg9eb1BVD5+pLmGqFBgAtMP8veCiZHN9rQbFs+QT9tyXdtWPfcvFXyRMDVXEgdxtSJoyRtkHfx0N2fkQRwkrgvXKR+aLatr9aTtDFxo2Ypx+BIw==; 5:zpI3Ot9VHr+lD9g002oGOUFSJKhV9se34jFyWkC9Jwq3Up7J0ey7xi8eWDv6GFSWCsgn8LDAjGaYIRHmRsZ8uzTlcnGJ3MoBbEzUFWzdjKuAGpcmikFiG9bIjvEx1V+IR1CqIKG2wjSzRG/7o8ji5lvAs+eEsoM47WhknVlBviM=; 24:G+b6vhQOPOKcAUByAIl7e07ji/AG6YT+pVUQE44BbTLAdMNE9wh9qoVyVmdtFfsCC1HkHfTWaQ0m+W3SaEC5NTkL/h47qurFRB9axr72uws=; 7:sXbtvVG7TsupXgJXXCQvdv1z55U4/RuuKuigya27OJ42NG8QdV+w0jL4rUzCmR9g6vrnBIqlPopnf766hMBBVr34y7ERs5L68bGKVbX7K2jhE0lmahkRHcIDEwuOdFcVCCwLr0Gfz9yIPnBGImLX9QhFN152qoA592D1FR77kxTVta4ez2uh/OAdv8byE4QDIGIZbGYV4Glv8VFMnvSwypQZxFwkYKUc8lL7EUb/epE= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Oct 2017 14:24:30.6690 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.168.50]; Helo=[tx30smr01.am.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN3PR03MB2355 Subject: Re: [dpdk-dev] [PATCH] crypto/dpaa2_sec: remove memset of icv on decryption side X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Oct 2017 14:24:33 -0000 On 10/12/2017 6:37 PM, alok.makhariya@nxp.com wrote: > From: Alok Makhariya > > Since the packet lengths are modified. It is not required to > explicitly reset the icv. > > Fixes: 13273250eec5 ("crypto/dpaa2_sec: support AES-GCM and CTR") > Fixes: 8d1f3a5d751b ("crypto/dpaa2_sec: support crypto operation") > Cc: stable@dpdk.org > > Signed-off-by: Alok Makhariya > --- > drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c b/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c > index 9895300..62b9203 100644 > --- a/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c > +++ b/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c > @@ -203,7 +203,6 @@ build_authenc_gcm_fd(dpaa2_sec_session *sess, > old_icv = (uint8_t *)(sge + 1); > memcpy(old_icv, sym_op->aead.digest.data, > sess->digest_length); > - memset(sym_op->aead.digest.data, 0, sess->digest_length); > DPAA2_SET_FLE_ADDR(sge, DPAA2_VADDR_TO_IOVA(old_icv)); > sge->length = sess->digest_length; > DPAA2_SET_FD_LEN(fd, (sym_op->aead.data.length + > @@ -342,7 +341,6 @@ build_authenc_fd(dpaa2_sec_session *sess, > old_icv = (uint8_t *)(sge + 1); > memcpy(old_icv, sym_op->auth.digest.data, > sess->digest_length); > - memset(sym_op->auth.digest.data, 0, sess->digest_length); > DPAA2_SET_FLE_ADDR(sge, DPAA2_VADDR_TO_IOVA(old_icv)); > sge->length = sess->digest_length; > DPAA2_SET_FD_LEN(fd, (sym_op->auth.data.length + > @@ -436,7 +434,6 @@ build_auth_fd(dpaa2_sec_session *sess, struct rte_crypto_op *op, > old_digest = (uint8_t *)(sge + 1); > rte_memcpy(old_digest, sym_op->auth.digest.data, > sess->digest_length); > - memset(sym_op->auth.digest.data, 0, sess->digest_length); > DPAA2_SET_FLE_ADDR(sge, DPAA2_VADDR_TO_IOVA(old_digest)); > sge->length = sess->digest_length; > fle->length = sym_op->auth.data.length + > > Acked-by: Akhil Goyal