From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id CC5F91B1A7; Mon, 21 May 2018 15:16:49 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 4FAF521511; Mon, 21 May 2018 09:16:49 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Mon, 21 May 2018 09:16:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=6xRjlSkqgnOmPcqeWOFJHPw9OY pXJPoF0BjIXCY9Q/E=; b=e9QsBCjgM1wnoB3PZJsFLcJ9zJwZygi4kdatLCJ1Yd o1He2bqyEegU16odqVdJvFw2jck1E77ZKqIfnD9pBcsgukDD1xSRycLJ2GjlBc5/ 05v/tHXTGnfgSmsvpImo+nIPj58YcmGTqteMnXI2wTc+FmPORQUrsKvl8t8U8Mn+ g= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=6xRjlS kqgnOmPcqeWOFJHPw9OYpXJPoF0BjIXCY9Q/E=; b=DuSkpE2FjqTfUrSK4nu6Fw CSgqTPCR8EKGuPihda7AqPpHBG6ylyj3/mAITellBQHeUksNMLtNKTCAdiMHbH65 O1chfJ9Z8rphA9PYm+uRWW7GCv+cwfLN9/dRWVD/M/jx37q+qAulm51tS3saPS7C ftFzAzC68/99EyaI2gjla0UCZj53d4BN8Oyu8QEmJBe8CJCqpVCQTSEStpNCE6Pb kB05hH+OG5C2g7ZE4vQ1b3qdSKb5R44ZxenAaI5LvpngBmHbxZSJefkzd7Vj5tzk efq8+hc5HZmHXri0/jKFt2W/e9561oPELVTDYteS1hEzWMXQrf4LSo38t5uTYkSA == X-ME-Proxy: X-ME-Proxy: X-ME-Proxy: X-ME-Proxy: X-ME-Proxy: X-ME-Proxy: X-ME-Sender: Received: from xps.localnet (236.204.154.77.rev.sfr.net [77.154.204.236]) by mail.messagingengine.com (Postfix) with ESMTPA id D19F31025C; Mon, 21 May 2018 09:16:47 -0400 (EDT) From: Thomas Monjalon To: Radu Nicolau Cc: dev@dpdk.org, ferruh.yigit@intel.com, stable@dpdk.org Date: Mon, 21 May 2018 15:16:45 +0200 Message-ID: <2472085.2sczoQJf8F@xps> In-Reply-To: <8ed23c52-4b88-b40a-ccc5-31c6993654a1@intel.com> References: <1526902547-12710-1-git-send-email-radu.nicolau@intel.com> <5146448.Vdf9GQnNb8@xps> <8ed23c52-4b88-b40a-ccc5-31c6993654a1@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] test: fix hang on FreeBSD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 May 2018 13:16:50 -0000 21/05/2018 14:58, Radu Nicolau: > > On 5/21/2018 1:30 PM, Thomas Monjalon wrote: > > 21/05/2018 13:35, Radu Nicolau: > >> Fixes: af75078fece3 ("first public release") > >> Cc: stable@dpdk.org > >> > >> Signed-off-by: Radu Nicolau > >> --- > >> @@ -34,7 +34,8 @@ test_panic(void) > >> printf("Fork Failed\n"); > >> return -1; > >> } > >> - wait(&status); > >> + sleep(1); > >> + waitpid(pid, &status, WNOHANG); > > Please give an explanation why you are adding this sleep. > > > To give a chance to the child process to complete before calling waitpid. One second in an unit test is a lot. When I was asking for explanation, I mean usual explanations in commit message: - what is the issue - what is the root cause - what is the reasoning behind the fix