DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Alejandro Lucero <alejandro.lucero@netronome.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] About RTE_MAX_ETHPORT_QUEUE_STATS_MAPS
Date: Tue, 16 Sep 2014 15:22:11 +0200
Message-ID: <2475783.Ag5OnQsYUV@xps13> (raw)
In-Reply-To: <CAD+H993QTeRjiQJT9UWFXhwa=b6Lk+s+9L0k7OsLB+zhT_mxYw@mail.gmail.com>

Hi,

2014-08-21 10:04, Alejandro Lucero:
> Documentation and header files describe stat_idx parameter for
> rte_eth_dev_set_tx_queue_stats_mapping
> and
> rte_eth_dev_set_rx_queue_stats_mapping
> as
> The value must be in the range
> [0, RTE_MAX_ETHPORT_QUEUE_STATS_MAPS - 1]

This function should not be part of the generic API.
It's an ixgbe-only setup.
Cleanup is required here.

> I have not found a definition for RTE_MAX_ETHPORT_QUEUE_STATS_MAPS but the
> per queue counters inside struct rte_eth_stats are arrays with length
> RTE_ETHDEV_QUEUE_STAT_CNTRS which is defined at
> config/defconfig_x86_64-default-linuxapp-gcc
> CONFIG_RTE_ETHDEV_QUEUE_STAT_CNTRS=16
> 
> I assume RTE_MAX_ETHPORT_QUEUE_STATS_MAPS is equal to
> CONFIG_RTE_ETHDEV_QUEUE_STAT_CNTRS.

To be more precise, this index must be lower than the number of stat
counters (CONFIG_RTE_ETHDEV_QUEUE_STAT_CNTRS=16) AND lower than the
number of ixgbe hardware counters (16 if I remember well).

A patch to fix this doxygen comment would be welcome.
Another patch to move this API in an ixgbe specific file would be great.

Thanks
-- 
Thomas

      reply	other threads:[~2014-09-16 13:16 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-21  9:04 Alejandro Lucero
2014-09-16 13:22 ` Thomas Monjalon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2475783.Ag5OnQsYUV@xps13 \
    --to=thomas.monjalon@6wind.com \
    --cc=alejandro.lucero@netronome.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git