From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-we0-f179.google.com (mail-we0-f179.google.com
 [74.125.82.179]) by dpdk.org (Postfix) with ESMTP id 65B57B38C
 for <dev@dpdk.org>; Tue, 16 Sep 2014 15:16:48 +0200 (CEST)
Received: by mail-we0-f179.google.com with SMTP id u56so5624077wes.10
 for <dev@dpdk.org>; Tue, 16 Sep 2014 06:22:21 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
 :user-agent:in-reply-to:references:mime-version
 :content-transfer-encoding:content-type;
 bh=bDU1i+P9fR8ApZS/ya/mnr9FsPWrHx/WEbRuhdbPwVs=;
 b=hOdOnxrN2aywQns9Ja30btp9QXl84Nt2jnyekeuAsDe5uyCJwCkOMOvOHggT6TkBd3
 pw7o+AdJBdbwrKyCg93jAXq2zDy0AzT+qIkmmf9WBzYz5wgwWcHasoaEVwdwHLq1CeTG
 79KJtDolVifvhi3sJ6rUyParLXxSMUstMKZUf2S0NhKx5HW6bEWqwXyNE4T+Q1ihpOul
 OmJEgcJLNE/W11aAQ0qxtu/skjy7e8oXa9SF8FC6Azl11MP/kIWgUF1g9vucuruxP3w/
 ldkg9ZAanqQR/bZmp7K3JRSsN8Rs0I+Bl0O3mQXlo0IiR6Mo1v75h4duXHpugbrOe2A3
 fFcA==
X-Gm-Message-State: ALoCoQll6NRAtFALkdAA7XgUqSV8/cmfNuzBJcn997nAEbOjP5uQsihRh2O9/K+XXLOEBLFPvZ/i
X-Received: by 10.194.19.165 with SMTP id g5mr43427935wje.65.1410873741590;
 Tue, 16 Sep 2014 06:22:21 -0700 (PDT)
Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136])
 by mx.google.com with ESMTPSA id uk7sm18380187wjc.34.2014.09.16.06.22.20
 for <multiple recipients>
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Tue, 16 Sep 2014 06:22:20 -0700 (PDT)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Alejandro Lucero <alejandro.lucero@netronome.com>
Date: Tue, 16 Sep 2014 15:22:11 +0200
Message-ID: <2475783.Ag5OnQsYUV@xps13>
Organization: 6WIND
User-Agent: KMail/4.13.3 (Linux/3.15.8-1-ARCH; KDE/4.13.3; x86_64; ; )
In-Reply-To: <CAD+H993QTeRjiQJT9UWFXhwa=b6Lk+s+9L0k7OsLB+zhT_mxYw@mail.gmail.com>
References: <CAD+H993QTeRjiQJT9UWFXhwa=b6Lk+s+9L0k7OsLB+zhT_mxYw@mail.gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] About RTE_MAX_ETHPORT_QUEUE_STATS_MAPS
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 16 Sep 2014 13:16:48 -0000

Hi,

2014-08-21 10:04, Alejandro Lucero:
> Documentation and header files describe stat_idx parameter for
> rte_eth_dev_set_tx_queue_stats_mapping
> and
> rte_eth_dev_set_rx_queue_stats_mapping
> as
> The value must be in the range
> [0, RTE_MAX_ETHPORT_QUEUE_STATS_MAPS - 1]

This function should not be part of the generic API.
It's an ixgbe-only setup.
Cleanup is required here.

> I have not found a definition for RTE_MAX_ETHPORT_QUEUE_STATS_MAPS but the
> per queue counters inside struct rte_eth_stats are arrays with length
> RTE_ETHDEV_QUEUE_STAT_CNTRS which is defined at
> config/defconfig_x86_64-default-linuxapp-gcc
> CONFIG_RTE_ETHDEV_QUEUE_STAT_CNTRS=16
> 
> I assume RTE_MAX_ETHPORT_QUEUE_STATS_MAPS is equal to
> CONFIG_RTE_ETHDEV_QUEUE_STAT_CNTRS.

To be more precise, this index must be lower than the number of stat
counters (CONFIG_RTE_ETHDEV_QUEUE_STAT_CNTRS=16) AND lower than the
number of ixgbe hardware counters (16 if I remember well).

A patch to fix this doxygen comment would be welcome.
Another patch to move this API in an ixgbe specific file would be great.

Thanks
-- 
Thomas