From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0AEC9A05A1; Wed, 22 Apr 2020 00:40:54 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 05A1A1C2E7; Wed, 22 Apr 2020 00:40:53 +0200 (CEST) Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 815C01C1DD for ; Wed, 22 Apr 2020 00:40:51 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 088595C00A0; Tue, 21 Apr 2020 18:40:50 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Tue, 21 Apr 2020 18:40:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= CBJDu+tLYMFmZiYvllQo3UxstAccRrb2KPRv5Ta4sFQ=; b=DI9+EpNHa5+kHsc+ olfezHTgbAjxY7gXzjpYADpkNqempKaiJE0U0FNyux2SfB/rOQvjgKJyXUWnUuzA j0rK5HfdiLV9iSOAvRNWd7AI8nmOEUWjbHXdBWK0XMP/KAiFNptwhYs8YHO+ZV0T dCDj04ZFGQSqIjnNfq4VebZi/lVf9me8tt8rR3pJ5Lst7VT2t3qj9aaX7/J3hZJF f9BN1m95m53XZu1bEy5jsrqnnI/t9AoFFTog+Y19JDeDhgMsqc6QMIAQmuBjTwpO VcPDChNmhIrYLuBuIAq1cf1xKybGB8nqh+B9IX2F9gAozsgWV2kuYyAx6i76IlJ+ QZLTAg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=CBJDu+tLYMFmZiYvllQo3UxstAccRrb2KPRv5Ta4s FQ=; b=DXH/6Y97wTged2uqvJESO/NepTFK4dXhJ0D5Dvz7uDhBzMET37xk7CHdU 2eT3nf+s+TiJ82NLQo0Gv4FDN4TslgFGACruOYp89h/p2CohaFLDh+h6DMTX+Ois d9v4ioO1qmOFdABydPf+/ZpeutDfDyUJ/lYvBSckC5BXd3RixOetqWF/2mjaJeOr D7G+JkY0fJaQQ3NHvueLoWdU6XMcY16uVdlQiyV7SB3wtocq9EU4Yoi+AsN4tQd3 992eO4yGFxWQW4RsSOnEr9ydiaG61OTpqYeIJ2HoMSofhMc4FO3krXiBIr0i2Yuo FoviZ5DmgF12EL/HyWNw5qeBe0Sxg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrgeeigdduudcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph epjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuihiivgeptdenucfrrghr rghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 0420B3065C96; Tue, 21 Apr 2020 18:40:47 -0400 (EDT) From: Thomas Monjalon To: Dmitry Kozlyuk Cc: dev@dpdk.org, "Dmitry Malloy (MESHCHANINOV)" , Narcisa Ana Maria Vasile , Fady Bader , Tal Shnaiderman , Harini Ramakrishnan , Omar Cardona , Pallavi Kadam , Ranjit Menon Date: Wed, 22 Apr 2020 00:40:41 +0200 Message-ID: <2477724.Isy0gbHreE@thomas> In-Reply-To: <20200414194426.1640704-3-dmitry.kozliuk@gmail.com> References: <20200410164342.1194634-1-dmitry.kozliuk@gmail.com> <20200414194426.1640704-1-dmitry.kozliuk@gmail.com> <20200414194426.1640704-3-dmitry.kozliuk@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v3 02/10] eal/windows: do not expose private EAL facilities X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 14/04/2020 21:44, Dmitry Kozlyuk: > The goal of rte_os.h is to mitigate OS differences for EAL users. > In Windows EAL, rte_os.h did excessive things: > > 1. It included platform SDK headers (windows.h, etc). Those files are > huge, require specific inclusion order, and are generally unused by > the code including rte_os.h. Declarations from platform SDK may > break otherwise platform-independent code, e.g. min, max, ERROR. > > 2. It included pthread.h, which is clearly not always required. > > 3. It defined functions private to Windows EAL. > > Reorganize Windows EAL includes in the following way: > > 1. Create rte_windows.h to properly import Windows-specific facilities. > Primary users are bus drivers, tests, and external applications. > > 2. Remove platform SDK includes from rte_os.h to prevent breaking > otherwise portable code by including rte_os.h on Windows. > Copy necessary definitions to avoid including those headers. > > 3. Remove pthread.h include from rte_os.h. > > 4. Move declarations private to Windows EAL into eal_windows.h. > > Fixes: 428eb983f5f7 ("eal: add OS specific header file") > > Signed-off-by: Dmitry Kozlyuk Applied as a separate patch because it is needed for a patch fixing compilation on Windows.