[dpdk-dev] [PATCH] vhost/crypto: fix bracket

[dpdk-dev] [PATCH] vhost/crypto: fix bracket

[Fan Zhang]

Coverity issue: 233232
Coverity issue: 233237
Fixes: 3bb595ecd682 ("vhost/crypto: add request handler")

Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
---
 lib/librte_vhost/vhost_crypto.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/lib/librte_vhost/vhost_crypto.c b/lib/librte_vhost/vhost_crypto.c
index c38eb3bb5..a3bce6379 100644
--- a/lib/librte_vhost/vhost_crypto.c
+++ b/lib/librte_vhost/vhost_crypto.c
@@ -675,8 +675,7 @@ prepare_sym_cipher_op(struct vhost_crypto *vcrypto, struct rte_crypto_op *op,
 			goto error_exit;
 		}
 		if (unlikely(copy_data(rte_pktmbuf_mtod(m_src, uint8_t *), head,
-				mem, &desc, cipher->para.src_data_len))
-				< 0) {
+				mem, &desc, cipher->para.src_data_len) < 0)) {
 			ret = VIRTIO_CRYPTO_BADMSG;
 			goto error_exit;
 		}
-- 
2.13.6

Re: [dpdk-dev] [PATCH] vhost/crypto: fix bracket

[Maxime Coquelin]

On 04/30/2018 12:36 PM, Fan Zhang wrote:
> Coverity issue: 233232
> Coverity issue: 233237
> Fixes: 3bb595ecd682 ("vhost/crypto: add request handler")
> 
> Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
> ---
>   lib/librte_vhost/vhost_crypto.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
> 

Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>

Thanks,
Maxime

Re: [dpdk-dev] [PATCH] vhost/crypto: fix bracket

[Thomas Monjalon]

30/04/2018 12:36, Fan Zhang:
> Coverity issue: 233232
> Coverity issue: 233237
> Fixes: 3bb595ecd682 ("vhost/crypto: add request handler")
> 
> Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>

2 comments, Fan:

1/ I think it the v2 of a previous commit.
Please update the patchwork status (superseded),
use -v option for revision numbering,
and add a changelog.

2/ The title must give the scope of the change,
or give an idea of the impact of the patch.
Example:
	fix symmetric ciphering
The root cause (bracket location) is better in the
commit message than the title.

Thanks

Re: [dpdk-dev] [PATCH] vhost/crypto: fix bracket

[Maxime Coquelin]

On 04/30/2018 12:36 PM, Fan Zhang wrote:
> Coverity issue: 233232
> Coverity issue: 233237
> Fixes: 3bb595ecd682 ("vhost/crypto: add request handler")
> 
> Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
> ---
>   lib/librte_vhost/vhost_crypto.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
> 

Applied to dpdk-next-virtio/master with changes suggested by Thomas.

Thanks,
Maxime