From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 627151B221 for ; Mon, 9 Oct 2017 23:01:37 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id EA21C21391; Mon, 9 Oct 2017 17:01:36 -0400 (EDT) Received: from frontend2 ([10.202.2.161]) by compute1.internal (MEProxy); Mon, 09 Oct 2017 17:01:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=GfpAt7H9/1xDWBM NzI56hOZIbqrTl2OPcO+YHjCSZc0=; b=mSKjzccOPfNGcMOf/RALKKeP5FHLfHI WvK3TPRcbCYaSeJWvXYvFVGLZe+UREGeS6DhhIRzCVU0Ok5VrFSGxRC2/W46ZjED bNhFUhjAZ0XFWoz18fLnafFgOUwTbC2nyZkPAxLZYsSTeGox6PPtOxVvyCm1u+S1 kk690jyaYfU0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s= fm1; bh=GfpAt7H9/1xDWBMNzI56hOZIbqrTl2OPcO+YHjCSZc0=; b=izz1QUvq /kPO6bz3LL01xAzQb9NRHX32ToNsdTHuswvJEPKD323PTZXxYNHLx44CtisQVtBc Vj4gqSma4D/J1N5dV5f8jb398TIAH+o93QusbPEXss84X1GesS3fMHteyxjelGPD ibZARv+HXKmSPH3zq1jWsc4GHfkkD0pBJ5q2FkhKvL+FhxdRGmxrLH9T4d4Kh/ft RaTjnHyAjZouPVj0BqP9hy6v1sBQkhUkoWlGkiVNS1Oq7NFhVaLOBzFZ9F3IdnYo dBHh+n3+rK3vJQXKWY5Xf7oJlyAwlaLArjTNwAiB9Axiiv9RpMIN9nVXTpfjuCXd a2XSAW3gEPMccg== X-ME-Sender: X-Sasl-enc: 6+6ZK+XH8pDlcdU8lTZGF+Lyc2in0xPtRWiK+ps+rn5N 1507582896 Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 9F3D22494C; Mon, 9 Oct 2017 17:01:36 -0400 (EDT) From: Thomas Monjalon To: Xueming Li Cc: dev@dpdk.org, Gaetan Rivet , Wiles Keith Date: Mon, 09 Oct 2017 23:01:35 +0200 Message-ID: <2483187.uH7VH6KlI1@xps> In-Reply-To: <20170824082310.87485-1-xuemingl@mellanox.com> References: <20170823140008.184627-1-xuemingl@mellanox.com> <20170824082310.87485-1-xuemingl@mellanox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2] eal: add config option to enable asserts X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 Oct 2017 21:01:37 -0000 24/08/2017 10:23, Xueming Li: > Currently, enabling assertion have to set CONFIG_RTE_LOG_LEVEL to > RTE_LOG_DEBUG. CONFIG_RTE_LOG_LEVEL is the default log level of control > path, RTE_LOG_DP_LEVEL is the log level of data path. It's a little bit > hard to understand literally that assertion is decided by control path > LOG_LEVEL, especially assertion used on data path. > > On the other hand, DPDK need an assertion enabling switch w/o impacting > log output level, assuming "--log-level" not specified. > > Assertion is an important API to balance DPDK high performance and > robustness. To promote assertion usage, it's valuable to unhide > assertion out of COFNIG_RTE_LOG_LEVEL. > > In one word, log is log, assertion is assertion, debug is hot pot :) > > Rationale of this patch is to introduce an dedicate switch of > assertion: RTE_ENABLE_ASSERT > > Signed-off-by: Xueming Li > Acked-by: Gaetan Rivet Applied, thanks