DPDK patches and discussions
 help / color / mirror / Atom feed
From: Yongseok Koh <yskoh@mellanox.com>
To: Shahaf Shuler <shahafs@mellanox.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] net/mlx5: remove GRE inner IPv6 matching limitation
Date: Sun, 11 Nov 2018 11:32:03 +0000	[thread overview]
Message-ID: <24922204-F417-4D0B-9883-D8F85276E203@mellanox.com> (raw)
In-Reply-To: <20181111111526.161148-1-shahafs@mellanox.com>


> On Nov 11, 2018, at 3:15 AM, Shahaf Shuler <shahafs@mellanox.com> wrote:
> 
> Such limitation seems not to exist on:
> - MLNX_OFED_linux-4.5-0.3.0.0 (Beta)
> - MLNX_OFED_LINUX-4.4-2.0.7.0 (GA)
> - upstream kernel 4.19.0-rc7
> 
> Signed-off-by: Shahaf Shuler <shahafs@mellanox.com>
> ---
Acked-by: Yongseok Koh <yskoh@mellanox.com>
 
Thanks
> drivers/net/mlx5/mlx5_flow.c | 11 -----------
> 1 file changed, 11 deletions(-)
> 
> diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c
> index 8039664bc2..9c17627da7 100644
> --- a/drivers/net/mlx5/mlx5_flow.c
> +++ b/drivers/net/mlx5/mlx5_flow.c
> @@ -1240,17 +1240,6 @@ mlx5_flow_validate_item_ipv6(const struct rte_flow_item *item,
> 		return rte_flow_error_set(error, EINVAL,
> 					  RTE_FLOW_ERROR_TYPE_ITEM, item,
> 					  "L3 cannot follow an L4 layer.");
> -	/*
> -	 * IPv6 is not recognised by the NIC inside a GRE tunnel.
> -	 * Such support has to be disabled as the rule will be
> -	 * accepted.  Issue reproduced with Mellanox OFED 4.3-3.0.2.1 and
> -	 * Mellanox OFED 4.4-1.0.0.0.
> -	 */
> -	if (tunnel && item_flags & MLX5_FLOW_LAYER_GRE)
> -		return rte_flow_error_set(error, ENOTSUP,
> -					  RTE_FLOW_ERROR_TYPE_ITEM, item,
> -					  "IPv6 inside a GRE tunnel is"
> -					  " not recognised.");
> 	if (!mask)
> 		mask = &rte_flow_item_ipv6_mask;
> 	ret = mlx5_flow_item_acceptable(item, (const uint8_t *)mask,
> -- 
> 2.12.0
> 

  reply	other threads:[~2018-11-11 11:32 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-11 11:15 Shahaf Shuler
2018-11-11 11:32 ` Yongseok Koh [this message]
2018-11-11 12:42   ` Shahaf Shuler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=24922204-F417-4D0B-9883-D8F85276E203@mellanox.com \
    --to=yskoh@mellanox.com \
    --cc=dev@dpdk.org \
    --cc=shahafs@mellanox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).