From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id D1ED5A034F; Wed, 6 May 2020 16:22:48 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A104C1DA03; Wed, 6 May 2020 16:22:45 +0200 (CEST) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id F0C671D9FF for ; Wed, 6 May 2020 16:22:43 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 9F2C05C00E3; Wed, 6 May 2020 10:22:43 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute7.internal (MEProxy); Wed, 06 May 2020 10:22:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= CwVkux5ab3lzfCAbALMigJxVDGrZZnVsYJBp1NcCJoE=; b=HU0ORGA4nkVQMiyD ZFOgHcj1EDY0Kl3yWBR/VHi6Myz6i7QK0fCXeSXZNV7X5lnXt2C1DNnoPFDVbbI6 chjjKYx2c+FcW2ql2XYTUqLAgDbO+kuXvQRrvz7yrXHtOcP6RWXXdetcXAwGdZD6 EB0jLeN0EKK0r9Y9OWoNfpcKzCkuP4ccOOXo6W9QG4lOa6suagqTZp/zMrnFpHDg kZrfcfA+DCcjl7Rkyv4ZpYeBz7h05A1X5nYGpzT9NXT67y/cFaLi/y8U7F4jAy8x +Qed/KNsvVfnuGFDGNTFuXb747CydDXkovYjz9+CCbMumyR3vMny6FGLasJ6Oosf DnU5jg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=CwVkux5ab3lzfCAbALMigJxVDGrZZnVsYJBp1NcCJ oE=; b=x6yTrTuE1iwXeEagRePDvNRGe2y2TFHDLfMHKI8Ws9+HhMB/u27pc4/fl lJumj9F60ZQ6PmgrcMUyvLSGzm15s4rFxpNodI7vXqNG663/Q6yru0mBD5PVSxbl K0owrvbFcyCZ4mtqKOWLvfkfphhoL7nPqHuOeYWHqISukN7UlxIUdDeY/TJLw6F5 xDFj6pfsoFIu5/fYoSpSRCgTIikCxX8v3T73kYqZWw+lF+LvVnXhVCPlnRPXDU9F UjjSumf2eU8wAMOblS54eUq4XltkY3iTUoo7lI21QsBNa2wrMAh17x36OXfuFURS BpraYCTa3z5ohMj5S+f68HUzCbV4A== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrjeekgdejfecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdejueei iedvffegheenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuih iivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhho nhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 6CE363280065; Wed, 6 May 2020 10:22:42 -0400 (EDT) From: Thomas Monjalon To: David Marchand , Ophir Munk , Ray Kinsella Cc: dev , Raslan Darawsheh , Matan Azrad , Neil Horman Date: Wed, 06 May 2020 16:22:41 +0200 Message-ID: <2495289.KRxA6XjA2N@thomas> In-Reply-To: References: <20200505112057.20901-1-ophirmu@mellanox.com> <2351387.Sgy9Pd6rRy@thomas> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v1 1/3] devtools: create internal ignore file for libabigail X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 06/05/2020 16:15, Ray Kinsella: > > On 06/05/2020 13:52, Thomas Monjalon wrote: > > 06/05/2020 14:42, David Marchand: > >> On Wed, May 6, 2020 at 2:27 PM Thomas Monjalon wrote: > >>> > >>> 05/05/2020 16:53, David Marchand: > >>>> On Tue, May 5, 2020 at 1:21 PM Ophir Munk wrote: > >>>>> +; These functions were moved from stable to internal. > >>>>> +; This is a temporary exception till DPDK 20.11. > >>>> > >>>> This is not until 20.11 if we merge this patch now. > >>>> It is only when comparing 20.02 to 20.05. > >>>> After this, symbols will be marked INTERNAL and will be skipped by the > >>>> generic rule, so we can remove this exception in 20.08-rc0. > >>> > >>> I think we need to keep this rule until 20.11, > >>> because we want to ignore symbols which were in 19.11 and 20.02, > >>> and removed (as internal) in 20.05. > >> > >> Those symbols were exported in 20.02. > > > > Right, no issue when comparing with 19.11. > > Right, which also makes it different to the Traffic Manager issue. > As these symbols where never in v20 - 19.11, they won't be missed. > We never had a commitment to maintain them. > > If there were in v20, the situation might be considered differently. > > > > >> Before this, they were internal to mlx5 net driver. > >> > >> > >>> > >>> If we remove this rule in 20.08, and comparing with 19.11, > >>> the tool will complain about removed symbols, isn't it? > >> > >> If we remove the rule in 20.08 and compare to _20.02_ then yes, we > >> would get an issue. > >> I was only thinking of comparing 20.08 with 20.05. > >> > >> We can keep this until 20.11 if you think it is safer. > > > > Yes I think we must make sure any comparison can be done during > > compatibility lifetime. > > As David said, 20.08 _should_ be being compared to 20.05 by the CI. > So it should be find to drop the rule then. "should", but users "could" do something else ;-) > However > It might make easier though to let libabigail.ignore accumulate these kind of > suppressions between major releases / lts (v20 -> v21), and the completely > reset, and start over. Yes it's simpler and safer.