From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f48.google.com (mail-wm0-f48.google.com [74.125.82.48]) by dpdk.org (Postfix) with ESMTP id B48F6957F for ; Wed, 27 Jan 2016 10:20:45 +0100 (CET) Received: by mail-wm0-f48.google.com with SMTP id r129so136892495wmr.0 for ; Wed, 27 Jan 2016 01:20:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding :content-type; bh=8bCC6retOQhxp2g5bB1ojWMwoCSy1JQfWZmdPEQ9pJE=; b=Sn+10nJHLkdqkPIuRZiX2yJBS9JgM9HzOpsgjYbuNWAVTITwDn/jT6/4bCZYNXk0u+ vmDTBMmPJfGRiTQ4hexZ45vIfqp330C93kG+1Hy459ZSV0x7rINJwxiIv1JLI4gODlf+ CKX2ARK2w4gr62IrTB2Zr4ikAtGkW/FJByfHRiKAQXeL13ClLOUVROyGEkw+1iDPLETd Fwwb+v1RMV5isfw1+lZBsQvd5Szr04B43MT0NSDM+evBMSx13aFbW3k9FlEpQE5nvqm/ +p8nvW2BhAcYwjWI8xE/mnjFZ2xCk5t18g4Oz9lAzTbW/nP7LrBgMCPQCn8GAYCVj/4f Ppqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=8bCC6retOQhxp2g5bB1ojWMwoCSy1JQfWZmdPEQ9pJE=; b=RPeRBk8WjNNyHZ00bwfpngD7aNPWOQlYb9gT1Or/wx7rfkNgmYqMIlLzaSklC/Dr8C xkq0O07Oc+QYjrhOfdt+Kn2RRfMgmC8/X2Eg7QxJv2xdFAhUjcV8c5rA9jjPW5b4pbIe C6XMqNtehkKQmaN3T0MhiEaM5o9omfkaO5+zizDM+BaeNhnvGkhU90Kd5DDQemHxUYMV cKRJYGuq0F5NGUxu1hAzu4E1g3WT49G+xThhkIL9Pj6p2wyi8PKxo+kcWbafWk+3GOhb drUjtsvGdiN+/N6ETkJCmgYV3hU72yG3oEFlbRoeTmMu0WoVzko8lo/wdnQAFghzXsDf j0FA== X-Gm-Message-State: AG10YORgDwAgCY5tc7VgM3+dtAUM8KY/NnFeEKU3GKI1A+3Jsw8BHFQ9yd1QWLYB1f1owFi2 X-Received: by 10.28.5.213 with SMTP id 204mr27990046wmf.20.1453886445569; Wed, 27 Jan 2016 01:20:45 -0800 (PST) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by smtp.gmail.com with ESMTPSA id xx3sm5200164wjc.32.2016.01.27.01.20.44 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 27 Jan 2016 01:20:44 -0800 (PST) From: Thomas Monjalon To: Jingjing Wu , john.mcnamara@intel.com Date: Wed, 27 Jan 2016 10:19:36 +0100 Message-ID: <2497810.HTMk7hhgUj@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <1453883856-31246-1-git-send-email-jingjing.wu@intel.com> References: <1453883856-31246-1-git-send-email-jingjing.wu@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] ethdev: fix byte order inconsistence between fdir flow and mask X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 Jan 2016 09:20:45 -0000 2016-01-27 16:37, Jingjing Wu: > Fixed issue of byte order in ethdev library that the structure > for setting fdir's mask and flow entry is inconsist and made > inputs of mask be in big endian. Please be more precise. Which one is big endian? Wasn't it tested before? > fixes: 76c6f89e80d4 ("ixgbe: support new flow director masks") > 2d4c1a9ea2ac ("ethdev: add new flow director masks") Please put Fixes: on the two lines. > --- a/doc/guides/rel_notes/release_2_3.rst > +++ b/doc/guides/rel_notes/release_2_3.rst > @@ -19,6 +19,10 @@ Drivers > Libraries > ~~~~~~~~~ > > +* ** fix byte order inconsistence between fdir flow and mask ** > + > + Fixed issue in ethdev library that the structure for setting > + fdir's mask and flow entry is inconsist in byte order. John, comment on release notes formatting? It's important to have the first items well formatted. > @@ -39,6 +43,8 @@ API Changes > ABI Changes > ----------- > > +* The fields in The ethdev structures ``rte_eth_fdir_masks`` were > + changed to be in big endian. Please take care of uppercase typo here. > - /* write all the same so that UDP, TCP and SCTP use the same mask */ > + /* write all the same so that UDP, TCP and SCTP use the same mask > + * (little-endian) > + */ Spacing typo here. Sorry for the nits ;) > - uint8_t mac_addr_byte_mask; /** Per byte MAC address mask */ > + uint8_t mac_addr_byte_mask; /** Bit mask for associated byte */ > uint32_t tunnel_id_mask; /** tunnel ID mask */ > - uint8_t tunnel_type_mask; > + uint8_t tunnel_type_mask; /**< 1 - Match tunnel type, > + 0 - Ignore tunnel type. */ These changes seem unrelated with the patch. It's good to improve doc of this API but it's maybe not enough. Example: uint8_t mac_addr_byte_mask; /** Bit mask for associated byte */ Are we sure everybody understand how to fill it?