From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f172.google.com (mail-wi0-f172.google.com [209.85.212.172]) by dpdk.org (Postfix) with ESMTP id 8F5AEB5BE for ; Fri, 20 Feb 2015 12:26:48 +0100 (CET) Received: by mail-wi0-f172.google.com with SMTP id l15so2243056wiw.5 for ; Fri, 20 Feb 2015 03:26:48 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=H8jwvIRKwozQCMieqGCLynfoBO/DH4dP/l2TyGCSU7U=; b=B9MJu3q7uvFjywx03CmI+x/Q1Q1NVwcyd40F3Ld7p1WbF6jtJ0qWVHf+okO9Sv7ZyX a00ttxuCDAkS4A/AvYksbs5qzEn5JP3Wyw63mVudDqIV0t3pDQxPUgAHjCqeNS4QJmHK ato45oE0O5UFQsSna2KIAmp0qchxGubrMCLiYTXqkO4jaDuy5bc9lR+vPCk4WH/gjOa7 Wnvzqzn2Yh6mSGO+yzaofcwwuTBlZy60ccfOEpcGMXwbV5qrv8gEpFNXx6TX+Sdm5dMj lLmRzB3w2AoeKuEnezy5wEa9ZTt+tPF9q3MCBn5HYTm5/e9bmNhwH2u+ft+FaCioagVw 3hdA== X-Gm-Message-State: ALoCoQlMLcNZRj9Lr1s6id9x6mkh+tIfFgo4CShAy0dXbiIdgLU4AnwwEuSD/CMMklhBGP2J7/bY X-Received: by 10.180.21.210 with SMTP id x18mr22918307wie.78.1424431608404; Fri, 20 Feb 2015 03:26:48 -0800 (PST) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id ha5sm1978552wib.1.2015.02.20.03.26.46 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 20 Feb 2015 03:26:47 -0800 (PST) From: Thomas Monjalon To: Stefan Puiu Date: Fri, 20 Feb 2015 12:26:18 +0100 Message-ID: <2499656.ale3rhT9Ha@xps13> Organization: 6WIND User-Agent: KMail/4.14.4 (Linux/3.18.4-1-ARCH; KDE/4.14.4; x86_64; ; ) In-Reply-To: <1424424952-16885-1-git-send-email-stefan.puiu@gmail.com> References: <1424424952-16885-1-git-send-email-stefan.puiu@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] rte_pci.h: Fix C++11 compilation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Feb 2015 11:26:48 -0000 Hi Stefan, Thanks for improving DPDK for C++ usage. I'm a bit lost because that's the fourth time you send the same patch (without versioning): http://dpdk.org/dev/patchwork/patch/3140/ (this one had some comments you didn't address) http://dpdk.org/dev/patchwork/patch/3517/ (is it different from the first one?) http://dpdk.org/dev/patchwork/patch/3518/ (this one was wrongly formatted but authored with your ixiacom address) http://dpdk.org/dev/patchwork/patch/3537/ (it is different from the first one?) Please check http://dpdk.org/dev#send for versioning and set the old versions to "superseded" in patchwork. Thanks 2015-02-20 11:35, Stefan Puiu: > In C++11 concatenated string literals need to have a > space in between. Found with clang++-3.4, IIRC g++-4.8 also complains about this. > > Sample error message: > dpdk/include/rte_pci.h:96:26: error: invalid suffix on literal; C++11 requires a space between literal and identifier [-Wreserved-user-defined-literal] > > Signed-off-by: Stefan Puiu > --- > lib/librte_eal/common/include/rte_pci.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/lib/librte_eal/common/include/rte_pci.h b/lib/librte_eal/common/include/rte_pci.h > index 66ed793..12ae5a7 100644 > --- a/lib/librte_eal/common/include/rte_pci.h > +++ b/lib/librte_eal/common/include/rte_pci.h > @@ -93,10 +93,10 @@ extern struct pci_device_list pci_device_list; /**< Global list of PCI devices. > #define SYSFS_PCI_DEVICES "/sys/bus/pci/devices" > > /** Formatting string for PCI device identifier: Ex: 0000:00:01.0 */ > -#define PCI_PRI_FMT "%.4"PRIx16":%.2"PRIx8":%.2"PRIx8".%"PRIx8 > +#define PCI_PRI_FMT "%.4" PRIx16 ":%.2" PRIx8 ":%.2" PRIx8 ".%" PRIx8 > > /** Short formatting string, without domain, for PCI device: Ex: 00:01.0 */ > -#define PCI_SHORT_PRI_FMT "%.2"PRIx8":%.2"PRIx8".%"PRIx8 > +#define PCI_SHORT_PRI_FMT "%.2" PRIx8 ":%.2" PRIx8 ".%" PRIx8 > > /** Nb. of values in PCI device identifier format string. */ > #define PCI_FMT_NVAL 4 >