DPDK patches and discussions
 help / color / mirror / Atom feed
From: alloc <chunguang.yang@windriver.com>
To: <dev@dpdk.org>
Cc: Mark Asselstine <mark.asselstine@windriver.com>,
	"Wang, Weiwei" <Weiwei.Wang@windriver.com>
Subject: [dpdk-dev] [PATCH] tools/dpdkdevbind.py: remove call to lower case for mod path
Date: Fri, 25 Nov 2016 11:16:56 +0800	[thread overview]
Message-ID: <24c64816-8084-b5fd-0b10-3db3143500ec@windriver.com> (raw)

If the module path has upper case chars, the dpdk-devbind.py script will
crunch them to lower case.  This will result in the script never
finding a module.

Port patch to dpdk-1.7.0

dpdk_nic_bind.py has been renamed to dpdk-devbind.py in 16.11, so
just change file name.
Signed-off-by: Paul Barrette <paul.barrette@windriver.com>
Signed-off-by: Pengyu Ma <pengyu.ma@windriver.com>
Signed-off-by: chunguang yang <chunguang.yang@windriver.com>
---
  tools/dpdk-devbind.py | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/dpdk-devbind.py b/tools/dpdk-devbind.py
index f1d374d..d66d68c 100755
--- a/tools/dpdk-devbind.py
+++ b/tools/dpdk-devbind.py
@@ -141,7 +141,7 @@ def find_module(mod):
      # check using depmod
      try:
          depmod_out = check_output(["modinfo", "-n", mod],
-                                  stderr=subprocess.STDOUT).lower()
+                                  stderr=subprocess.STDOUT)
          if "error" not in depmod_out:
              path = depmod_out.strip()
              if exists(path):
-- 
2.9.3

             reply	other threads:[~2016-11-25  3:16 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-25  3:16 alloc [this message]
2017-04-28  9:38 ` Thomas Monjalon
2017-05-01 15:24   ` Mark Asselstine
2017-05-01 15:33     ` Mark Asselstine
2017-05-01 16:29       ` Thomas Monjalon
2017-05-01 17:30         ` Mark Asselstine
  -- strict thread matches above, loose matches on Subject: below --
2016-11-25  3:10 alloc

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=24c64816-8084-b5fd-0b10-3db3143500ec@windriver.com \
    --to=chunguang.yang@windriver.com \
    --cc=Weiwei.Wang@windriver.com \
    --cc=dev@dpdk.org \
    --cc=mark.asselstine@windriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).