From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 29EBDA056D; Thu, 12 Mar 2020 16:15:17 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 246641BFBF; Thu, 12 Mar 2020 16:15:16 +0100 (CET) Received: from us-smtp-delivery-1.mimecast.com (us-smtp-1.mimecast.com [205.139.110.61]) by dpdk.org (Postfix) with ESMTP id B89622BE6 for ; Thu, 12 Mar 2020 16:15:14 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1584026114; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=e1aV+JqGGVJ3d1gRG4T5XqI4OjLn1224QVlfotS+MLA=; b=d0h9JLJ4hhuUw+eIlwrdQ0WGy/2gPsUOF/ozQJX1EI5XNk5fXzuzYkfGZD3BBFZA4o+HIn 3/svvsXffLSylynlV40A7qbcTRN0jIpeYYcFuFn6P6zULSq7gLvg0wx1ystfJw+J15cnFN GR5xkDrj1Iu9j/YWXPwzHMp/2ie/uic= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-280-KXRGM_ykOXmN8KXMMdFDhw-1; Thu, 12 Mar 2020 11:15:12 -0400 X-MC-Unique: KXRGM_ykOXmN8KXMMdFDhw-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id E3EFF1005514; Thu, 12 Mar 2020 15:15:10 +0000 (UTC) Received: from [10.33.36.116] (unknown [10.33.36.116]) by smtp.corp.redhat.com (Postfix) with ESMTP id 29DED60C88; Thu, 12 Mar 2020 15:15:07 +0000 (UTC) To: Ferruh Yigit , dev@dpdk.org Cc: stable@dpdk.org, allain.legacy@windriver.com, Steven Webster , Matt Peters , "Kilheeney, Louise" References: <20200220093744.13925-1-ktraynor@redhat.com> <20200311113300.32487-1-ktraynor@redhat.com> <1e853b9f-fd91-42ef-dc0f-d834e510c6ef@intel.com> <9642a227-11db-8bb6-77cf-dca3463b4b9d@intel.com> From: Kevin Traynor Autocrypt: addr=ktraynor@redhat.com; keydata= mQINBF2J2awBEADUEPNhgNI+nJNgiTAUcw4YIgVXEoHlsNPyyzG1BEXkWXALy0Y3fNTiw6+r ltWDkF9jzL9kfkecgQ67itGfk1OaBXgSGKuw1PUpxAwX2Bi76LAR6M5OsyGM9TSVVQwARalz hMwRBIZPzPc7or6Pw7jAOJ8SQGJ1Zlp1YJCjrvpe87V1tH/LY8Wnxn/EuoseFmWILAQZAtYS tGjcrAgYn3SPMLR1B0BP5bTBY06vWQjiufH8drenfDnMJAzuBdG1mqjnTqCjULZ3Hunv4xqZ aMnkvL/K5Tj1c12Oe4930EE53LrXIBUltRg5mBudSWHnC7twjH0082HH9f963Z/2UI63SFIT iUvRvAzJYytgy7XnWLQ0+goZBADKYfolOuC0H8VgCaux8u8KFF28Dy+N6TV2KI58jTlyg1Zu l7QwykZpnOkJFiy37Gfbu3YEOzO72cP/S7/A+zvuqkxi63jyEkd+FY99vLt/HN2MUZwRmKDw UPbLkmrs8WU01/POVsqDcfvz7vu2St8hqqTiSIdQGS2zyTKB2/DvPSM3jws3udkIYSuhn+X4 QBiV6lkVZ7DSE6a065gnAauAql+b32Eymy+xnG5jCt1tR+0Cp2VZYCR9OU2gmomUKBDoX/He pSgED01CqYPNjN+TddirwmQX7ep4DtXc8FWvv2g/pq9WZFQk2QARAQABtCNLZXZpbiBUcmF5 bm9yIDxrdHJheW5vckByZWRoYXQuY29tPokCTgQTAQgAOBYhBAoiOaH51tHF7VYtEI9CINER a+yJBQJdidmsAhsDBQsJCAcCBhUKCQgLAgQWAgMBAh4BAheAAAoJEI9CINERa+yJoxIP/3VF 2TIgW4ckxhRFCvFu/606bnvCPie88ake4uWVWMAWwcMc4fKEltRWRCpkSVOwgqoMHnyHxK5r kOKzx2CLJMX5TgTMfKzPuaBDHngHLUzl2DStpBzrod0cVg5TShdmmfjY61uxRJKz+DlSkwgJ riADdVF5PPosQXTkKSGf2ombpTGpx/pue9ocjnr3x4SDpRLlnooM6Jf/3Y3Ib4jX6HPEyWuY b+owIIk9y2nRRGPQ6jbqAhsrXd9V+77UL0QuGWloMuKMZFbNg8hbu7X5aFijAbfxj4YUgojS ba7gfGZQan8h32A9KGQWrmsCBc3j2GqEPsX0r05X7cn7WL6IOPgQJ5EiQ7PlazQYVLrvZg9B n0GKK0k6895mLG0ZZ5v/qajOPF52etSmvFD1WUPb4OqaHqGA9ZtMpaKFRt7Y6rpXqKNU1xzW F5KjbTPtTb9WF3An8dciVv+AYUI7totkZYkWvQtgss8lfaX3NKUvXLVxqK0z3dQyr7rF/tYz PneTKypSksjCgaEBLSrsRmM5zKfe7tSNF/fDntfIq/029Jtcw29TcWEP57peNu6TtejewQD9 sTI+oqiXvW2D5l7LNUDYG8eMJp2oT7I0ZSBRvwcbmjH0DtN/bXCCFfCvk8Yic68F3tV1ctix wQARVKDBhT30uCxycRWojCYqTgNJJS71uQINBF2J2awBEADP57PR2IpSYBeNSrsAjeIcsahE N4SQP2C4s50S8QEWAUhqMRI7WNv5cfeef0nDvcl1IUA6oz5SokbcsbMa+mRgaNF4N5KikWTO LPYxq2YVJoXwJ+tKmNzyOLFUIfFJ4NBJZple5dTfWzD00Dbb19Mri1hy1mWMqNTPGBee1+hw Qcp6n3mmGECvajs8G5A7NyXbwL8ihN7HX9D01ucD62b4G03yKe2g/hvKgcdUVmhCldJlF27I 2fSR9tDxH9pZqRODY4rjbFZEey/vWKXqjE+DQ8AtMSEaDfFe5D+i4Aw6erWQ3Wr+DwZt1/7G dIAElGA/q90T1ENVwJX9y7fsQssawKYYdDqURHCl5JuDXI+VXUypExipUUT5SPycMmbLsx0D iKEqPPDQWKxkIDVKqj2+EhamSuJznZUwBLJKn0h4zrIWiXWUy07lRwtVuhaDXhF3GfW+5W/x wAg7Qg3w00ASsb/XTHBIhMnenKDfS7ihtQA8SacwX8ySdxb+15XPyiplM979qBQ0mhnilulm MIJzEf/JxoYR5huuj4f1PFqqrsP06Dl+YGB7dQZp3IKggS5c3/TAynARRg9N89UsDXNtp7X0 tgIPFF5k6fnHE0J5O64GYHeTqN/1aE6dAEOV9WrGzQAJxU9ipikb8jKAWXzLewRIKGmoPcRZ WdB0NmIjmQARAQABiQI2BBgBCAAgFiEECiI5ofnW0cXtVi0Qj0Ig0RFr7IkFAl2J2awCGwwA CgkQj0Ig0RFr7IkkORAAl/NbX93WK5MEoRw7/DaPTo/Lo6Pj1XMeSqGyACigHK/452UDvlEH NjNJMzYYrNIjMtEmN9VVCfjT38CSca7mpGQVwchc0mC7QSPAETLCS+UacVf/Kwxz5FfkEUUw UT7A+uyVOIgW3d9ldlRzkHA2czonSSgTQU+i2g6DM4ha+BuQb4byAXH6HQHt/Zh1J64z0ohH v6iGsCzCY/sMWF8+LEGSnzMGRCLiiwSF0vJBHbzWK68fANaF4gBV0Z/+6tQRFN7YMhj/INmk qgvHj1ZzHFNtirjMGPRxoZs51YoLQM/aBPxKrnmXThx1ufH+0L6sGmFTugiDt0XSEkC5reH7 a+VhQ1VTFFQrClA8NmDSPzFeuhru4ryaaDHO+uEB16cNHxHrQtlP/2hts2JM5lwkZRWJ5A57 h8eDEIK5be47T85NVHfuTaboNRmgg1HygVejhGUtt69u/0MVRg/roUTa0FyEbNsvz4qAecyW yWzMcVrcGJDQLC9JLKEpoyUF6gdTKaiDL2Vao4+XRIA3Y57b6MO35a3HuzAv7+i5Z0mnDEJO XxXqTOmKYpMIGexzM/PtuA0712sT1abG9tAJ17ao/B7cqMW5IkKkalemFbWfI2unns4Papvo tk9igVqyp6EJDU98z5TJioCVojwK2laDaoIjTJk9YYv3iwCsqPd5feU= Message-ID: <24e2ec05-de5d-3251-ac63-f344ec09f44e@redhat.com> Date: Thu, 12 Mar 2020 15:15:06 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <9642a227-11db-8bb6-77cf-dca3463b4b9d@intel.com> Content-Language: en-US X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH v2 1/2] net/avp: fix gcc 10 maybe-uninitialized warning X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 12/03/2020 14:31, Ferruh Yigit wrote: > On 3/12/2020 2:18 PM, Kevin Traynor wrote: >> On 12/03/2020 13:25, Ferruh Yigit wrote: >>> On 3/11/2020 11:32 AM, Kevin Traynor wrote: >>>> gcc 10.0.1 reports: >>>> >>>> ../drivers/net/avp/avp_ethdev.c: In function =E2=80=98avp_xmit_scatter= ed_pkts=E2=80=99: >>>> ../drivers/net/avp/avp_ethdev.c:1791:24: >>>> warning: =E2=80=98avp_bufs[count]=E2=80=99 may be used uninitialized i= n this function [-Wmaybe-uninitialized] >>>> 1791 | tx_bufs[i] =3D avp_bufs[count]; >>>> | ~~~~~~~~^~~~~~~ >>>> ../drivers/net/avp/avp_ethdev.c:1791:24: >>>> warning: =E2=80=98avp_bufs[count]=E2=80=99 may be used uninitialized i= n this function [-Wmaybe-uninitialized] >>>> >>>> Fix by intializing the array. >>>> >>>> Fixes: 295abce2d25b ("net/avp: add packet transmit functions") >>>> Cc: stable@dpdk.org >>>> >>>> Signed-off-by: Kevin Traynor >>>> --- >>>> v2: no change >>>> >>>> note, commit log violates line length but I didn't want to split warni= ng msg. >>>> >>>> Cc: allain.legacy@windriver.com >>>> Cc: Steven Webster >>>> Cc: Matt Peters >>>> --- >>>> drivers/net/avp/avp_ethdev.c | 2 +- >>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>> >>>> diff --git a/drivers/net/avp/avp_ethdev.c b/drivers/net/avp/avp_ethdev= .c >>>> index cd747b6be..1abe96ce5 100644 >>>> --- a/drivers/net/avp/avp_ethdev.c >>>> +++ b/drivers/net/avp/avp_ethdev.c >>>> @@ -1695,5 +1695,5 @@ avp_xmit_scattered_pkts(void *tx_queue, >>>> { >>>> =09struct rte_avp_desc *avp_bufs[(AVP_MAX_TX_BURST * >>>> -=09=09=09=09 RTE_AVP_MAX_MBUF_SEGMENTS)]; >>>> +=09=09=09=09 RTE_AVP_MAX_MBUF_SEGMENTS)] =3D {}; >>>> =09struct avp_queue *txq =3D (struct avp_queue *)tx_queue; >>>> =09struct rte_avp_desc *tx_bufs[AVP_MAX_TX_BURST]; >>>> >>> >>> Isn't this a false positive, can there be any case 'avp_bufs[]' used >>> uninitialized? Or am I missing something. >>> >> >> I presume it's because it's not being initialized in the fn and there is >> some paths in fn's it's passed to that don't initialize it. Of course in >> practice with "normal" values this might not happen. >=20 > 'avp_fifo_get(alloc_q, (void **)&avp_bufs, segments);' initializes it, an= d I am > not just talking about 'normal' case, I don't see any case that 'avp_bufs= []' > used uninitialized, can you see any? >=20 Well, it's initialization there is dependent on not hitting the first return and the loop executing. >> >>> If this is false positive, does it worth to report to issue to gcc? >>> >> >=20