From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A8C48A0C47; Thu, 14 Oct 2021 14:09:08 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 928CD41219; Thu, 14 Oct 2021 14:09:08 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mails.dpdk.org (Postfix) with ESMTP id D3BEF40041 for ; Thu, 14 Oct 2021 14:09:06 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10136"; a="225119750" X-IronPort-AV: E=Sophos;i="5.85,372,1624345200"; d="scan'208";a="225119750" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Oct 2021 05:09:01 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,372,1624345200"; d="scan'208";a="442082462" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga006.jf.intel.com with ESMTP; 14 Oct 2021 05:09:00 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Thu, 14 Oct 2021 05:08:59 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Thu, 14 Oct 2021 05:08:59 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Thu, 14 Oct 2021 05:08:59 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.171) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Thu, 14 Oct 2021 05:08:59 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oYn981dz6OG9uFbf4lElBInHgvl773uuwEsB5BRMJUNWFvUiLxKMcybsMTjBmAtnay0p/2i3QRWgIk8Bjs0+oRlnCOrofPQA/XjjLXf93EvS4ZE7UTMoJvaz0w8QHTJHg4Vm64ODre+QM8qv9qhYk5PXtEJ5ywNugTWIVc48UqcDyPGdCRMbYXKCliHLI25qxFwb0kVqWus8MVe2dr/W2cY3s1K0gwUZDT26G583xYjulEYmMNuhJFddkPOGTZWSPx6GXxlz6Hp4JbUTX2pDELYDpdECxrMFn0Cqu4indjHlS6T+Nl7EM2hQ6/AW7xrZMkAnBibPkmzXCsZfigqzMA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=CwgMHeDGbRXlCykG3HRIO5onjK0dl22Sdthyt3ZF5uY=; b=HHu8NfHxJt4tYlZONgYFUFM2YX/JE/FKDM9GHJVg4zmJe/AXhEqabM6J7BBsJ/5Y5WbV1HF8eUsmiP5uFRlLLDqymfORjL2n8dx9eH8CMbag0Iyfs7I46eg9uJ0sT0J2pCZYEc5kTLxpArorkoC5uZDyt1hn0XJjbKpGwZIVm045oZOpMj4DsrRehtiByq54ve63KohHQgkMI4Ut+O6sOuo0HeCGjBsiOazk+E6UzKLk2Rxcx6Y3iPKUwnZxKMBKnfjh7qGEJyYFcKDKHmP+gW20jNqYTiSmzVOZQyDWDh232eH6sxD+4NwmipMEiQelAQji+3YzhkfNal87f83frw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CwgMHeDGbRXlCykG3HRIO5onjK0dl22Sdthyt3ZF5uY=; b=al8jEIehOtoQbKX+tv1r5KtpGn3kk1Qq8VzKWFskXoCEIrYX15OmRoXlh6DicGv6+xc448JNx4Xn3pVQbkbZPuXHhuSo1KRoW5zpYWOSH650nYsdj0Ihnj09R8yRjlk9qm/CRp4Hds7rctvRvty5S4vo+ohF6IME5EflhI43DNc= Authentication-Results: nvidia.com; dkim=none (message not signed) header.d=none;nvidia.com; dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by PH0PR11MB4838.namprd11.prod.outlook.com (2603:10b6:510:40::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.15; Thu, 14 Oct 2021 12:08:58 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd7d:29be:3342:632c]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd7d:29be:3342:632c%5]) with mapi id 15.20.4608.017; Thu, 14 Oct 2021 12:08:58 +0000 Message-ID: <24e43fd6-c726-85b7-8999-dd53d6087749@intel.com> Date: Thu, 14 Oct 2021 13:08:51 +0100 Content-Language: en-US To: Viacheslav Ovsiienko , CC: , , , , , References: <20210910141609.8410-1-viacheslavo@nvidia.com> <20211013184516.25338-1-viacheslavo@nvidia.com> <20211013184516.25338-2-viacheslavo@nvidia.com> From: Ferruh Yigit X-User: ferruhy In-Reply-To: <20211013184516.25338-2-viacheslavo@nvidia.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DU2PR04CA0003.eurprd04.prod.outlook.com (2603:10a6:10:3b::8) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 Received: from [192.168.0.206] (37.228.236.146) by DU2PR04CA0003.eurprd04.prod.outlook.com (2603:10a6:10:3b::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.16 via Frontend Transport; Thu, 14 Oct 2021 12:08:56 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d69d8c2f-7c2a-42e2-c146-08d98f0b66a9 X-MS-TrafficTypeDiagnostic: PH0PR11MB4838: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: uvIPgkar0S1CeB8aEegFZz4hDR3DRaeRvLcJtoQFL5c2a4aV0OrBocEeZLShE86rd8RT8q4GpS6gVzdtbJ/b4P4/0xoLKwqmqRdbUZRJGSs+yPFTvQFJ53zoMMd9Evupx/c5AYZLQq9dbnJ+yFr97aavMPfvPzR1o2gI4kb21llSTPnezRLKJwoOoPoXVDpUGkRuAH9HEfMNenZzEiQ0F5SS7Pw8KQB4gjR1/ebAvvn4cb1+JscESKLZZZ3GXORx7wOUlJQ6+5ZpHgFXe4ZdzkrCxRgcDwja+RtfVfkqkplovNiLIb5XnjB4WzFSF1pLCzFvOQAzq5LtHEB2EKfxyqJAJ9TP3NRsxXIBBLT9pZbIC9iPwA+bc6zKgq5Rfqd8W6gSQcODMRj1BO+ZaUs852Imx+05KgDjRKv5dwobU0QzeuXdujzw2mz9c8hJxn+eWwaALG9Yg9SfaI5dk0bz0POdHo7Q3hreIBuWT6rIQPR1go4etQA3Jd41gXYGju7YYwJE3MteMNvHu3V+r1qRCTSQ8g8lzhHMNiuPBZFQrNI+FjCyy0QFzHXIQonHGiOxPzFxLH3Z44T5aUiQyRDA5e7X2vqVxHQRJet2DYzPuLMEl731xUzeSP65euF3VrjX3xQ2tB9zKt8g3CEt/9cLZPwI6uwGLiqA4H3NOOgWsTinxwr6mlI2X8ZBwJfZuO9lUnvlwdgFbp9G6zINTkAdfA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(26005)(316002)(956004)(8676002)(31696002)(2906002)(36756003)(6666004)(31686004)(38100700002)(82960400001)(66476007)(16576012)(2616005)(53546011)(86362001)(8936002)(15650500001)(4326008)(66946007)(5660300002)(83380400001)(66556008)(508600001)(44832011)(186003)(6486002)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?M2ZiRjZEdzlFOVFHS0IwYjhydTJLOWozZnY3VHhkWDFxb3J2VXRMK0REQ3Zo?= =?utf-8?B?QndMdHo1WTJHQnQ2R3lhK2xGamVndlpKdDgyMzhqcTUxeHJIelQ4Vm80TzlV?= =?utf-8?B?MWFkbWc2Q2NNWmFuWHVtNEtxdzA4NjFMZjNpUEdyZkFRWldIYWdwM2dEa25r?= =?utf-8?B?cGNpeDNrdm4vYjI5WVpqVkZYQ2RrVzFQSVNzRjFBYklyQmpaUzVRVGhYRHlB?= =?utf-8?B?WmRTc2JrL0hBNktXR1Q2TDF5bnZIRTZRbVRSeWdieFArRis2ZnUwOUplZlFt?= =?utf-8?B?VkFTSGhCRnhyMUk3SFlQbGtsdnQwdHpZVFZ6dFo5WjFOWktnNFZtVGdVOURE?= =?utf-8?B?OHhMUHZkbDdtdVVQWVp2UDBuNDlHbnVqcXh4WlhLTjQyVzJEYjh4Qmg2eVpJ?= =?utf-8?B?NmpJQ2JlRjVyM0FUYVlNVEE3U0U2cFRYUmp5dzZrUEg3bU5ZK3RCUVdCL0xo?= =?utf-8?B?Y0htenlENVRjTU5GdFl0RGVMUmpLWTFXbGJSWFZaanpZN2VaSmo0YUF6OWll?= =?utf-8?B?OWJOdkgxOGdMMngzTDdQYTVrT1UrSVp1cDlubGh3d1k0ZnVzcmNSejZ4aVhw?= =?utf-8?B?ZWVDZzl1TDQ0UktKSktvWTBGRGFiVnExYVNJNnM2b2hTNmhDU0h2b1JCMFkv?= =?utf-8?B?eHc5aGwyNFcyN25LaklRNjBTelZRckpHbDY0NDJmSnpPUnNIWG9qRnN1TEcv?= =?utf-8?B?cEJ5eG52S2hqaW5JR3JYK0YzLytiUE45RGU4OXJZOUpvMzRtZjBrd0RjMlc0?= =?utf-8?B?VEtKbVBLSnZpTEZ2UUhzVFVEaEdKbVJuVEtjL0ozZW5ta1dVSXFQY25ETndO?= =?utf-8?B?QW9wWjBDajh6Zm9RT05BWVhjQmpmZ2thTE1VVFhFRTF1T1VURlhNUUllYUEr?= =?utf-8?B?L1lNTndzNFBzLzNWclFYUWhpL1ZDaXU3bjZ1VTVSbGk4TVZqOFYwRS9lSGZC?= =?utf-8?B?Y21IQWRnQnRrN0g5ZjlTbWUvZkVBZTdGdFMranVGUStBbzZGaFBrM2ZHZSsz?= =?utf-8?B?RFFpVWhiSzJsTlY2VnBTdWFYWHdaVmVPMURiUTVRTzVyTUlKL0RISXZ2WG1C?= =?utf-8?B?QWJvNnJpVWZ1MGxJWGNveUV4OWhSVFN4b2hPNkJnWms3TFNvdWhUVXR0QlRx?= =?utf-8?B?dzZuUElWdXFMOGJWUlJoZmdZaThBcXgxNUdtWGFSYXloRFZQdGpoZGpRZFRu?= =?utf-8?B?MWVuMHhVenVIcFdpOWlhNjlNS1VOZWhzZFNUaEhEZ20zbHJMeUVxams3N0s1?= =?utf-8?B?eEx5b253V2dMdkR2TjhHL1F5TmFCQUF3WUxPUjBnNjVTc1l3Szg1UjB1R3pI?= =?utf-8?B?RlRLaHZjcXphdi9mWlZQZEtDTWVkWENQZjE1SlZuQjVCeWg4Mm9zRHI4NC9Q?= =?utf-8?B?SUFTcDlRZE8zbnBwWXREbExKV1ZmZ3BLU01xbGQwclE2YTJCQVRtWVk0aVgr?= =?utf-8?B?TUNrVnF0cU5CWjJWRjZtdnlRM0hTRkx2dGZRVWg5YmlZWG8yRVViZzZBeGZP?= =?utf-8?B?b2p1Uys5TDVWSURSdnE3NXFPMDg1UUFaUGVZQ01idytqWHljOWk1SFFVTWJl?= =?utf-8?B?NlZyL3dGdS91Znc1cjZPTCtzUUZiYSszajJOMVcxekJCaFh4NDFvR0cwTDRG?= =?utf-8?B?TWZLNVUxL1p2eHFacVJRSWpPdWw5NDZtRytGZC8rd20ycnVHeFhEcmRFbjZy?= =?utf-8?B?TmJVUzk1ZGU5bE8veUlvWVhRUGo3RElaVlNpcHdIN251aW9hWUdQanJHZVMw?= =?utf-8?Q?aq0TTTH3qBIEwKwet6KRbtQmgbFQxMxh4jF84Zl?= X-MS-Exchange-CrossTenant-Network-Message-Id: d69d8c2f-7c2a-42e2-c146-08d98f0b66a9 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Oct 2021 12:08:58.2226 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: fsdU2F1VuKGN4LiDAKoWqPbbn8RFZyoVNNNu6D+oOUR3s1fLQuMwyDzgG35ba0Mf+2u6znxp/5La3ZdM3Pb1+A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4838 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v6 1/5] ethdev: update modify field flow action X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/13/2021 7:45 PM, Viacheslav Ovsiienko wrote: > The generic modify field flow action introduced in [1] has > some issues related to the immediate source operand: > > - immediate source can be presented either as an unsigned > 64-bit integer or pointer to data pattern in memory. > There was no explicit pointer field defined in the union. > > - the byte ordering for 64-bit integer was not specified. > Many fields have shorter lengths and byte ordering > is crucial. > > - how the bit offset is applied to the immediate source > field was not defined and documented. > > - 64-bit integer size is not enough to provide IPv6 > addresses. > > In order to cover the issues and exclude any ambiguities > the following is done: > > - introduce the explicit pointer field > in rte_flow_action_modify_data structure > > - replace the 64-bit unsigned integer with 16-byte array > > - update the modify field flow action documentation > > Appropriate deprecation notice has been removed. > > [1] commit 73b68f4c54a0 ("ethdev: introduce generic modify flow action") > > Fixes: 2ba49b5f3721 ("doc: announce change to ethdev modify action data") > Hi Viacheslav, The commit in the 'Fixes' line is the commit that announces the deprecation notice, sure this patch is not fixing it. I am removing the above 'Fixes' line. This patch is breaking the ABI and it can't be backported anyway, but the 'Fixes' line still can be useful for documentation purpose, so if there is valid fix commits please share them and I can squash them in next-net. > Signed-off-by: Viacheslav Ovsiienko > Acked-by: Ori Kam > Acked-by: Andrew Rybchenko