* [dpdk-dev] [PATCH] kni: define HAVE_VF_VLAN_PROTO for SLES12SP3 @ 2017-03-31 11:32 Nirmoy Das 2017-03-31 14:10 ` Ferruh Yigit 0 siblings, 1 reply; 3+ messages in thread From: Nirmoy Das @ 2017-03-31 11:32 UTC (permalink / raw) To: dev; +Cc: Nirmoy Das Add support for SLES12SP3, which uses kernel 4.4, but backported features from newer kernels. Signed-off-by: Nirmoy Das <ndas@suse.de> --- lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h b/lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h index 84826b26e..3d22d8e69 100644 --- a/lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h +++ b/lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h @@ -3929,8 +3929,10 @@ skb_set_hash(struct sk_buff *skb, __u32 hash, __always_unused int type) #define vlan_tx_tag_present skb_vlan_tag_present #endif -#if ( LINUX_VERSION_CODE >= KERNEL_VERSION(4,9,0) ) +#if (( LINUX_VERSION_CODE >= KERNEL_VERSION(4,9,0) ) \ + || (defined(CONFIG_SUSE_KERNEL) && \ + (LINUX_VERSION_CODE >= KERNEL_VERSION(4,4,57)))) #define HAVE_VF_VLAN_PROTO -#endif /* >= 4.9.0 */ +#endif /* >= 4.9.0, >= SLES12SP3 */ #endif /* _KCOMPAT_H_ */ -- 2.12.0 ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] kni: define HAVE_VF_VLAN_PROTO for SLES12SP3 2017-03-31 11:32 [dpdk-dev] [PATCH] kni: define HAVE_VF_VLAN_PROTO for SLES12SP3 Nirmoy Das @ 2017-03-31 14:10 ` Ferruh Yigit 2017-04-03 8:05 ` Nirmoy Das 0 siblings, 1 reply; 3+ messages in thread From: Ferruh Yigit @ 2017-03-31 14:10 UTC (permalink / raw) To: Nirmoy Das, dev On 3/31/2017 12:32 PM, Nirmoy Das wrote: > Add support for SLES12SP3, which uses kernel 4.4, > but backported features from newer kernels. > > Signed-off-by: Nirmoy Das <ndas@suse.de> > --- > lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h b/lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h > index 84826b26e..3d22d8e69 100644 > --- a/lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h > +++ b/lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h > @@ -3929,8 +3929,10 @@ skb_set_hash(struct sk_buff *skb, __u32 hash, __always_unused int type) > #define vlan_tx_tag_present skb_vlan_tag_present > #endif > > -#if ( LINUX_VERSION_CODE >= KERNEL_VERSION(4,9,0) ) > +#if (( LINUX_VERSION_CODE >= KERNEL_VERSION(4,9,0) ) \ > + || (defined(CONFIG_SUSE_KERNEL) && \ > + (LINUX_VERSION_CODE >= KERNEL_VERSION(4,4,57)))) > #define HAVE_VF_VLAN_PROTO > -#endif /* >= 4.9.0 */ > +#endif /* >= 4.9.0, >= SLES12SP3 */ To make condition simple, what about separating SUSE related check? There is already "#ifdef CONFIG_SUSE_KERNEL" check in line 699, which is mainly to set SLE_VERSION_CODE, but this check can be added end of that block, what do you think? Thanks, ferruh > > #endif /* _KCOMPAT_H_ */ > ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] kni: define HAVE_VF_VLAN_PROTO for SLES12SP3 2017-03-31 14:10 ` Ferruh Yigit @ 2017-04-03 8:05 ` Nirmoy Das 0 siblings, 0 replies; 3+ messages in thread From: Nirmoy Das @ 2017-04-03 8:05 UTC (permalink / raw) To: Ferruh Yigit, dev On 03/31/2017 04:10 PM, Ferruh Yigit wrote: > On 3/31/2017 12:32 PM, Nirmoy Das wrote: >> Add support for SLES12SP3, which uses kernel 4.4, >> but backported features from newer kernels. >> >> Signed-off-by: Nirmoy Das <ndas@suse.de> >> --- >> lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h | 6 ++++-- >> 1 file changed, 4 insertions(+), 2 deletions(-) >> >> diff --git a/lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h b/lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h >> index 84826b26e..3d22d8e69 100644 >> --- a/lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h >> +++ b/lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h >> @@ -3929,8 +3929,10 @@ skb_set_hash(struct sk_buff *skb, __u32 hash, __always_unused int type) >> #define vlan_tx_tag_present skb_vlan_tag_present >> #endif >> >> -#if ( LINUX_VERSION_CODE >= KERNEL_VERSION(4,9,0) ) >> +#if (( LINUX_VERSION_CODE >= KERNEL_VERSION(4,9,0) ) \ >> + || (defined(CONFIG_SUSE_KERNEL) && \ >> + (LINUX_VERSION_CODE >= KERNEL_VERSION(4,4,57)))) >> #define HAVE_VF_VLAN_PROTO >> -#endif /* >= 4.9.0 */ >> +#endif /* >= 4.9.0, >= SLES12SP3 */ > > To make condition simple, what about separating SUSE related check? > > There is already "#ifdef CONFIG_SUSE_KERNEL" check in line 699, which is > mainly to set SLE_VERSION_CODE, but this check can be added end of that > block, what do you think? > Thanks, looks like I missed that. I will come up with V2. > Thanks, > ferruh > >> >> #endif /* _KCOMPAT_H_ */ >> > Regards, Nirmoy -- SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Maxfeldstr. 5 D-90409 Nürnberg / Phone: +49-911-740 18-4 ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-04-03 8:05 UTC | newest] Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2017-03-31 11:32 [dpdk-dev] [PATCH] kni: define HAVE_VF_VLAN_PROTO for SLES12SP3 Nirmoy Das 2017-03-31 14:10 ` Ferruh Yigit 2017-04-03 8:05 ` Nirmoy Das
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).