From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wg0-f42.google.com (mail-wg0-f42.google.com [74.125.82.42]) by dpdk.org (Postfix) with ESMTP id 266DE1288 for ; Sun, 18 Jan 2015 23:24:36 +0100 (CET) Received: by mail-wg0-f42.google.com with SMTP id k14so28835879wgh.1 for ; Sun, 18 Jan 2015 14:24:36 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=3ahI0jRF0XHfTUwVajoBq/1aXPCxceAVbPPFEvEnoWI=; b=hZsDKdNFgNezZ4TpI04vV2v43WSqAgS966rQvf0n65BUho+tyYIeB/1qbAAGzQpFmx /PZ+XDIfzXiYDbyuXNvHia5EJcpd3YHDEJUP3OekKu7dqQE3G9msSkRoY87mATV3zkA5 eiGJEXWpQnxguHrDKQCjNoRAUXkL18J6LNChcN2ZHeFHNfXWoT4WA+x52yzYUmGfjmxT kxCmB6VR4xfPOszWD+ntYD9fNv9e/O7aLNvgpNrN/HRRmzWfE3EI1P/qu500y4kq1hgK gqKQcmSKkAmwo86t/YMXoATZZeGRTCHgb60oLzFYgH17IG++BGDNjVCIdgxZby75hItJ BkXg== X-Gm-Message-State: ALoCoQkVMqQfAZCwzNG+dUkJVpqgn1tZGRsLuzeMo2U4PgYZNr3KlZtMXbnQdMceOwetaV4hFEsE X-Received: by 10.194.7.103 with SMTP id i7mr12354954wja.53.1421619876007; Sun, 18 Jan 2015 14:24:36 -0800 (PST) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id dc1sm11881746wib.18.2015.01.18.14.24.34 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 18 Jan 2015 14:24:35 -0800 (PST) From: Thomas Monjalon To: Ouyang Changchun Date: Sun, 18 Jan 2015 23:24:12 +0100 Message-ID: <2500048.zNVo70YcKP@xps13> Organization: 6WIND User-Agent: KMail/4.14.3 (Linux/3.17.6-1-ARCH; KDE/4.14.3; x86_64; ; ) In-Reply-To: <1421042352-22399-1-git-send-email-changchun.ouyang@intel.com> References: <1420612355-6666-1-git-send-email-changchun.ouyang@intel.com> <1421042352-22399-1-git-send-email-changchun.ouyang@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v6 0/6] Enable VF RSS for Niantic X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 18 Jan 2015 22:24:36 -0000 > This patch enables VF RSS for Niantic, which allow each VF having at most 4 queues. > The actual queue number per VF depends on the total number of pool, which is > determined by the max number of VF at PF initialization stage and the number of > queue specified in config: > 1) If the max number of VF is in the range from 1 to 32, and the number of rxq is 4 > ('--rxq 4' in testpmd), then there is totally 32 pools(ETH_32_POOLS), and each VF > have 4 queues; > > 2)If the max number of VF is in the range from 33 to 64, and the number of rxq is 2 > ('--rxq 2' in testpmd), then there is totally 64 pools(ETH_64_POOLS), and each VF > have 2 queues; > > On host, to enable VF RSS functionality, rx mq mode should be set as ETH_MQ_RX_VMDQ_RSS > or ETH_MQ_RX_RSS mode, and SRIOV mode should be activated(max_vfs >= 1). > It also needs config VF RSS information like hash function, RSS key, RSS key length. > > The limitation for Niantic VF RSS is: > the hash and key are shared among PF and all VF, the RETA table with 128 entries are > also shared among PF and all VF. So it could not to provide a method to query the hash > and reta content per VF on guest, while, if possible, please query them on host(PF) for > the shared RETA information. This kind of information should go in a documentation. I think we should start new documentation for PMDs. What about a doc/drivers/ directory ? > changes in v6: > - refine codes and update message according to comments; > > changes in v5: > - Fix minor issue and some comments; > > changes in v4: > - Extract a function to remove embeded switch-case statement; > - Check whether RX queue number is a valid one, otherwise return error; > - Update the description a bit; > > changes in v3: > - More cleanup; > > changes in v2: > - Update the description; > - Use receiving queue number('--rxq ') specified in config to determine the > number of pool and the number of queue per VF; > > changes in v1: > - Config VF RSS; > > Changchun Ouyang (6): > ixgbe: Code cleanup > ixgbe: Negotiate VF API version > ixgbe: Get VF queue number > ether: Check VMDq RSS mode > ixgbe: Config VF RSS > testpmd: Set Rx VMDq RSS mode Deeply reviewed by Vlad Zolotarov. Thanks! Applied Thanks to both of you -- Thomas