From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f47.google.com (mail-wm0-f47.google.com [74.125.82.47]) by dpdk.org (Postfix) with ESMTP id DB1B8CBBE for ; Fri, 17 Jun 2016 11:09:57 +0200 (CEST) Received: by mail-wm0-f47.google.com with SMTP id m124so103367298wme.1 for ; Fri, 17 Jun 2016 02:09:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=9bmb5z0x1ZPxPclMoKl88w1oBztrkb98YODtYUDqoTM=; b=Z+RNDMGtEHsYUCmjgDZ+YJqfA8dPt7vtfNZFFPVFJORUBYrabv2MR5PRFkdwP5c7Co g6scnNAvRhQSNlLbYixRnDf0HZ7mH/MMKk9O82TbA493/MNCweCEqkcCX6octl+RYSjY 6AlpX3+VRIKaylefXYP1MqCMAn7BOEu9IXILwzew4ERJzFGI4UjeXoZqbB/k16OXzlmS UUv+gQaXM9USfAbNuAoqVdnEi2hyV10lrmUo6zzs49QWja4efesw/KaZdZAyQpeH/VQh hi2aCS1HWPld4+urVX7PBlLZafYRYigF9gINpKugE+DXXb1KgIbjqXE/Z6AAPUlf0bOQ o9MQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=9bmb5z0x1ZPxPclMoKl88w1oBztrkb98YODtYUDqoTM=; b=gDdkxAXSKa1BOGJZWqyC4cxoo2OdNYMpScel43i9XGo1GEaGSReH44SsGZn+iiSzRc VjITUEI7Fa8vCCXlqTJ2PctKqKOm+Ri858yGr/YEGjMcV7u71b+GNNMl4vt17ChIfxiz J5ZEbAUvSLRGBHdj/V6IA3z3l/1g2oO999Drx7HS/J8J6fgAJk9LaNTp5h5cEs8eOVTJ JadSH1K4hAg0amcQar2UK1C6JvyZJ8FIKELViMwPd8qn60YIHMb6imhMdmHYRM347nWF VBg71VPEBTbTyRg/oDKo5i5y9V5uSBt2yNDun1yuX/mJzYWybq8j87dG+VPVWYChOJYL KJEQ== X-Gm-Message-State: ALyK8tLP9tuEqYQoD4hRz8wFOeBCBRiG+qHYRgdrDrQO3JwzhACHAji43M4BS3JNP1mZ9WpH X-Received: by 10.194.243.101 with SMTP id wx5mr1196515wjc.132.1466154597661; Fri, 17 Jun 2016 02:09:57 -0700 (PDT) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id i74sm18955968wmg.21.2016.06.17.02.09.56 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 17 Jun 2016 02:09:56 -0700 (PDT) From: Thomas Monjalon To: "Hunt, David" Cc: dev@dpdk.org, Olivier Matz , viktorin@rehivetech.com, jerin.jacob@caviumnetworks.com, shreyansh.jain@nxp.com Date: Fri, 17 Jun 2016 11:09:55 +0200 Message-ID: <2502441.EqJFgDIT6e@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <5763B7FC.80608@intel.com> References: <1465976824-83823-1-git-send-email-david.hunt@intel.com> <5763B018.5090602@6wind.com> <5763B7FC.80608@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v13 1/3] mempool: support external mempool operations X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Jun 2016 09:09:58 -0000 2016-06-17 09:42, Hunt, David: > > On 17/6/2016 9:08 AM, Olivier Matz wrote: > > Hi David, > > > > On 06/17/2016 08:58 AM, Hunt, David wrote: > >> A comment below: > >> > >> On 16/6/2016 1:30 PM, David Hunt wrote: > >>> +/** > >>> + * Set the ops of a mempool. > >>> + * > >>> + * This can only be done on a mempool that is not populated, i.e. > >>> just after > >>> + * a call to rte_mempool_create_empty(). > >>> + * > >>> + * @param mp > >>> + * Pointer to the memory pool. > >>> + * @param name > >>> + * Name of the ops structure to use for this mempool. > >> + * @param pool_config > >> + * Opaque data that can be used by the ops functions. > >>> + * @return > >>> + * - 0: Success; the mempool is now using the requested ops functions. > >>> + * - -EINVAL - Invalid ops struct name provided. > >>> + * - -EEXIST - mempool already has an ops struct assigned. > >>> + */ > >>> +int > >>> +rte_mempool_set_ops_byname(struct rte_mempool *mp, const char *name, > >>> + void *pool_config); > >>> + > >> > > The changes related to the pool_config look good to me. > > > > If you plan to do a v14 for this API comment, I'm wondering if the > > documentation could be slightly modified too. I think "external mempool > > manager" was the legacy name for the feature, but maybe it could be > > changed in "alternative mempool handlers" or "changing the mempool > > handler". I mean the word "external" is probably not appropriate now, > > especially if we add other handlers in the mempool lib. > > > > My 2 cents, > > Olivier > > I had not planned on doing another revision. And I think the term "External > Mempool Manager" accurately describes the functionality, so I'd really > prefer to leave it as it is. I think there is no manager, just a default handler which can be changed. I agree the documentation must be fixed.