From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 985E6A04B5; Thu, 29 Oct 2020 11:43:35 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 55BBCC9AC; Thu, 29 Oct 2020 11:43:33 +0100 (CET) Received: from wnew3-smtp.messagingengine.com (wnew3-smtp.messagingengine.com [64.147.123.17]) by dpdk.org (Postfix) with ESMTP id 6C7E3C996 for ; Thu, 29 Oct 2020 11:43:31 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailnew.west.internal (Postfix) with ESMTP id B928E9F6; Thu, 29 Oct 2020 06:43:28 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Thu, 29 Oct 2020 06:43:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= Uledyd6RtQ+mwwsscqi/M86Z+X6Vp2/oCR9fKfPWkXE=; b=qxZj0FndCXqG85KY 4NISPGMXbCA3Ut+fO5PqFBHfNYQvTGRhDsJH9ubChptbUK+DcFYvxKFkwV4fl0f2 BKvy5WIUGhMRZf/eEr228jwNSLMqliQ67TYgnMj6qVFQZq07JguOg0UQ6JJKABtj V1QNIqCRzct4/ZkbY1xdDR3oGYaHSSnCMnLgcrTeiar6Z0St53O/GcM8kQs6POgo wBpGw8KWKoBpglfOBCmPjbNPDmDxpZy4GmASGOwULeDBY0Zqby8gyWOi9we/k41s SGqMIqNaSL0tjVomElE79jcLeCK9bp+dgZqmQx7E2C2WPzxdDIH/OSMYN46AcD5b Ljuz0A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=Uledyd6RtQ+mwwsscqi/M86Z+X6Vp2/oCR9fKfPWk XE=; b=f4cjmn+TqQ8EeLscVEScvpCJT7C3TFKi5ixJwF/SntBPJ/35d51ueTCAr FUDE0qC6rcimaMXStvOGyuiqvEnaT56NGi6KXhFHibTuezPEjPg7Ebnice/mUT8m 6JVAf4Du8CbKBR7ikpRDgIO2T3NaRR9hYjpQgp2OsOxvrlU5OwD1kRXc2Ny/5fqK GRTswiszT3U57d7MbFruRgbp2szm2IfLE+KsYa7OROoVMuOhCPZROfPmRm9uGSAe ihOCROnmH4Sm1u6+GZRco+SQqfrH/L2eLsU2/goRvv+tef4bdG+WxNurbm0dyidv 2qJFpLk5VExSZ8+eut7P5xuQ8mGdA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrleefgddvtdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdejueei iedvffegheenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuih iivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhho nhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 6F7A8306467E; Thu, 29 Oct 2020 06:43:25 -0400 (EDT) From: Thomas Monjalon To: Andrew Rybchenko Cc: dev@dpdk.org, ferruh.yigit@intel.com, david.marchand@redhat.com, bruce.richardson@intel.com, olivier.matz@6wind.com, jerinj@marvell.com, viacheslavo@nvidia.com, Wenzhuo Lu , Beilei Xing , Bernard Iremonger Date: Thu, 29 Oct 2020 11:43:23 +0100 Message-ID: <2503424.fElMP3rPzW@thomas> In-Reply-To: References: <20201029092751.3837177-1-thomas@monjalon.net> <20201029092751.3837177-13-thomas@monjalon.net> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH 12/15] app/testpmd: switch timestamp to dynamic mbuf field X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 29/10/2020 11:20, Andrew Rybchenko: > On 10/29/20 12:27 PM, Thomas Monjalon wrote: > > The mbuf timestamp is moved to a dynamic field > > in order to allow removal of the deprecated static field. > > The related mbuf flag is also replaced. > > > > Signed-off-by: Thomas Monjalon > > --- > > --- a/app/test-pmd/util.c > > +++ b/app/test-pmd/util.c > > +static inline bool > > +is_timestamp_enabled(const struct rte_mbuf *mbuf) > > +{ > > + static uint64_t timestamp_rx_dynflag; > > + > > + int timestamp_rx_dynflag_offset; > > + > > + if (timestamp_rx_dynflag == 0) { > > + timestamp_rx_dynflag_offset = rte_mbuf_dynflag_lookup( > > + RTE_MBUF_DYNFLAG_RX_TIMESTAMP_NAME, NULL); > > If the flag is not registered, it will try to lookup on every > call. I'm not sure that it is good. I don't see the problem. It is a dump in a test application. The idea is to have a fresh dump whatever was updated recently.