From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id 2E1EDA0C52;
Tue, 2 Nov 2021 16:18:50 +0100 (CET)
Received: from [217.70.189.124] (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id E315341152;
Tue, 2 Nov 2021 16:18:49 +0100 (CET)
Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com
[66.111.4.29]) by mails.dpdk.org (Postfix) with ESMTP id 9DF754114A
for <dev@dpdk.org>; Tue, 2 Nov 2021 16:18:48 +0100 (CET)
Received: from compute6.internal (compute6.nyi.internal [10.202.2.46])
by mailout.nyi.internal (Postfix) with ESMTP id 18CA25C0107;
Tue, 2 Nov 2021 11:18:48 -0400 (EDT)
Received: from mailfrontend2 ([10.202.2.163])
by compute6.internal (MEProxy); Tue, 02 Nov 2021 11:18:48 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
from:to:cc:subject:date:message-id:in-reply-to:references
:mime-version:content-transfer-encoding:content-type; s=fm2; bh=
yMfZRX1JTefqPmFISACaZnTJDH21NeQocnVMqDguJsY=; b=jJw07BJtNmGAQVhc
wknnbtHLC63yq3fu4z5VfjLczdWY3HRAooUA79hGWjpfOmYs7FvXdylbieK9pWkJ
SrXl6kj9RikWMhxNu1PXuKJxSBbCBUBeY6yfoXPapLMESSrqFZlEWcNYhzanDlU2
ZDrtuV0ugpws10F8Dr4TiSIIDg+jl4eFjQVMwUAf/Jxfseshlcl9uSnhA2Skl6x9
/2lDnWzN3NKkMd+uewXYVNPxZrZWzTELW8E4DF2lxR0KbmX/3iXhzLcMMiErG3iB
YA0VSgRphL1I+j0zBOUbrc9LA0+PnFPqZPB8Z2/Bk7cY4Ma6ubgLK7ARBF5dgTGl
KaGwiw==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
messagingengine.com; h=cc:content-transfer-encoding:content-type
:date:from:in-reply-to:message-id:mime-version:references
:subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender
:x-sasl-enc; s=fm1; bh=yMfZRX1JTefqPmFISACaZnTJDH21NeQocnVMqDguJ
sY=; b=ecrBQFTL+1rw9REVw3PIF29j9LRRveAN9lZkp3oMNUBTIFnSqQ3HkgF9o
qVksDl4+h6qSQBwpgaNI2KO+JQOOKJnIWh54tbOpkbSZED/y72TQhijfZ3avXpU8
pUKs+o/6mQpvy1vUd26Lj87gIvcxfY9gPPPokIAny0XC6CekN4nwwdKNa42x/Uh3
UjsubasdIvY4d0dxPfdTW+9GNRP85ThMkLNg5yxZMzMxwqhV3Z9hFuH5SapS3hCZ
a/X8WfDx3pkLyqVd84jAdnfU1GIZOcIkAKKuLUByaBle0yXZZph537XFnddAox84
6OL2VClhrR8ff47nFrlb8bQdUV4hQ==
X-ME-Sender: <xms:11aBYeELjD9f68S7oiZr_4TJALeMn-hUiTc4s_-zm-2q1XyOg-f0qw>
<xme:11aBYfVQrzr4UK7Cuw_5JFkTSQb_dYNwOvZyqXB-V9gP8_IZCCHnmLQjKWnIgN4kq
MLMvxdObGZW3tJFJg>
X-ME-Received: <xmr:11aBYYLunY4Be34fXqzSsCQEizTSS_jOL_cMf41YxNS46V9DJ36vcElT9d1ZUvDeaC_gSC5B_NuQv_FsQgSc2kISQQ>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvuddrtddtgdeglecutefuodetggdotefrodftvf
curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu
uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc
fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs
ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf
frrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdejueei
iedvffegheenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhroh
hmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght
X-ME-Proxy: <xmx:11aBYYHFQn57hlfenOe-j5P0qjnZKlzS-ExSUJO6Hu6YvVj-V3yBnQ>
<xmx:11aBYUXCD-3pBl2lAhRDeN8QBA9JO7yZGxr4CbKCFJTLCRx4BQKg4g>
<xmx:11aBYbNRwobJmO3UPZaTAOlLak7XZlGg-8Jih-tRAqhVfPMwjUEtyA>
<xmx:2FaBYRjzdARax15njmPx8cZ8zn0RhafTr0NE0l3PFyAzf-YvKYMKCw>
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue,
2 Nov 2021 11:18:47 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: Aman Kumar <aman.kumar@vvdntech.in>
Cc: dev@dpdk.org, keesang.song@amd.com, david.marchand@redhat.com
Date: Tue, 02 Nov 2021 16:18:46 +0100
Message-ID: <2507236.ifWSo0Cply@thomas>
In-Reply-To: <20211102145253.413467-1-aman.kumar@vvdntech.in>
References: <20211102145253.413467-1-aman.kumar@vvdntech.in>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH] config/x86: add support for AMD platform
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
02/11/2021 15:52, Aman Kumar:
> -Dcpu_instruction_set=znverX meson option can be used
> to build dpdk for AMD platforms. Supported options are
> znver1, znver2 and znver3.
>
> Signed-off-by: Aman Kumar <aman.kumar@vvdntech.in>
> ---
> +# AMD platform support
> +if get_option('cpu_instruction_set') == 'znver1'
> + dpdk_conf.set('RTE_MAX_LCORE', 256)
> +elif get_option('cpu_instruction_set') == 'znver2'
> + dpdk_conf.set('RTE_MAX_LCORE', 512)
> +elif get_option('cpu_instruction_set') == 'znver3'
> + dpdk_conf.set('RTE_MAX_LCORE', 512)
> +endif
Ideally we should try getting rid of this config
and make all structs depending on max lcores allocated dynamically.
I think it may be an interesting target for next year 22.11 release.
About the patch itself, I am OK to merge it in 21.11-rc2.