From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id D4932A0536; Fri, 24 Jan 2020 20:37:20 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0CE8D34F3; Fri, 24 Jan 2020 20:37:20 +0100 (CET) Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 8839B2A62 for ; Fri, 24 Jan 2020 20:37:18 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id CE7FE21FAD; Fri, 24 Jan 2020 14:37:17 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Fri, 24 Jan 2020 14:37:17 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=uI4+RMroiAmjMC+w10F8AZDcxMN7P8UVsrl+7Uy5PFs=; b=ocrJ3J6ruWo6 ZFfQDlzwTZUBs1r0kQy7HQnnM2La9RwEXDzcWPlH8igVbExh7grbSg6/1kIdUWde ELGfundC+lKF2NJGrdZz7UFEp/tOhOjqfeECBhHMSF6nOdtZLDkkxyi6RUBNVJWe GosNlxjgd8t1ZgdyX2XJW9dMRFaqBVM= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=uI4+RMroiAmjMC+w10F8AZDcxMN7P8UVsrl+7Uy5P Fs=; b=A1HESyTrAv0Qna/Jb1yMcZX8yair579wtWzfg7DWT0GNNoAtDzD9fKZ8Y Xhc9Mnw8gigJH13osXT9oK6QR5NfSCAyVRmqMDCEn1UwNEZ8HYTdWob3EBd7NIho gwGef4+d0CV5IQ2jE0PSVVq1z54N98Dx6Zl9LJeR2p6qYx8WrLDE9mcHkRbke2zh EH4AfGmlBen94e8Yml66sw0cNqqr+5Oaq6lPl12iFPOEn1CWFsz2dM063FHw0KQV Pcd09LV8rHuj6KPMeeslaExbWl3suTjeOVnxAnCQKehTfduWNJt0ue477f8Y6zdJ TcHqnPXtBV7bMJTIlUoH/sLVhF78g== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedugedrvdeggdduvdeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecuff homhgrihhnpehvrghrshdrmhhknecukfhppeejjedrudefgedrvddtfedrudekgeenucev lhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrsh esmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 761173062080; Fri, 24 Jan 2020 14:37:16 -0500 (EST) From: Thomas Monjalon To: Ferruh Yigit Cc: Alexander Kozyrev , dev@dpdk.org, rasland@mellanox.com, matan@mellanox.com, viacheslavo@mellanox.com Date: Fri, 24 Jan 2020 20:37:14 +0100 Message-ID: <2508825.icZtzsIVVb@xps> In-Reply-To: <06fe3cad-8da9-ac20-c064-62dcce4db0b3@intel.com> References: <1579789555-23239-1-git-send-email-akozyrev@mellanox.com> <1579803629-152938-2-git-send-email-akozyrev@mellanox.com> <06fe3cad-8da9-ac20-c064-62dcce4db0b3@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2 1/5] mk/icc: disable treatment of warnings as errors X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 24/01/2020 17:36, Ferruh Yigit: > On 1/23/2020 6:20 PM, Alexander Kozyrev wrote: > > Remove -Werror-all flag in ICC configuration file to stop treating ICC > > warnings as errors in DPDK due to many false positives. We are using > > GCC and Clang as a benchmark for warnings anyway for simplification. > > > > Suggested-by: Thomas Monjalon > > Signed-off-by: Alexander Kozyrev > > Acked-by: Viacheslav Ovsiienko > > Acked-by: Thomas Monjalon > > --- > > mk/toolchain/icc/rte.vars.mk | 4 ---- > > 1 file changed, 4 deletions(-) > > > > diff --git a/mk/toolchain/icc/rte.vars.mk b/mk/toolchain/icc/rte.vars.mk > > index 8aa87aa..1729f3d 100644 > > --- a/mk/toolchain/icc/rte.vars.mk > > +++ b/mk/toolchain/icc/rte.vars.mk > > @@ -47,10 +47,6 @@ WERROR_FLAGS += -diag-disable 13368 -diag-disable 15527 > > WERROR_FLAGS += -diag-disable 188 > > WERROR_FLAGS += -diag-disable 11074 -diag-disable 11076 -Wdeprecated > > > > -ifeq ($(RTE_DEVEL_BUILD),y) > > -WERROR_FLAGS += -Werror-all > > -endif > > Not sure about removing this globally, as of now the ICC builds fine. If this is > for the coming changes in mlx, why not disable warnings in mlx driver only? Adding special handling for ICC in the driver means it is kind of supported. ICC support is on best-effort basis as a favor to Intel and its CI. I don't see any good reason to spend time disabling ICC warnings each time we hit a false positive. And I would like we stop doing strange things in the code to make ICC happy. We do not need to support ICC, or at least we do not need to make ICC build warning-free. This patch will solve all future annoying issues with ICC in the future. Now let me ask the reverse question: why the flag -Werror-all is set for ICC? We set this flag for gcc and clang because we use gcc and clang as static code analyzers (like coverity) and we want to be sure to catch any issue. ICC is not used as code analyzer, this is just an optimization for some Intel projects. I won't elaborate on the packaging and licensing of ICC... I hope you will be convinced to acknowledge this change.