From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wg0-f41.google.com (mail-wg0-f41.google.com [74.125.82.41]) by dpdk.org (Postfix) with ESMTP id 82AFEDE0 for ; Thu, 29 May 2014 08:32:37 +0200 (CEST) Received: by mail-wg0-f41.google.com with SMTP id z12so12441110wgg.24 for ; Wed, 28 May 2014 23:32:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=23NZEzQfdhgglspVGjGjdgGKScQMI4vUKR9aevj0OmM=; b=ZcILYO+kt8sfK8MQZtH5nRdaYmwcEwbhkw56zpnBauvmqoFTbEML3zBXDoZm32j3HT G9DGmB8GycfHXltFe34Urw7ErNJU5u0oN1K0jbeyP5F8gzld2MuVs4MVKq+yMVNIOhmG y3+GEgby7tj5Uhqon57qIBCEM8C20ZSCqHnuzBXHrjNJtvxmoWBjh9cpBH0AcKrwhtRC v4rerlQ2jpnVyGVJbrOOw3iBZ0ij/0I5rMYfpaXccVbWqjA+EfYKv3+BggAsIZun+c99 KmApLYXbUIB0is33ru7nUFeLFIF6kDYWFE/KREwZDk9bRqibAKNqdp+icN4A5Jbh7Cw5 g1rA== X-Gm-Message-State: ALoCoQkqC03Z17BHOo7be1e7RNEzLMp/qYRsWN5S4JqntXYLsZrjJnjsEBljN+16z5Edm/qsksXy X-Received: by 10.194.108.5 with SMTP id hg5mr6949806wjb.57.1401345168645; Wed, 28 May 2014 23:32:48 -0700 (PDT) Received: from xps13.localnet (108.26.90.92.rev.sfr.net. [92.90.26.108]) by mx.google.com with ESMTPSA id wk8sm49206530wjb.22.2014.05.28.23.32.46 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 28 May 2014 23:32:47 -0700 (PDT) From: Thomas Monjalon To: Neil Horman Date: Thu, 29 May 2014 08:24:56 +0200 Message-ID: <2509781.kUZheoFqzk@xps13> Organization: 6WIND User-Agent: KMail/4.13 (Linux/3.14.4-1-ARCH; KDE/4.13.0; x86_64; ; ) In-Reply-To: <20140528141751.GA2648@localhost.localdomain> References: <1401195316-31149-1-git-send-email-thomas.monjalon@6wind.com> <20140528141751.GA2648@localhost.localdomain> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] mk: fix link with gcc X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 May 2014 06:32:37 -0000 Hi Neil, 2014-05-28 10:17, Neil Horman: > On Tue, May 27, 2014 at 02:55:16PM +0200, Thomas Monjalon wrote: > > Some linker options were not prefixed by -Wl, when using gcc: > > -z muldefs > > -melf_i386 (32-bit config) > > > > Using macro linkerprefix is fixing it. > > > > Signed-off-by: Thomas Monjalon [...] > > ifeq ($(LINK_USING_CC),1) > > # Override the definition of LD here, since we're linking with CC > > LD := $(CC) > > > > +LD_MULDEFS := $(call linkerprefix,-z$(comma)muldefs) > > +CPU_LDFLAGS := $(call linkerprefix,$(CPU_LDFLAGS)) > > Agree with Olivier, what exactly is the problem here? When using CC as LD, linker options should be prefixed with -Wl. > Also, I don't think > this is correct, as CPU_LD_FLAGS and -z muldefs below is used in > conjunction with $LD. It would make sense to prefix -Wl to these options > if we were passing them through $CC, but not $LD Yes, but options are prefixed only in the case LD = CC. Neil, this situation is funny as you're the author of the patch making LD as CC and you submitted this kind of fix to prefix CPU_LDFLAGS :) This patch is a translation of yours with use of macro linkerprefix. -- Thomas