From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A418FA0C56; Thu, 25 Nov 2021 10:29:08 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 35B4B40DF5; Thu, 25 Nov 2021 10:29:08 +0100 (CET) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by mails.dpdk.org (Postfix) with ESMTP id C28F840140; Thu, 25 Nov 2021 10:29:06 +0100 (CET) Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 6F44B5C018D; Thu, 25 Nov 2021 04:29:06 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Thu, 25 Nov 2021 04:29:06 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= B1xlys7ZywPINjRpKOLkERMCggi8tHFaOLY4pLZXi2Q=; b=T0LiAbYeuVaWA6xK DK6l5tlscY9gitqtkJ5Vs8K0T74qFECC3+aoUojsTCBBmoeX5gP4W4WbbG2d7qr+ YoEKFrYa0pAcXbyD44BalijzZdtAOOVQxfXxe9ysXnL9Zfxr3TULl5QQpYd9PkXO OVLux/asc729OD465r3PtSjRHnyn7BO11Brb3/x5q2KYqAhn/TXNnqN5em3WTOtq SAYRkKnUFsYE4T0yRqhUdThHpAPR7KZU122mtXtaZQzcknuj5jkR63gRwM+6O/b4 jY2kvQJbmEqY99ZfKWj8BpIGI00Begfco3VqVphDWBmXSanDVI7VLk2VVz7mFtyl wFer4Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=B1xlys7ZywPINjRpKOLkERMCggi8tHFaOLY4pLZXi 2Q=; b=XNTUUXxj/QEajpVL4lzE9mQtXRXjdOkrhUyWy1J3LMRJ1ajBDGrlms/oN ouBoVLKC4gdZwOJ0f1zIJBXkAPOLCRzqGJmQQRQt/C6s1A3nELWWEdSA+sP2udq+ pYr4QIM4S3UWR1Rs7PHbrd6b+P7iidmgRpi4QGiiqe0aoNG42+HeWXg5CELe21tZ 94slE4+uJAOj8/3ciQ9q0aEtx0ewWezusYLazbsRM8L8JKy8L7YFdTcUW3M9D58j pGroom/2py47+GDckfTwEu2Sb9A+ZGZpGp5cyAc962YB8lefGWZzau9s01c8GdNJ cUz+eDWahq1+7yfn7Kro6+ZHHCOjA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvuddrhedtgddtfecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdejueei iedvffegheenucevlhhushhtvghrufhiiigvpedunecurfgrrhgrmhepmhgrihhlfhhroh hmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 25 Nov 2021 04:29:05 -0500 (EST) From: Thomas Monjalon To: Matan Azrad , Raslan Darawsheh , Michael Baum Cc: dev@dpdk.org, Viacheslav Ovsiienko , stable@dpdk.org, Lior Margalit , asafp@nvidia.com Subject: Re: [PATCH] net/mlx5: fix devargs validation for multiclass probe Date: Thu, 25 Nov 2021 10:29:03 +0100 Message-ID: <2510169.dztEg1IeGT@thomas> In-Reply-To: <20211125061655.3143135-1-michaelba@nvidia.com> References: <20211125061655.3143135-1-michaelba@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 25/11/2021 07:16, michaelba@nvidia.com: > From: Michael Baum > > The mlx5_args function reads the devargs and checks if they are valid > for this driver and if not it returns an error. > > This was normal behavior as long as all the devargs come to this driver, > but since it is possible to run several drivers together, the function > may return an error for another driver's devarg even though it is > completely valid. > In addition the function does not allow the user to know which of the > devargs he sent is incorrect, but returns an error without printing the > unknown devarg. > > This patch eliminates the error return in the case of an unknown devarg, > and prints a warning for each such devarg specifically. > > Fixes: 7b4f1e6bd367 ("common/mlx5: introduce common library") > Cc: stable@dpdk.org > > Signed-off-by: Michael Baum > Acked-by: Matan Azrad > --- > drivers/net/mlx5/mlx5.c | 68 ++++++----------------------------------- > 1 file changed, 9 insertions(+), 59 deletions(-) It is quite a big patch. How well it has been tested? How critical it is to have in 21.11?