From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: "Zhang, Helin" <helin.zhang@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2 0/2] remove registers for early hardware only
Date: Wed, 29 Oct 2014 23:59:34 +0100 [thread overview]
Message-ID: <2514313.2vx3aNJpxn@xps13> (raw)
In-Reply-To: <9BB6961774997848B5B42BEC655768F8B25561@SHSMSX104.ccr.corp.intel.com>
2014-10-29 08:53, Wu, Jingjing:
> From: Zhang, Helin
> > For those registers and their relevant for early hardware only, they should
> > neither be defined nor be used. Thus i40e_register_x710_int.h should be
> > removed. As I40E_GLINT_CTL and its relevant is really needed, just define it
> > directly as a workaround.
> >
> > v2 changes:
> > * Added back writing I40E_GLINT_CTL with correct configurations,
> > as it is really needed. Otherwise there would be problem of
> > single descriptor write back.
> > * Removed those code style fix, as it is already in another
> > patch set.
> >
> > Helin Zhang (2):
> > i40e: do not use macros defined in i40e_register_x710_int.h
> > i40e: remove i40e_register_x710_int.h
> >
> > lib/librte_pmd_i40e/i40e/i40e_register_x710_int.h | 10712 --------------------
> > lib/librte_pmd_i40e/i40e_ethdev.c | 5 +-
> > 2 files changed, 4 insertions(+), 10713 deletions(-) delete mode 100644
>
> Acked-by: Jingjing Wu <jingjing.wu@intel.com>
Applied in one patch:
i40e/base: remove early hardware definitions
Thanks
--
Thomas
prev parent reply other threads:[~2014-10-29 22:51 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-23 6:01 [dpdk-dev] [PATCH " Helin Zhang
2014-10-23 6:01 ` [dpdk-dev] [PATCH 1/2] i40e: " Helin Zhang
2014-10-23 6:01 ` [dpdk-dev] [PATCH 2/2] i40e: code style fix Helin Zhang
2014-10-23 7:21 ` [dpdk-dev] [PATCH 0/2] remove registers for early hardware only Thomas Monjalon
2014-10-23 7:24 ` Thomas Monjalon
2014-10-23 7:27 ` Zhang, Helin
2014-10-23 7:31 ` Thomas Monjalon
2014-10-29 7:09 ` [dpdk-dev] [PATCH v2 " Helin Zhang
2014-10-29 7:09 ` [dpdk-dev] [PATCH v2 1/2] i40e: do not use macros defined in i40e_register_x710_int.h Helin Zhang
2014-10-29 7:09 ` [dpdk-dev] [PATCH v2 2/2] i40e: remove i40e_register_x710_int.h Helin Zhang
2014-10-29 8:53 ` [dpdk-dev] [PATCH v2 0/2] remove registers for early hardware only Wu, Jingjing
2014-10-29 22:59 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2514313.2vx3aNJpxn@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=helin.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).