From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f179.google.com (mail-wi0-f179.google.com [209.85.212.179]) by dpdk.org (Postfix) with ESMTP id 61CBA2A9 for ; Wed, 29 Oct 2014 23:51:01 +0100 (CET) Received: by mail-wi0-f179.google.com with SMTP id h11so5930375wiw.0 for ; Wed, 29 Oct 2014 15:59:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=bMdlLS87zyN6Kh9PP9G9JyTSsI8t3TljfgnabGpSlSg=; b=XYabQwbF6xjo0XdisQd6YfszlES1/vawIKH7eEG51FciQtsZya5Ce0yANxdkgGTTgN DYFZwZSL4h0n/IquQDrqP3mPm+4efIbQgJpj5xJhO0SCDjMOdS1ID199yAkqiqQWHn+g u6vfSnI9cwfXHhQAQIXFubWZWwD5IRLi8XqQNP4wCU7iqS8tZeg0ByMLcaIlGFnCWynh 54vPR7OqT/9My3cWNJGzLl5HKnDL7hPRtAolGty1SGWcgaKkjXuZ+6VR+ERYPtniaQki RMUsf+/4ma5NqoFSxWSXEtEI2rGUXNVy/oprioueKlL8UcXoBqRCCUinI/xHxm9/1aSn tZ9g== X-Gm-Message-State: ALoCoQku67j5epbMaeNwaymvBl9UvJaHVE4HGMrBmLNENrLN20kLzURlxBq4KIYplu1aM7tMuzMe X-Received: by 10.194.142.147 with SMTP id rw19mr16422925wjb.64.1414623594847; Wed, 29 Oct 2014 15:59:54 -0700 (PDT) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id w10sm6700707wje.10.2014.10.29.15.59.53 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 29 Oct 2014 15:59:54 -0700 (PDT) From: Thomas Monjalon To: "Zhang, Helin" Date: Wed, 29 Oct 2014 23:59:34 +0100 Message-ID: <2514313.2vx3aNJpxn@xps13> Organization: 6WIND User-Agent: KMail/4.14.2 (Linux/3.17.1-1-ARCH; KDE/4.14.2; x86_64; ; ) In-Reply-To: <9BB6961774997848B5B42BEC655768F8B25561@SHSMSX104.ccr.corp.intel.com> References: <1414044079-10006-1-git-send-email-helin.zhang@intel.com> <1414566571-25829-1-git-send-email-helin.zhang@intel.com> <9BB6961774997848B5B42BEC655768F8B25561@SHSMSX104.ccr.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v2 0/2] remove registers for early hardware only X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Oct 2014 22:51:01 -0000 2014-10-29 08:53, Wu, Jingjing: > From: Zhang, Helin > > For those registers and their relevant for early hardware only, they should > > neither be defined nor be used. Thus i40e_register_x710_int.h should be > > removed. As I40E_GLINT_CTL and its relevant is really needed, just define it > > directly as a workaround. > > > > v2 changes: > > * Added back writing I40E_GLINT_CTL with correct configurations, > > as it is really needed. Otherwise there would be problem of > > single descriptor write back. > > * Removed those code style fix, as it is already in another > > patch set. > > > > Helin Zhang (2): > > i40e: do not use macros defined in i40e_register_x710_int.h > > i40e: remove i40e_register_x710_int.h > > > > lib/librte_pmd_i40e/i40e/i40e_register_x710_int.h | 10712 -------------------- > > lib/librte_pmd_i40e/i40e_ethdev.c | 5 +- > > 2 files changed, 4 insertions(+), 10713 deletions(-) delete mode 100644 > > Acked-by: Jingjing Wu Applied in one patch: i40e/base: remove early hardware definitions Thanks -- Thomas