[dpdk-dev] [RFC PATCH 0/3] ethdev: document more retained across restart

[dpdk-dev] [RFC PATCH 0/3] ethdev: document more retained across restart

[Andrew Rybchenko]

The patch series tries to improve documentation of what is retained
across default restart.

Should it collect acks from all PMD maintainers to be applied?

Andrew Rybchenko (3):
  ethdev: advertise MTU as retained across device stop/start
  ethdev: advertise default MAC as retained on device restart
  ethdev: highlight that all-multicast is retained on restart

 lib/librte_ethdev/rte_ethdev.h | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

-- 
2.17.1

[dpdk-dev] [RFC PATCH 1/3] ethdev: advertise MTU as retained across device stop/start

[Andrew Rybchenko]

Changing MTU in running state may return -EBUSY saying that
MTU cannot be changed when the port is running. It assumes
that changes may be done in stopped and started (but some
PMDs may reject it) state and it is logical to require that
changes done in any of these states are retained.

Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
---
 lib/librte_ethdev/rte_ethdev.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/lib/librte_ethdev/rte_ethdev.h b/lib/librte_ethdev/rte_ethdev.h
index 8dd1799e2..efe223b61 100644
--- a/lib/librte_ethdev/rte_ethdev.h
+++ b/lib/librte_ethdev/rte_ethdev.h
@@ -80,6 +80,7 @@
  * rte_eth_dev_stop()/rte_eth_dev_start(). The following configuration will
  * be retained:
  *
+ *     - MTU
  *     - flow control settings
  *     - receive mode configuration (promiscuous mode, hardware checksum mode,
  *       RSS/VMDQ settings etc.)
-- 
2.17.1

[dpdk-dev] [RFC PATCH 2/3] ethdev: advertise default MAC as retained on device restart

[Andrew Rybchenko]

The documentation says MAC addresses array is retained and
it is logical to assume that default MAC address is retained
as well.

Also some PMDs do not allow to change the default MAC in
running state (see RTE_ETH_DEV_NOLIVE_MAC_ADDR).

Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
---
 lib/librte_ethdev/rte_ethdev.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/lib/librte_ethdev/rte_ethdev.h b/lib/librte_ethdev/rte_ethdev.h
index efe223b61..94f7cd141 100644
--- a/lib/librte_ethdev/rte_ethdev.h
+++ b/lib/librte_ethdev/rte_ethdev.h
@@ -85,6 +85,7 @@
  *     - receive mode configuration (promiscuous mode, hardware checksum mode,
  *       RSS/VMDQ settings etc.)
  *     - VLAN filtering configuration
+ *     - default MAC address
  *     - MAC addresses supplied to MAC address array
  *     - flow director filtering mode (but not filtering rules)
  *     - NIC queue statistics mappings
-- 
2.17.1

[dpdk-dev] [RFC PATCH 3/3] ethdev: highlight that all-multicast is retained on restart

[Andrew Rybchenko]

All-multicast is a part of receive mode configuration and it is
better to mention explicitly that it is retained across restart.

Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
---
 lib/librte_ethdev/rte_ethdev.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib/librte_ethdev/rte_ethdev.h b/lib/librte_ethdev/rte_ethdev.h
index 94f7cd141..b98c74785 100644
--- a/lib/librte_ethdev/rte_ethdev.h
+++ b/lib/librte_ethdev/rte_ethdev.h
@@ -82,8 +82,8 @@
  *
  *     - MTU
  *     - flow control settings
- *     - receive mode configuration (promiscuous mode, hardware checksum mode,
- *       RSS/VMDQ settings etc.)
+ *     - receive mode configuration (promiscuous mode, all-multicast mode,
+ *       hardware checksum mode, RSS/VMDQ settings etc.)
  *     - VLAN filtering configuration
  *     - default MAC address
  *     - MAC addresses supplied to MAC address array
-- 
2.17.1

Re: [dpdk-dev] [RFC PATCH 2/3] ethdev: advertise default MAC as retained on device restart

[Thomas Monjalon]

10/10/2018 09:51, Andrew Rybchenko:
> The documentation says MAC addresses array is retained and
> it is logical to assume that default MAC address is retained
> as well.

I'm confused. Default MAC address isn't implied by MAC addresses array?

Re: [dpdk-dev] [RFC PATCH 2/3] ethdev: advertise default MAC as retained on device restart

[Andrew Rybchenko]

On 10/10/18 11:53 AM, Thomas Monjalon wrote:
> 10/10/2018 09:51, Andrew Rybchenko:
>> The documentation says MAC addresses array is retained and
>> it is logical to assume that default MAC address is retained
>> as well.
> I'm confused. Default MAC address isn't implied by MAC addresses array?

 From API point of view it looks as different features (at least for me):
  - default MAC address is rte_eth_dev_default_mac_addr_set()
  - MAC addresses array is 
rte_eth_dev_mac_addr_add()/rte_eth_dev_mac_addr_remove()
but it is under one umbrella in NIC features (Unicast MAC filter).

May be it is my misunderstanding.

Re: [dpdk-dev] [RFC PATCH 2/3] ethdev: advertise default MAC as retained on device restart

[Thomas Monjalon]

10/10/2018 11:05, Andrew Rybchenko:
> On 10/10/18 11:53 AM, Thomas Monjalon wrote:
> > 10/10/2018 09:51, Andrew Rybchenko:
> >> The documentation says MAC addresses array is retained and
> >> it is logical to assume that default MAC address is retained
> >> as well.
> > I'm confused. Default MAC address isn't implied by MAC addresses array?
> 
>  From API point of view it looks as different features (at least for me):
>   - default MAC address is rte_eth_dev_default_mac_addr_set()
>   - MAC addresses array is 
> rte_eth_dev_mac_addr_add()/rte_eth_dev_mac_addr_remove()
> but it is under one umbrella in NIC features (Unicast MAC filter).

Because default MAC address is mac_addrs[0].

> May be it is my misunderstanding.

More doc is better :)
If it can be thought as different features, let's document it as you do.

[dpdk-dev] [PATCH v1 0/3] ethdev: document more retained across restart

[Andrew Rybchenko]

The patch series tries to improve documentation of what is retained
across default restart.

Andrew Rybchenko (3):
  ethdev: advertise MTU as retained across device stop/start
  ethdev: advertise default MAC as retained on device restart
  ethdev: highlight that all-multicast is retained on restart

 lib/librte_ethdev/rte_ethdev.h | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

-- 
2.17.1

[dpdk-dev] [PATCH v1 1/3] ethdev: advertise MTU as retained across device stop/start

[Andrew Rybchenko]

Changing MTU in running state may return -EBUSY saying that
MTU cannot be changed when the port is running. It assumes
that changes may be done in stopped and started (but some
PMDs may reject it) state and it is logical to require that
changes done in any of these states are retained.

Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
---
 lib/librte_ethdev/rte_ethdev.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/lib/librte_ethdev/rte_ethdev.h b/lib/librte_ethdev/rte_ethdev.h
index 1960f3a2d..617551f72 100644
--- a/lib/librte_ethdev/rte_ethdev.h
+++ b/lib/librte_ethdev/rte_ethdev.h
@@ -80,6 +80,7 @@
  * rte_eth_dev_stop()/rte_eth_dev_start(). The following configuration will
  * be retained:
  *
+ *     - MTU
  *     - flow control settings
  *     - receive mode configuration (promiscuous mode, hardware checksum mode,
  *       RSS/VMDQ settings etc.)
-- 
2.17.1

[dpdk-dev] [PATCH v1 2/3] ethdev: advertise default MAC as retained on device restart

[Andrew Rybchenko]

The documentation says MAC addresses array is retained and
it is logical to assume that default MAC address is retained
as well.

Also some PMDs do not allow to change the default MAC in
running state (see RTE_ETH_DEV_NOLIVE_MAC_ADDR).

Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
---
 lib/librte_ethdev/rte_ethdev.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/lib/librte_ethdev/rte_ethdev.h b/lib/librte_ethdev/rte_ethdev.h
index 617551f72..8ca80f0c0 100644
--- a/lib/librte_ethdev/rte_ethdev.h
+++ b/lib/librte_ethdev/rte_ethdev.h
@@ -85,6 +85,7 @@
  *     - receive mode configuration (promiscuous mode, hardware checksum mode,
  *       RSS/VMDQ settings etc.)
  *     - VLAN filtering configuration
+ *     - default MAC address
  *     - MAC addresses supplied to MAC address array
  *     - flow director filtering mode (but not filtering rules)
  *     - NIC queue statistics mappings
-- 
2.17.1

[dpdk-dev] [PATCH v1 3/3] ethdev: highlight that all-multicast is retained on restart

[Andrew Rybchenko]

All-multicast is a part of receive mode configuration and it is
better to mention explicitly that it is retained across restart.

Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
---
 lib/librte_ethdev/rte_ethdev.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib/librte_ethdev/rte_ethdev.h b/lib/librte_ethdev/rte_ethdev.h
index 8ca80f0c0..aa0e6fa6f 100644
--- a/lib/librte_ethdev/rte_ethdev.h
+++ b/lib/librte_ethdev/rte_ethdev.h
@@ -82,8 +82,8 @@
  *
  *     - MTU
  *     - flow control settings
- *     - receive mode configuration (promiscuous mode, hardware checksum mode,
- *       RSS/VMDQ settings etc.)
+ *     - receive mode configuration (promiscuous mode, all-multicast mode,
+ *       hardware checksum mode, RSS/VMDQ settings etc.)
  *     - VLAN filtering configuration
  *     - default MAC address
  *     - MAC addresses supplied to MAC address array
-- 
2.17.1

Re: [dpdk-dev] [PATCH v1 0/3] ethdev: document more retained across restart

[Ferruh Yigit]

On 12/19/2018 6:22 AM, Andrew Rybchenko wrote:
> The patch series tries to improve documentation of what is retained
> across default restart.

Overall makes sense to add below items into retained list, only concern if is
there any PMD conflicts with these information, they should either updated with
this patch or at least notified about expectation change.

> 
> Andrew Rybchenko (3):
>   ethdev: advertise MTU as retained across device stop/start
>   ethdev: advertise default MAC as retained on device restart
>   ethdev: highlight that all-multicast is retained on restart
> 
>  lib/librte_ethdev/rte_ethdev.h | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 

Re: [dpdk-dev] [PATCH v1 0/3] ethdev: document more retained across restart

[Andrew Rybchenko]

On 1/8/19 5:52 PM, Ferruh Yigit wrote:
> On 12/19/2018 6:22 AM, Andrew Rybchenko wrote:
>> The patch series tries to improve documentation of what is retained
>> across default restart.
> Overall makes sense to add below items into retained list, only concern if is
> there any PMD conflicts with these information, they should either updated with
> this patch or at least notified about expectation change.

 From my point of view it is just clarification of the required behaviour.
MTU is required because of flag which may be used to advertise that
it is impossible to change in started state (otherwise the behaviour for
different PMDs will be absolutely different).
Default MAC is just cosmetics because of MAC address list is already
mentioned and the only goal is to highlight since these are different
features from the feature list point of view.
All-multicast is a part of Rx mode.

In fact I recall that net/bonding does not preserve all-multicast
(CC maintainers). If there is an agreement to fix it, I can take
a look - it should not be hard to fix.

In general I think that notification is sufficient in this case.

>> Andrew Rybchenko (3):
>>    ethdev: advertise MTU as retained across device stop/start
>>    ethdev: advertise default MAC as retained on device restart
>>    ethdev: highlight that all-multicast is retained on restart
>>
>>   lib/librte_ethdev/rte_ethdev.h | 6 ++++--
>>   1 file changed, 4 insertions(+), 2 deletions(-)
>>

Re: [dpdk-dev] [PATCH v1 0/3] ethdev: document more retained across restart

[WILLIAMS, CHARLES J]

On 1/9/19 2:15 AM, Andrew Rybchenko wrote:
On 1/8/19 5:52 PM, Ferruh Yigit wrote:

On 12/19/2018 6:22 AM, Andrew Rybchenko wrote:


The patch series tries to improve documentation of what is retained
across default restart.


Overall makes sense to add below items into retained list, only concern if is
there any PMD conflicts with these information, they should either updated with
this patch or at least notified about expectation change.

From my point of view it is just clarification of the required behaviour.
MTU is required because of flag which may be used to advertise that
it is impossible to change in started state (otherwise the behaviour for
different PMDs will be absolutely different).
Default MAC is just cosmetics because of MAC address list is already
mentioned and the only goal is to highlight since these are different
features from the feature list point of view.
All-multicast is a part of Rx mode.

In fact I recall that net/bonding does not preserve all-multicast
(CC maintainers). If there is an agreement to fix it, I can take
a look - it should not be hard to fix.

I don't think bonding does anything particular because the all_multicast state of the bonding PMD isn't related to the slaves.  Currently, it's up to the applications to correctly configure multicast on the slaves.

On a side note, I don't think the registered multicast addresses are preserved across PMD stop/start (unless this has been fixed recently).

In general I think that notification is sufficient in this case.


Andrew Rybchenko (3):
  ethdev: advertise MTU as retained across device stop/start
  ethdev: advertise default MAC as retained on device restart
  ethdev: highlight that all-multicast is retained on restart

 lib/librte_ethdev/rte_ethdev.h | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

Re: [dpdk-dev] [PATCH v1 0/3] ethdev: document more retained across restart

[Andrew Rybchenko]

On 1/10/19 5:03 AM, WILLIAMS, CHARLES J wrote:
>
>
> On 1/9/19 2:15 AM, Andrew Rybchenko wrote:
>> On 1/8/19 5:52 PM, Ferruh Yigit wrote:
>>> On 12/19/2018 6:22 AM, Andrew Rybchenko wrote:
>>>> The patch series tries to improve documentation of what is retained
>>>> across default restart.
>>> Overall makes sense to add below items into retained list, only concern if is
>>> there any PMD conflicts with these information, they should either updated with
>>> this patch or at least notified about expectation change.
>>
>> From my point of view it is just clarification of the required behaviour.
>> MTU is required because of flag which may be used to advertise that
>> it is impossible to change in started state (otherwise the behaviour for
>> different PMDs will be absolutely different).
>> Default MAC is just cosmetics because of MAC address list is already
>> mentioned and the only goal is to highlight since these are different
>> features from the feature list point of view.
>> All-multicast is a part of Rx mode.
>>
>> In fact I recall that net/bonding does not preserve all-multicast
>> (CC maintainers). If there is an agreement to fix it, I can take
>> a look - it should not be hard to fix.
>
> I don't think bonding does anything particular because the 
> all_multicast state of the bonding PMD isn't related to the slaves.  
> Currently, it's up to the applications to correctly configure 
> multicast on the slaves.
>

May be I'm wrong but I think all-multicast handling should be similar to 
promiscuous mode handling in bonding: for all slaves in the case of 
round-robin, balance and broadcast, primary only in the case of active 
backup, TLB and ALB and when slave is added/removed in 802.3ad case.

> On a side note, I don't think the registered multicast addresses are 
> preserved across PMD stop/start (unless this has been fixed recently).
>

Yes, that's true, but I think it is separate story.

>>
>> In general I think that notification is sufficient in this case.
>>
>>>> Andrew Rybchenko (3):
>>>>    ethdev: advertise MTU as retained across device stop/start
>>>>    ethdev: advertise default MAC as retained on device restart
>>>>    ethdev: highlight that all-multicast is retained on restart
>>>>
>>>>   lib/librte_ethdev/rte_ethdev.h | 6 ++++--
>>>>   1 file changed, 4 insertions(+), 2 deletions(-)
>>>>
>>

Re: [dpdk-dev] [PATCH v1 0/3] ethdev: document more retained across restart

[Yigit, Ferruh]

On 12/19/2018 6:22 AM, Andrew Rybchenko wrote:
> The patch series tries to improve documentation of what is retained
> across default restart.
> 
> Andrew Rybchenko (3):
>   ethdev: advertise MTU as retained across device stop/start
>   ethdev: advertise default MAC as retained on device restart
>   ethdev: highlight that all-multicast is retained on restart
> 

Hi Thomas,

Is there any objection on this patchset? If not I am planning to merge it.

Thanks,
ferruh

Re: [dpdk-dev] [PATCH v1 0/3] ethdev: document more retained across restart

[Yigit, Ferruh]

On 12/19/2018 6:22 AM, Andrew Rybchenko wrote:
> The patch series tries to improve documentation of what is retained
> across default restart.
> 
> Andrew Rybchenko (3):
>   ethdev: advertise MTU as retained across device stop/start
>   ethdev: advertise default MAC as retained on device restart
>   ethdev: highlight that all-multicast is retained on restart
> 

Hi Thomas,

Is there any objection on this patchset? If not I am planning to merge it.

Thanks,
ferruh

Re: [dpdk-dev] [PATCH v1 0/3] ethdev: document more retained across restart

[Thomas Monjalon]

19/03/2019 14:21, Yigit, Ferruh:
> On 12/19/2018 6:22 AM, Andrew Rybchenko wrote:
> > The patch series tries to improve documentation of what is retained
> > across default restart.
> > 
> > Andrew Rybchenko (3):
> >   ethdev: advertise MTU as retained across device stop/start
> >   ethdev: advertise default MAC as retained on device restart
> >   ethdev: highlight that all-multicast is retained on restart
> > 
> 
> Hi Thomas,
> 
> Is there any objection on this patchset? If not I am planning to merge it.

No objection, more clarification in doxygen is always good.

Re: [dpdk-dev] [PATCH v1 0/3] ethdev: document more retained across restart

[Thomas Monjalon]

19/03/2019 14:21, Yigit, Ferruh:
> On 12/19/2018 6:22 AM, Andrew Rybchenko wrote:
> > The patch series tries to improve documentation of what is retained
> > across default restart.
> > 
> > Andrew Rybchenko (3):
> >   ethdev: advertise MTU as retained across device stop/start
> >   ethdev: advertise default MAC as retained on device restart
> >   ethdev: highlight that all-multicast is retained on restart
> > 
> 
> Hi Thomas,
> 
> Is there any objection on this patchset? If not I am planning to merge it.

No objection, more clarification in doxygen is always good.

Re: [dpdk-dev] [PATCH v1 0/3] ethdev: document more retained across restart

[Ferruh Yigit]

On 3/20/2019 2:26 PM, Thomas Monjalon wrote:
> 19/03/2019 14:21, Yigit, Ferruh:
>> On 12/19/2018 6:22 AM, Andrew Rybchenko wrote:
>>> The patch series tries to improve documentation of what is retained
>>> across default restart.
>>>
>>> Andrew Rybchenko (3):
>>>   ethdev: advertise MTU as retained across device stop/start
>>>   ethdev: advertise default MAC as retained on device restart
>>>   ethdev: highlight that all-multicast is retained on restart
>>>
>>
>> Hi Thomas,
>>
>> Is there any objection on this patchset? If not I am planning to merge it.
> 
> No objection, more clarification in doxygen is always good.
> 

This may be defining the behavior more than clarification.

Can I add your explicit ACK?

Re: [dpdk-dev] [PATCH v1 0/3] ethdev: document more retained across restart

[Ferruh Yigit]

On 3/20/2019 2:26 PM, Thomas Monjalon wrote:
> 19/03/2019 14:21, Yigit, Ferruh:
>> On 12/19/2018 6:22 AM, Andrew Rybchenko wrote:
>>> The patch series tries to improve documentation of what is retained
>>> across default restart.
>>>
>>> Andrew Rybchenko (3):
>>>   ethdev: advertise MTU as retained across device stop/start
>>>   ethdev: advertise default MAC as retained on device restart
>>>   ethdev: highlight that all-multicast is retained on restart
>>>
>>
>> Hi Thomas,
>>
>> Is there any objection on this patchset? If not I am planning to merge it.
> 
> No objection, more clarification in doxygen is always good.
> 

This may be defining the behavior more than clarification.

Can I add your explicit ACK?

Re: [dpdk-dev] [PATCH v1 0/3] ethdev: document more retained across restart

[Thomas Monjalon]

20/03/2019 16:25, Ferruh Yigit:
> On 3/20/2019 2:26 PM, Thomas Monjalon wrote:
> > 19/03/2019 14:21, Yigit, Ferruh:
> >> On 12/19/2018 6:22 AM, Andrew Rybchenko wrote:
> >>> The patch series tries to improve documentation of what is retained
> >>> across default restart.
> >>>
> >>> Andrew Rybchenko (3):
> >>>   ethdev: advertise MTU as retained across device stop/start
> >>>   ethdev: advertise default MAC as retained on device restart
> >>>   ethdev: highlight that all-multicast is retained on restart
> >>>
> >>
> >> Hi Thomas,
> >>
> >> Is there any objection on this patchset? If not I am planning to merge it.
> > 
> > No objection, more clarification in doxygen is always good.
> > 
> 
> This may be defining the behavior more than clarification.
> 
> Can I add your explicit ACK?

Acked-by: Thomas Monjalon <thomas@monjalon.net>

Re: [dpdk-dev] [PATCH v1 0/3] ethdev: document more retained across restart

[Thomas Monjalon]

20/03/2019 16:25, Ferruh Yigit:
> On 3/20/2019 2:26 PM, Thomas Monjalon wrote:
> > 19/03/2019 14:21, Yigit, Ferruh:
> >> On 12/19/2018 6:22 AM, Andrew Rybchenko wrote:
> >>> The patch series tries to improve documentation of what is retained
> >>> across default restart.
> >>>
> >>> Andrew Rybchenko (3):
> >>>   ethdev: advertise MTU as retained across device stop/start
> >>>   ethdev: advertise default MAC as retained on device restart
> >>>   ethdev: highlight that all-multicast is retained on restart
> >>>
> >>
> >> Hi Thomas,
> >>
> >> Is there any objection on this patchset? If not I am planning to merge it.
> > 
> > No objection, more clarification in doxygen is always good.
> > 
> 
> This may be defining the behavior more than clarification.
> 
> Can I add your explicit ACK?

Acked-by: Thomas Monjalon <thomas@monjalon.net>

Re: [dpdk-dev] [PATCH v1 0/3] ethdev: document more retained across restart

[Ferruh Yigit]

On 3/20/2019 3:32 PM, Thomas Monjalon wrote:
> 20/03/2019 16:25, Ferruh Yigit:
>> On 3/20/2019 2:26 PM, Thomas Monjalon wrote:
>>> 19/03/2019 14:21, Yigit, Ferruh:
>>>> On 12/19/2018 6:22 AM, Andrew Rybchenko wrote:
>>>>> The patch series tries to improve documentation of what is retained
>>>>> across default restart.
>>>>>
>>>>> Andrew Rybchenko (3):
>>>>>   ethdev: advertise MTU as retained across device stop/start
>>>>>   ethdev: advertise default MAC as retained on device restart
>>>>>   ethdev: highlight that all-multicast is retained on restart
>>>>>
>>>>
>>>> Hi Thomas,
>>>>
>>>> Is there any objection on this patchset? If not I am planning to merge it.
>>>
>>> No objection, more clarification in doxygen is always good.
>>>
>>
>> This may be defining the behavior more than clarification.
>>
>> Can I add your explicit ACK?
> 
> Acked-by: Thomas Monjalon <thomas@monjalon.net>
> 

Series applied to dpdk-next-net/master, thanks.

Re: [dpdk-dev] [PATCH v1 0/3] ethdev: document more retained across restart

[Ferruh Yigit]

On 3/20/2019 3:32 PM, Thomas Monjalon wrote:
> 20/03/2019 16:25, Ferruh Yigit:
>> On 3/20/2019 2:26 PM, Thomas Monjalon wrote:
>>> 19/03/2019 14:21, Yigit, Ferruh:
>>>> On 12/19/2018 6:22 AM, Andrew Rybchenko wrote:
>>>>> The patch series tries to improve documentation of what is retained
>>>>> across default restart.
>>>>>
>>>>> Andrew Rybchenko (3):
>>>>>   ethdev: advertise MTU as retained across device stop/start
>>>>>   ethdev: advertise default MAC as retained on device restart
>>>>>   ethdev: highlight that all-multicast is retained on restart
>>>>>
>>>>
>>>> Hi Thomas,
>>>>
>>>> Is there any objection on this patchset? If not I am planning to merge it.
>>>
>>> No objection, more clarification in doxygen is always good.
>>>
>>
>> This may be defining the behavior more than clarification.
>>
>> Can I add your explicit ACK?
> 
> Acked-by: Thomas Monjalon <thomas@monjalon.net>
> 

Series applied to dpdk-next-net/master, thanks.