From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wg0-f52.google.com (mail-wg0-f52.google.com [74.125.82.52]) by dpdk.org (Postfix) with ESMTP id 5DD868047 for ; Mon, 24 Nov 2014 19:22:28 +0100 (CET) Received: by mail-wg0-f52.google.com with SMTP id a1so13300677wgh.25 for ; Mon, 24 Nov 2014 10:33:17 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=okEHSlsrGx+hJPDZ+StId9DIFom4eWOxYXZuUOqezFA=; b=MQ0maIGRCrVjVIqor9YRvCF72q0/U1y7PKreqm+KunI9xv5GZdi47I4JpnkAVqT3xg VRw+3E9pJhjvYcctL5cbCmdJ2I3CHGYx33PWu6+3VmzduN76khVmF06poRPSYx7oXhoF 8PbN7k5FIA6mQ7518+Hg/R9H1YbEPORrl1fn8bW4qzKf6xjJ2SkdhCKNHmszSB9vmq7x NPiZdFwk5nu7Zlb+ygT7iJxHUJWIfagJwhPl5Ibr1DZhCUu4LoDYcrvuSP6zuEP+nozs Q90NJedpWFqWxI1TNhinjMtayk5e1R0T/kw82u1bUJhis+ptYmrj/JXBLZETNHCUEiYD rJXw== X-Gm-Message-State: ALoCoQl9JgYudzqjDTPdseOSsZJRWifrMiI7PFlzUomUdxQ6sCWTFJ9bgzF2jUZSdTAaup7S0L20 X-Received: by 10.194.123.99 with SMTP id lz3mr18862743wjb.31.1416853997168; Mon, 24 Nov 2014 10:33:17 -0800 (PST) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id fk16sm13133104wic.16.2014.11.24.10.33.15 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 24 Nov 2014 10:33:16 -0800 (PST) From: Thomas Monjalon To: Declan Doherty Date: Mon, 24 Nov 2014 19:32:53 +0100 Message-ID: <2517538.3XrK7rMMtj@xps13> Organization: 6WIND User-Agent: KMail/4.14.2 (Linux/3.17.2-1-ARCH; KDE/4.14.2; x86_64; ; ) In-Reply-To: <1416846822-26897-1-git-send-email-declan.doherty@intel.com> References: <1416832054-24086-1-git-send-email-declan.doherty@intel.com> <1416846822-26897-1-git-send-email-declan.doherty@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v8 0/7] link bonding X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 24 Nov 2014 18:22:28 -0000 Declan, There are still some missing spaces: WARNING:MISSING_SPACE: break quoted strings at a space character #2002: FILE: lib/librte_pmd_bond/rte_eth_bond_pmd.c:1406: + "Invalid lsc polling interval value specified for bonded" + "device %s\n", name); WARNING:MISSING_SPACE: break quoted strings at a space character #2016: FILE: lib/librte_pmd_bond/rte_eth_bond_pmd.c:1420: + "LSC polling interval can be specified only once for bonded" + "device %s\n", name); WARNING:MISSING_SPACE: break quoted strings at a space character #2040: FILE: lib/librte_pmd_bond/rte_eth_bond_pmd.c:1444: + "Failed to set link up propagation delay (%u ms) on bonded" + "device %s\n", link_up_delay_ms, name); WARNING:MISSING_SPACE: break quoted strings at a space character #2061: FILE: lib/librte_pmd_bond/rte_eth_bond_pmd.c:1465: + "Invalid link down propagation delay value specified for" + "bonded device %s\n", name); WARNING:MISSING_SPACE: break quoted strings at a space character #3674: FILE: app/test/test_link_bonding.c:3672: + "slave port (%d) mac address not set to that of new primary" + "port", test_params->slave_port_ids[i]); I'm fixing it for you because I'm losing confidence all bonding patches will be ready on time. Some i40e patches won't be applied today because I spend more time on bonding. For next release cycle, I'll have to be more strict. Please Declan, could you be the bonding maintainer and ensure other bonding patches (mode 4, mode 5, fixes) to come are ready and nothing will delay their integration? Thanks -- Thomas 2014-11-24 16:33, Declan Doherty: > v8: > - Missing typo fix > - Missing whitespace > > v7: > - Fixes for checkpatch issues and typo fixes > - Removed patch "test app: adding support for generating variable sized" as this > was already committed in commit aca4360340f169dcc11b1a9be955b44de8b9f6eb > Declan Doherty (7): > bond: link status interrupt support > bond: removing switch statement from rx burst method > bond: fix naming inconsistency in tx_burst_round_robin > bond: free mbufs if transmission fails in bonding tx_burst functions > testpmd: adding parameter to reconfig method to set socket_id when > adding new port to portlist > bond: lsc polling support > bond: unit test test macro refactor