From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 00DDFA046B for ; Fri, 28 Jun 2019 10:55:28 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A85694C6C; Fri, 28 Jun 2019 10:55:28 +0200 (CEST) Received: from wout1-smtp.messagingengine.com (wout1-smtp.messagingengine.com [64.147.123.24]) by dpdk.org (Postfix) with ESMTP id EB1203195 for ; Fri, 28 Jun 2019 10:55:26 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id CF9743A9; Fri, 28 Jun 2019 04:55:25 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Fri, 28 Jun 2019 04:55:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=kR/fbao31f9bLzoTmDc1PdrA2HyoJe05eOMU41E+maM=; b=dcJdSQ2x4W/E 15hh7tctmvLm0+AK4BH0rIPF0uf57xG7PzkIZMa12zuBYzVI4ec2KhHkI5WCVNAo Ug1ardj/fBhPQf+4HCveoCzLKweQmK+EjJysZQCtkwzFmDv/d6YghO5CopeZ51wV 8jRXqN4tBDdfKIliDV8P0dKguW0dG6A= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=kR/fbao31f9bLzoTmDc1PdrA2HyoJe05eOMU41E+m aM=; b=X9rVi5fKcO3lT3kLeps0IfvDRJ+Sv8EeH6/SgPRVU7oL6bfhtIPYvF+5+ +3kqQ8S+f/w7Askg3JDHv/BTQfHbsGgrrbI42/bRXF+oMaMluaicKZvYIl+gUcfj 9C6cnSA87Gc75cykDVPp8VnYHrK7E3S8jA2kyiclPchVhC+NNWd+i4Zm1aUsR32t QF5QpmMJzZtLR83rbnUAPad7JEYlbOhB19uJwfjylW2XHEDs+S6rratpI9E1WHC7 CYlHUX4lh8nAwXEN6Zwp4pIgxKtvJgbeOyfs59M4fhbJ5t6CvmFHT38uvOq+odyU ZvTkRWTYr+H6ebodkLtA0c4WxtGNQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduvddrvddtgdduudcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph epjeejrddufeegrddvtdefrddukeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhho mhgrshesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 1EDC68005A; Fri, 28 Jun 2019 04:55:24 -0400 (EDT) From: Thomas Monjalon To: pbhagavatula@marvell.com Cc: jerinj@marvell.com, Anatoly Burakov , dev@dpdk.org, Nithin Dabilpuram Date: Fri, 28 Jun 2019 10:55:23 +0200 Message-ID: <2520364.DbCxe8khD8@xps> In-Reply-To: <20190628075024.404-2-pbhagavatula@marvell.com> References: <20190628075024.404-1-pbhagavatula@marvell.com> <20190628075024.404-2-pbhagavatula@marvell.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2 01/44] event/octeontx2: add build infra and device probe X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, I'm checking some ordering in this patch: 28/06/2019 09:49, pbhagavatula@marvell.com: > From: Pavan Nikhilesh > --- a/config/common_base > +++ b/config/common_base > @@ -747,6 +747,11 @@ CONFIG_RTE_LIBRTE_PMD_DPAA2_QDMA_RAWDEV=n > # > CONFIG_RTE_LIBRTE_PMD_IFPGA_RAWDEV=y > > +# > +# Compile PMD for octeontx sso event device > +# > +CONFIG_RTE_LIBRTE_PMD_OCTEONTX2_EVENTDEV=y Looks like you chose this line randomly? Would be better to add after CONFIG_RTE_LIBRTE_PMD_OCTEONTX_SSOVF. > # > # Compile librte_ring > # > diff --git a/drivers/event/Makefile b/drivers/event/Makefile > index 03ad1b6cb..e4e7eff37 100644 > --- a/drivers/event/Makefile > +++ b/drivers/event/Makefile > @@ -15,5 +15,6 @@ ifeq ($(CONFIG_RTE_EAL_VFIO)$(CONFIG_RTE_LIBRTE_FSLMC_BUS),yy) > DIRS-$(CONFIG_RTE_LIBRTE_PMD_DPAA2_EVENTDEV) += dpaa2 > endif > DIRS-$(CONFIG_RTE_LIBRTE_PMD_OPDL_EVENTDEV) += opdl > +DIRS-$(CONFIG_RTE_LIBRTE_PMD_OCTEONTX2_EVENTDEV) += octeontx2 Same here, should be after octeontx. > --- a/drivers/event/meson.build > +++ b/drivers/event/meson.build > @@ -1,7 +1,7 @@ > # SPDX-License-Identifier: BSD-3-Clause > # Copyright(c) 2017 Intel Corporation > > -drivers = ['dpaa', 'dpaa2', 'opdl', 'skeleton', 'sw', 'dsw'] > +drivers = ['dpaa', 'dpaa2', 'opdl', 'skeleton', 'sw', 'dsw', 'octeontx2'] Could be before opdl (and keep SW ones at the end). > --- a/mk/rte.app.mk > +++ b/mk/rte.app.mk > @@ -109,6 +109,7 @@ ifeq ($(CONFIG_RTE_LIBRTE_PMD_OCTEONTX_SSOVF)$(CONFIG_RTE_LIBRTE_OCTEONTX_MEMPOO > _LDLIBS-y += -lrte_common_octeontx > endif > OCTEONTX2-y := $(CONFIG_RTE_LIBRTE_OCTEONTX2_MEMPOOL) > +OCTEONTX2-y += $(CONFIG_RTE_LIBRTE_PMD_OCTEONTX2_EVENTDEV) > ifeq ($(findstring y,$(OCTEONTX2-y)),y) > _LDLIBS-y += -lrte_common_octeontx2 > endif > @@ -293,6 +294,7 @@ endif # CONFIG_RTE_LIBRTE_FSLMC_BUS > _LDLIBS-$(CONFIG_RTE_LIBRTE_OCTEONTX_MEMPOOL) += -lrte_mempool_octeontx > _LDLIBS-$(CONFIG_RTE_LIBRTE_OCTEONTX_PMD) += -lrte_pmd_octeontx > _LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_OPDL_EVENTDEV) += -lrte_pmd_opdl_event > +_LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_OCTEONTX2_EVENTDEV) += -lrte_pmd_octeontx2_event Should be after OCTEONTX. > endif # CONFIG_RTE_LIBRTE_EVENTDEV