From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f46.google.com (mail-wm0-f46.google.com [74.125.82.46]) by dpdk.org (Postfix) with ESMTP id EC888C5FE for ; Sat, 20 Feb 2016 21:49:39 +0100 (CET) Received: by mail-wm0-f46.google.com with SMTP id g62so114648829wme.0 for ; Sat, 20 Feb 2016 12:49:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding :content-type; bh=jkVXukuM8tOD6FKShq3ynoG+HobiIMfnWccHCAHoQ8s=; b=KkfNMq5nYQdkU2YQ6Ykwq3A2RKdqgni86M0EON6VJfhwMwHVEHcpd0uqbAeFx4WykI d2abaaq4RDcRkAkd5Hfd4sEdaXI4k4EojE20BUXgqDtYTQ0tsS8THo72qL9xEkQV9TKZ Ih07EgpEL4AMeEY1EcYlXP5hlUPjuP69Bnh0RxiMKrTTxKYZKRljEHL8XXbW8NoJri5p vrivbpmNpBt/Mm08fKc1IHoZWeEmt1PI3LMauuiA12op31NJMILH2f0JejUdEO1sUARP td41LdYZqgkOZD9kYE7f1LrovDUrGqBqgm6jR2rUdhCXGfOksHIslGlfisNEE4WAmWu4 jEdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=jkVXukuM8tOD6FKShq3ynoG+HobiIMfnWccHCAHoQ8s=; b=XUkqhnKgXpWRg/gJiCzg25la0W8jcb0Ga4GH5BKvU5sQ/KNonTyNstscoeRFI5SU77 NguCnR2mFG6SAyqkHfQMO7nRAQtFEiiRW1WX1IAEmvrccoX1kANT+Lq4KDxp4UxCXTF5 Y0+PX7MzBm1uWFiD33JSNjP2mCgxWiovpXBaKpntnNtv8oAegtw1Gd6rlHaqjWqCwn/q SM3Srmi7i+St4VKg95dkEA6sTVTYj/yT9+r9euMnkNYTguICUkLhc7VV3mQjUaezCLcE y3a4bKDSKcQFK42YE9gXY7W7q9l4tbwmuVOLTIlMM6UwcSY/bLAbQOn7/Rp+yBWt2DA8 KtXQ== X-Gm-Message-State: AG10YORjPLSHz/6ok9Mh9zzd97gyVm0CvZ8/da7drbjib0KqCJ7Ku+kCBcvKWoy8OIYKJeg4 X-Received: by 10.28.221.136 with SMTP id u130mr4018393wmg.40.1456001379772; Sat, 20 Feb 2016 12:49:39 -0800 (PST) Received: from xps13.localnet (171.36.101.84.rev.sfr.net. [84.101.36.171]) by smtp.gmail.com with ESMTPSA id hm9sm17094361wjb.34.2016.02.20.12.49.37 (version=TLSv1/SSLv3 cipher=OTHER); Sat, 20 Feb 2016 12:49:38 -0800 (PST) Date: Sat, 20 Feb 2016 12:49:38 -0800 (PST) X-Google-Original-Date: Sat, 20 Feb 2016 21:48 +0100 From: Thomas Monjalon To: Harish Patil Message-ID: <2521824.WtpN8U54QY@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <1455982831-21682-1-git-send-email-harish.patil@qlogic.com> References: <1455982831-21682-1-git-send-email-harish.patil@qlogic.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH 0/6] DPDK PMD for new QLogic FastLinQ QL4xxxx 25G/40G CNAs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 20 Feb 2016 20:49:40 -0000 2016-02-20 07:40, Harish Patil: > This patch set introduces DPDK poll mode driver for new QLogic FastLinQ QL4xxxx > 25G/40G capable family of CNAs as well as their SR-IOV Virtual Functions (VF). > > The overall PMD driver design includes a common module called ecore that deals > with the low level HW and a upper layer portion that provides the glue logic. > > Specifically, the ecore module contains all of the common logic, > e.g. initialization, cleanup, infrastructure for interrupt handling, link > management, slowpath etc. as well as protocol agnostic features and supplying > an abstraction layer for other modules. > > The higher layer implements DPDK exported APIs/driver entry points by > interfacing with the common module for configuration/status and also the > fastpath routines. A new driver is always a good news :) Please could you share some performance numbers? What is the status about the integration of this driver in other environments? The layer named ecore seems to be what is named a base driver in other DPDK drivers. Maybe you could consider renaming the directory to base/ for consistency? About the format of the patches, I think it's better to split driver imports in several pieces to ease reviewing and later reference for specific bugs. What do you think of introducing basic features one by one?