From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] doc: announce ABI change for librte_port
Date: Thu, 16 Jul 2015 14:25:49 +0200 [thread overview]
Message-ID: <2522078.kODQ7Zxo1C@xps13> (raw)
In-Reply-To: <1437049176-6866-1-git-send-email-cristian.dumitrescu@intel.com>
2015-07-16 13:19, Cristian Dumitrescu:
> +* librte_port (rte_port.h): Macros to access the packet meta-data stored within
> + the packet buffer will be adjusted to cover the packet mbuf structure as well,
> + as currently they are able to access any packet buffer location except the
> + packet mbuf structure. The consequence is that applications currently using
> + these macros will have to adjust the value of the offset parameter of these
> + macros by increasing it with sizeof(struc rte_mbuf). The affected macros are:
> + RTE_MBUF_METADATA_UINT<8, 16, 32, 64>_PTR and
> + RTE_MBUF_METADATA_UINT<8, 16, 32, 64>. In terms of code changes, most likely
> + only the definition of RTE_MBUF_METADATA_UINT8_PTR macro will be changed from
> + ``(&((uint8_t *) &(mbuf)[1])[offset])`` to
> + ``(&((uint8_t *) (mbuf))[offset])``.
Cristian,
General comment: you are too verbose :)
Specifically on this patch: same comment ;)
next prev parent reply other threads:[~2015-07-16 12:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-16 12:19 Cristian Dumitrescu
2015-07-16 12:25 ` Gajdzica, MaciejX T
2015-07-16 12:25 ` Thomas Monjalon [this message]
2015-07-16 15:09 ` Dumitrescu, Cristian
2015-07-16 12:30 ` Mrzyglod, DanielX T
2015-07-16 12:49 ` Singh, Jasvinder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2522078.kODQ7Zxo1C@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=cristian.dumitrescu@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).