From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wi0-f173.google.com (mail-wi0-f173.google.com
[209.85.212.173]) by dpdk.org (Postfix) with ESMTP id CBD6268AA
for <dev@dpdk.org>; Wed, 17 Dec 2014 23:20:53 +0100 (CET)
Received: by mail-wi0-f173.google.com with SMTP id r20so17346557wiv.12
for <dev@dpdk.org>; Wed, 17 Dec 2014 14:20:53 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20130820;
h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
:user-agent:in-reply-to:references:mime-version
:content-transfer-encoding:content-type;
bh=JProG2pRUpfSdCCGA9UXYKc7VEoaWupqhj8+rEIrcFg=;
b=VDGAB9UZPNS9CAPpo1uIFPFt7pa5nZr+2Wi61t64dAqNNcwBBd6HVJoP4kLMYJ72YQ
j00so0wzvhUORm2PC2B76wzH4rj4xGboMC86QgPCpKjPJSzqx+97TikBOzyp/GzyuzYI
dmfWuQKZ1KlHfJVb3uAH6oN43QVQ05ojc3hXdrjN1cW3pgHDZVguIm48GArEeyu4x7Le
cSS7wXMKvFL+0MUn99oeEkAlXEqT+5CPLt1qBC6QkWi2wubq+AZnCJn9vZ9OMn50aCJY
Fc758uxPXucg2X6MBfbootNWM5rsveQoR58JGFjQhV+hw+BD78/2KSoEGDT0fJkbqqrq
3D/w==
X-Gm-Message-State: ALoCoQncUtmRjanCA6T2aYtJb2ikQHTxsrZmNn5vvJvkUM4gCcV8WCS+TykrsT+xyxkwmp9AZlWt
X-Received: by 10.180.7.201 with SMTP id l9mr18128283wia.80.1418854853640;
Wed, 17 Dec 2014 14:20:53 -0800 (PST)
Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136])
by mx.google.com with ESMTPSA id u1sm22522720wif.6.2014.12.17.14.20.52
(version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
Wed, 17 Dec 2014 14:20:52 -0800 (PST)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Neil Horman <nhorman@tuxdriver.com>
Date: Wed, 17 Dec 2014 23:20:26 +0100
Message-ID: <2522675.0gKbYfjInz@xps13>
Organization: 6WIND
User-Agent: KMail/4.14.3 (Linux/3.17.4-1-ARCH; KDE/4.14.3; x86_64; ; )
In-Reply-To: <1418835808-18803-1-git-send-email-nhorman@tuxdriver.com>
References: <1418835808-18803-1-git-send-email-nhorman@tuxdriver.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] xenvirt: Fix build break on
cmdline_parse_etheraddr call
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 17 Dec 2014 22:20:54 -0000
Hi Neil,
2014-12-17 12:03, Neil Horman:
> Back in:
>
> commit aaa662e75c23c61a1d79bd4d1f9f35b4967c39db
> Author: Alan Carew <alan.carew@intel.com>
> Date: Fri Dec 5 15:19:07 2014 +0100
>
> cmdline: fix overflow on bsd
>
> The author failed to fixup a call to cmdline_parse_etheraddr in xenvirt. This
> patch makes the needed correction to avoid a build break
>
> Signed-off-by: Neil Horman <nhorman@tuxdriver.com>
> CC: Thomas Monjalon <thomas.monjalon@6wind.com>
What is the meaning of CC here?
> --- a/lib/librte_pmd_xenvirt/rte_eth_xenvirt.c
> +++ b/lib/librte_pmd_xenvirt/rte_eth_xenvirt.c
> @@ -586,8 +586,9 @@ rte_eth_xenvirt_parse_args(struct xenvirt_dict *dict,
> if (!strncmp(pair[0], RTE_ETH_XENVIRT_MAC_PARAM,
> sizeof(RTE_ETH_XENVIRT_MAC_PARAM))) {
> if (cmdline_parse_etheraddr(NULL,
> - pair[1],
> - &dict->addr) < 0) {
> + pair[1],
> + &dict->addr,
> + sizeof(struct ether_addr)) < 0) {
Why not sizeof(dict->addr)?
--
Thomas