From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id D7E401B446; Mon, 22 Apr 2019 23:05:40 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 51A4B21FB6; Mon, 22 Apr 2019 17:05:40 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Mon, 22 Apr 2019 17:05:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=SVyrf7pAHqHiyOW4CVyMCIDuJNvXlQsF8aq9BZozA9g=; b=b5ljSTbKhXiK /QVmrNfghWnrE7sVjmG0Ic0kXWZ6ybJnRyG95Qgq2K6zssCZvt9xxJFKyk69Go3B SVkfCpT8bJ/CtA+0FxHtitJEQVqY98nm9HTf92cr9eSU6L+RZhHmI4crGmruaxiV qsU2/D/gi8/THbhByz96QVKJN26tHXs= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=SVyrf7pAHqHiyOW4CVyMCIDuJNvXlQsF8aq9BZozA 9g=; b=sEduyIBQ0juEcytQCF1K29a4cKTCGjygmiCytqN1aVO66LBhxZch0kxPp /9P2zhiMWb9qIdu0ZDoF43sxv41OhbxApeylXcPIm2paii+FAOfVPXklEMqWIiJK SP/OCwOTR7eDTLAdcuQ7X4Q/aEaiIHI6rC+zAK5ILafKiEinZXbbXDZTEDFRtV/+ Eqaw8VV7Ef3J1sHKph/bpjaVamweuszqFHvioP2+LT5B2mSy/+4D7r5P2UrMDhlD N+wPomln9xjNNk5oNOx78YwcQwZHxuNthkm6InnscqxwQGJ/y18GmcjLazUGdHKs GNFJwI8mHRMCkkPvg6RO2Yn2Y1FRw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrgeeigddugeekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecukf hppeekfedrudduhedrudehhedrudefkeenucfrrghrrghmpehmrghilhhfrhhomhepthhh ohhmrghssehmohhnjhgrlhhonhdrnhgvthenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from xps.localnet (acaen-257-1-30-138.w83-115.abo.wanadoo.fr [83.115.155.138]) by mail.messagingengine.com (Postfix) with ESMTPA id 1F988103C9; Mon, 22 Apr 2019 17:05:37 -0400 (EDT) From: Thomas Monjalon To: David Hunt Cc: dev@dpdk.org, Rami Rosen , stable@dpdk.org Date: Mon, 22 Apr 2019 23:05:35 +0200 Message-ID: <2524354.HtNxz6UQSK@xps> In-Reply-To: References: <20190410131348.25287-1-david.hunt@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v1] examples/vm_power_manager: fix unreachable code X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Apr 2019 21:05:41 -0000 > > A for loop to MAX_VFS had a break as the last line, so the w++ > > would never get called, breaking out of the loop after the > > first iteration. Remove the break so that the loop can execute > > properly. > > > > Fixes: ace158c4a821 ("examples/vm_power: add check for port count") > > Coverity issue: 337682 > > > > Signed-off-by: David Hunt > > Acked-by: Rami Rosen Applied, thanks From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 44810A05D3 for ; Mon, 22 Apr 2019 23:05:45 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 01FA51B473; Mon, 22 Apr 2019 23:05:43 +0200 (CEST) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id D7E401B446; Mon, 22 Apr 2019 23:05:40 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 51A4B21FB6; Mon, 22 Apr 2019 17:05:40 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Mon, 22 Apr 2019 17:05:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=SVyrf7pAHqHiyOW4CVyMCIDuJNvXlQsF8aq9BZozA9g=; b=b5ljSTbKhXiK /QVmrNfghWnrE7sVjmG0Ic0kXWZ6ybJnRyG95Qgq2K6zssCZvt9xxJFKyk69Go3B SVkfCpT8bJ/CtA+0FxHtitJEQVqY98nm9HTf92cr9eSU6L+RZhHmI4crGmruaxiV qsU2/D/gi8/THbhByz96QVKJN26tHXs= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=SVyrf7pAHqHiyOW4CVyMCIDuJNvXlQsF8aq9BZozA 9g=; b=sEduyIBQ0juEcytQCF1K29a4cKTCGjygmiCytqN1aVO66LBhxZch0kxPp /9P2zhiMWb9qIdu0ZDoF43sxv41OhbxApeylXcPIm2paii+FAOfVPXklEMqWIiJK SP/OCwOTR7eDTLAdcuQ7X4Q/aEaiIHI6rC+zAK5ILafKiEinZXbbXDZTEDFRtV/+ Eqaw8VV7Ef3J1sHKph/bpjaVamweuszqFHvioP2+LT5B2mSy/+4D7r5P2UrMDhlD N+wPomln9xjNNk5oNOx78YwcQwZHxuNthkm6InnscqxwQGJ/y18GmcjLazUGdHKs GNFJwI8mHRMCkkPvg6RO2Yn2Y1FRw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrgeeigddugeekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecukf hppeekfedrudduhedrudehhedrudefkeenucfrrghrrghmpehmrghilhhfrhhomhepthhh ohhmrghssehmohhnjhgrlhhonhdrnhgvthenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from xps.localnet (acaen-257-1-30-138.w83-115.abo.wanadoo.fr [83.115.155.138]) by mail.messagingengine.com (Postfix) with ESMTPA id 1F988103C9; Mon, 22 Apr 2019 17:05:37 -0400 (EDT) From: Thomas Monjalon To: David Hunt Cc: dev@dpdk.org, Rami Rosen , stable@dpdk.org Date: Mon, 22 Apr 2019 23:05:35 +0200 Message-ID: <2524354.HtNxz6UQSK@xps> In-Reply-To: References: <20190410131348.25287-1-david.hunt@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v1] examples/vm_power_manager: fix unreachable code X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190422210535.08x1hjBp-vyxFEB4zANfktm_D5euMpwdn-Q65407FRM@z> > > A for loop to MAX_VFS had a break as the last line, so the w++ > > would never get called, breaking out of the loop after the > > first iteration. Remove the break so that the loop can execute > > properly. > > > > Fixes: ace158c4a821 ("examples/vm_power: add check for port count") > > Coverity issue: 337682 > > > > Signed-off-by: David Hunt > > Acked-by: Rami Rosen Applied, thanks