From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 51477A00BE; Sun, 26 Apr 2020 23:12:29 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 203BC1C1C9; Sun, 26 Apr 2020 23:12:28 +0200 (CEST) Received: from wout5-smtp.messagingengine.com (wout5-smtp.messagingengine.com [64.147.123.21]) by dpdk.org (Postfix) with ESMTP id 3B3DA1C1C7; Sun, 26 Apr 2020 23:12:26 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.west.internal (Postfix) with ESMTP id EABC7490; Sun, 26 Apr 2020 17:12:23 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute7.internal (MEProxy); Sun, 26 Apr 2020 17:12:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= yZjQi6NIWZyRg3hcacTGubf0PsgoQymUqwOl/hFS1zQ=; b=bp/0lDK+IePP07uS EP+9+jqJqlJfCy+kDZPctFK7VvdMZnT99aHHvuQTf2Gu5VvwuYm/NMWs1oiDCi2E MSngQkmS0CmCbSlMcOB3NJsWb4iUO84u/zSRYryL56EQw5Ldfa2gk1/tL0o+rsEy wevF4Ss/aQDXeZlQncAGRxRlrGzIHgInCvlnMS2tkTsP8DjD2UPDo+9c9BbGtaCH MYfZBQwJEtLI3i2CO9FIDwHTcrutpu5i77ZNxcLAthESwROwqlyTJd9leOrYAr1b nln4EF0Q90yGlIH/SFQkSozFvXJeIAvFc4kx/OHnqwxDaGbJhc7QeTqrHCQFjKzJ Yj3MTg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=yZjQi6NIWZyRg3hcacTGubf0PsgoQymUqwOl/hFS1 zQ=; b=QavwGmArfgZRvEG0795BlwoVpkRyAkl/Evc+fpNyIgkiNr6Y7Pk1N7tkv yQvRYzxAbV5Yceet/OmzNQCa1zhcwNLeBKMi9IYJ39sOk3SIvq0oeXKHEOsArL+8 Q659SjJiDX26A7yjfR9nQHJuk+OkqU3+krCWd+iUxW801qgRmMKDsHnR8p6BoctY OegcXQQE1kHPdPasKj8YUWBiahKyWeXA9CmImM1/0iXzN4yep5ryfJwIQKFf31WD lMWb5iHdDMd1xgxUC7WsK+vdmYfKkrZ824J68csyDLmopr1/tpmhOeJmNXgphimw n+zMU6yML/HTnRJIoiY2fapXa4mgA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrheejgdduheekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecukf hppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghrufhiiigvpedtnecurfgr rhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id E1A663280066; Sun, 26 Apr 2020 17:12:22 -0400 (EDT) From: Thomas Monjalon To: Louise Kilheeney Cc: dev@dpdk.org, stable@dpdk.org Date: Sun, 26 Apr 2020 23:12:20 +0200 Message-ID: <2525651.hTDNKPQEx9@thomas> In-Reply-To: <20200311120456.36510-1-louise.kilheeney@intel.com> References: <20200311120456.36510-1-louise.kilheeney@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] examples/l2fwd-keepalive: fix packet drops limited mbufs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 11/03/2020 13:04, Louise Kilheeney: > MBUF pool of size 8192 was causing packet loss when using four ports. To > fix this issue this patch specifies the number of MBUF's per port > instead of having one set MBUF pool size, this way it will adapt to any > number of ports. > > Fixes: e64833f2273a ("examples/l2fwd-keepalive: add sample application") > > Cc: stable@dpdk.org No blank line between Fixes and Cc lines please. > > Signed-off-by: Louise Kilheeney > --- > examples/l2fwd-keepalive/main.c | 17 ++++++++++------- > 1 file changed, 10 insertions(+), 7 deletions(-) > > diff --git a/examples/l2fwd-keepalive/main.c b/examples/l2fwd-keepalive/main.c > index b36834974..0f0010d51 100644 > --- a/examples/l2fwd-keepalive/main.c > +++ b/examples/l2fwd-keepalive/main.c > nb_ports = rte_eth_dev_count_avail(); > if (nb_ports == 0) > rte_exit(EXIT_FAILURE, "No Ethernet ports - bye\n"); > > + /* create the mbuf pool */ > + unsigned int total_nb_mbufs = NB_MBUF_PER_PORT * nb_ports; Please avoid declaring a variable in the middle of a function. This code style is too much modern for DPDK ;-) It could break on a random compiler.