From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D023D432BA; Mon, 6 Nov 2023 17:40:17 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 74D1D402B1; Mon, 6 Nov 2023 17:40:17 +0100 (CET) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by mails.dpdk.org (Postfix) with ESMTP id D0AC24025D for ; Mon, 6 Nov 2023 17:40:15 +0100 (CET) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 7534B5C0288; Mon, 6 Nov 2023 11:40:15 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Mon, 06 Nov 2023 11:40:15 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm3; t= 1699288815; x=1699375215; bh=+eVrApmU7l09W+fvMKfgMIoqI15P7nnHAx2 0HF3fqHQ=; b=X9aJWxxEiQqXlHe6dkA1+7HnZ/6wNf86akAmW5JArgrYarPxfte 9rdwwAMx0v/Yeq5yRifDKxiQCSroC4NKtzT9kE/4gO2MTU3zjQ7pxDC5JfZN7OuK UNAnu75rHlCAeBQkd/ONKDRLSGhKpvN9EGS3fKFw54q+r25Uv3nLgj4OYq7wta5g QkT+WMAKCle5dXNYMzMcXTMInt1Bp1H8aZt37q6JNt8IDAKvFk6rrIcT1NJ1gwx1 qqb/dQ+dSw+Io/VanHLt9EYdgePRwUlL2FzYg5Di6PjnvwNMyURsD2i9iMfZdNap hsFeuwV/hulfFZlUBl80n7EjE2HIBC8COgQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1699288815; x=1699375215; bh=+eVrApmU7l09W+fvMKfgMIoqI15P7nnHAx2 0HF3fqHQ=; b=V7OxjLToGFn8RTSi695vb2QRAzLR31iTjInkQmJFFBbgDkVetjc wZlTr5asxdyk/paJp47EdIuONHeXFIupE8QNdFN1LJB/oh14ChPR05fv2MZik6y2 OqI3C62kCZR2DH6oewWRaVohQe/THM66pR9bIYTM9Ef/1rv6Uo68LgN5R8+A90Oz aDYZipWrMK6Fe2rZHGO2EyMYa3FlyBxeLs2/58UnOj8VqcRh3eW4VCwP7/ciaEhd xkMk2Jqka9dZmAmPsigCgaiqZYaaAMWTIc7NkZRiyrZjNqK5adWUIIOznM0V5qGM 3WrIZQ0NMMjoDHtzT8uATtFTRT8zZtamm2A== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedruddugedgledtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedtjeeiieefhedtfffgvdelteeufeefheeujefgueetfedttdei kefgkeduhedtgfenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 6 Nov 2023 11:40:14 -0500 (EST) From: Thomas Monjalon To: Tyler Retzlaff Cc: dev@dpdk.org, Jerin Jacob , Sunil Kumar Kori , david.marchand@redhat.com Subject: Re: [PATCH] eal: provide trace point register macro for MSVC Date: Mon, 06 Nov 2023 17:40:12 +0100 Message-ID: <2526524.4XsnlVU6TS@thomas> In-Reply-To: <1698878822-17099-1-git-send-email-roretzla@linux.microsoft.com> References: <1698878822-17099-1-git-send-email-roretzla@linux.microsoft.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 01/11/2023 23:47, Tyler Retzlaff: > Provide an alternate RTE_TRACE_POINT_REGISTER macro when building with > MSVC that allocates segments for the trace point using MSVC specific > features Please could you elaborate what is the improvement? > +#define RTE_TRACE_POINT_REGISTER(trace, name) \ > +rte_trace_point_t \ > +__pragma(data_seg("__rte_trace_point")) \ > +__declspec(allocate("__rte_trace_point")) \ > +__##trace; \ > +static const char __##trace##_name[] = RTE_STR(name); \ > +RTE_INIT(trace##_init) \ > +{ \ > + __rte_trace_point_register(&__##trace, __##trace##_name, \ > + (void (*)(void)) trace); \ > +}