DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Amit Prakash Shukla <amitprakashs@marvell.com>
Cc: Rasesh Mody <rmody@marvell.com>,
	Devendra Singh Rawat <dsinghrawat@marvell.com>,
	stable@dpdk.org, dev@dpdk.org, jerinj@marvell.com
Subject: Re: [PATCH 2/2] net/qede/base: compilation fix for GCC-12
Date: Thu, 06 Oct 2022 11:52:56 +0200	[thread overview]
Message-ID: <2528100.Lt9SDvczpP@thomas> (raw)
In-Reply-To: <20220824140339.2581716-2-amitprakashs@marvell.com>

24/08/2022 16:03, Amit Prakash Shukla:
> GCC 12 raises the following warning:
> 
> ../drivers/net/qede/base/ecore_init_fw_funcs.c: In function
> 'ecore_dmae_to_grc.constprop.isra':
> ../drivers/net/qede/base/ecore_init_fw_funcs.c:1418:25:
> 	error: array subscript 1 is outside array bounds of 'u32[1]'
> 	{aka 'unsigned int[1]'} [-Werror=array-bounds]
>  1418 |                         ecore_wr(dev, ptt, ((addr) + (4 * i)),  \
>       |                         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>  1419 |                                  ((u32 *)&(arr))[i]);           \
>       |                                  ~~~~~~~~~~~~~~~~~~~
> ../drivers/net/qede/base/ecore_init_fw_funcs.c:1465:17: note:
> 	in expansion of macro 'ARR_REG_WR'
>  1465 |            ARR_REG_WR(p_hwfn, p_ptt, addr, pData, len_in_dwords);
>       |            ^~~~~~~~~~
> ../drivers/net/qede/base/ecore_init_fw_funcs.c:1439:35:
> 	note: at offset 4 into object 'pData' of size 4
>  1439 |                              u32 *pData,
>       |                              ~~~~~^~~~~
> cc1: all warnings being treated as errors
> 
> Fixes: 3b307c55f2ac (net/qede/base: update FW to 8.40.25.0)
> Cc: stable@dpdk.org
> 
> Signed-off-by: Amit Prakash Shukla <amitprakashs@marvell.com>

Sorry I did not notice this patch and I recently submitted one
which I will abandon.
It seems there was no reply from qede maintainers after 6 weeks,
but I will apply anyway.

I will use my commit message:

    net/qede/base: fix 32-bit build with GCC 12
    
    A pointer is passed to a macro and it seems mistakenly referenced.
    This issue is seen only when compiling with GCC 12 for 32-bit:
    
    drivers/net/qede/base/ecore_init_fw_funcs.c:1418:25:
            error: array subscript 1 is outside array bounds of ‘u32[1]’
            {aka ‘unsigned int[1]’} [-Werror=array-bounds]
     1418 |                 ecore_wr(dev, ptt, ((addr) + (4 * i)),  \
          |                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
     1419 |                          ((u32 *)&(arr))[i]);           \
          |                          ~~~~~~~~~~~~~~~~~~~
    drivers/net/qede/base/ecore_init_fw_funcs.c:1465:17:
            note: in expansion of macro ‘ARR_REG_WR’
     1465 |         ARR_REG_WR(p_hwfn, p_ptt, addr, pData, len_in_dwords);
          |         ^~~~~~~~~~
    drivers/net/qede/base/ecore_init_fw_funcs.c:1439:35:
            note: at offset 4 into object ‘pData’ of size 4
     1439 |                              u32 *pData,
          |                              ~~~~~^~~~~
    
    Fixes: 3b307c55f2ac ("net/qede/base: update FW to 8.40.25.0")
    Cc: stable@dpdk.org




  reply	other threads:[~2022-10-06  9:53 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-23 10:57 [PATCH 1/3] net/i40e: " Amit Prakash Shukla
2022-08-23 10:57 ` [PATCH 2/3] net/qede/base: " Amit Prakash Shukla
2022-08-23 10:57 ` [PATCH 3/3] examples/ipsec-secgw: " Amit Prakash Shukla
2022-08-23 13:12   ` Akhil Goyal
2022-08-24 14:03 ` [PATCH 1/2] net/i40e: " Amit Prakash Shukla
2022-08-24 14:03   ` [PATCH 2/2] net/qede/base: " Amit Prakash Shukla
2022-10-06  9:52     ` Thomas Monjalon [this message]
2022-08-25  7:21   ` [PATCH 1/2] net/i40e: " Morten Brørup
2022-08-26  9:45   ` Amit Prakash Shukla
2022-08-26 10:32     ` Morten Brørup
2022-10-06  9:51   ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2528100.Lt9SDvczpP@thomas \
    --to=thomas@monjalon.net \
    --cc=amitprakashs@marvell.com \
    --cc=dev@dpdk.org \
    --cc=dsinghrawat@marvell.com \
    --cc=jerinj@marvell.com \
    --cc=rmody@marvell.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).